Skip to content

Commit 77e05d5

Browse files
Theo Johnson-KanuChromium LUCI CQ
Theo Johnson-Kanu
authored and
Chromium LUCI CQ
committed
[CrOS cellular] Update ICCID and IMEI network details property string
Update ICCID and IMEI network details property label for cellular networks. Screenshot: https://screenshot.googleplex.com/6LeY6LnwHiNrL34.png Bug: 1207790 Change-Id: I7be465c9181562277841e3e6141cca8c84262184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2888247 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#881683}
1 parent 054b6b7 commit 77e05d5

File tree

5 files changed

+14
-0
lines changed

5 files changed

+14
-0
lines changed

chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc

+2
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ void AddOncLocalizedStrings(content::WebUIDataSource* html_source) {
167167
{"OncCellular-HomeProvider-Country",
168168
IDS_ONC_CELLULAR_HOME_PROVIDER_COUNTRY},
169169
{"OncCellular-HomeProvider-Name", IDS_ONC_CELLULAR_HOME_PROVIDER_NAME},
170+
{"OncCellular-ICCID", IDS_ONC_CELLULAR_ICCID},
171+
{"OncCellular-IMEI", IDS_ONC_CELLULAR_IMEI},
170172
{"OncCellular-Manufacturer", IDS_ONC_CELLULAR_MANUFACTURER},
171173
{"OncCellular-ModelID", IDS_ONC_CELLULAR_MODEL_ID},
172174
{"OncCellular-NetworkTechnology", IDS_ONC_CELLULAR_NETWORK_TECHNOLOGY},

chromeos/chromeos_strings.grd

+6
Original file line numberDiff line numberDiff line change
@@ -1082,6 +1082,12 @@ Try tapping the mic to ask me anything.
10821082
<message name="IDS_ONC_CELLULAR_APN_ACCESS_POINT_NAME" desc="ONC Property label for APN-AccessPointName">
10831083
Access point name
10841084
</message>
1085+
<message name="IDS_ONC_CELLULAR_ICCID" desc="ONC Property label for Cellular.ICCID">
1086+
ICCID
1087+
</message>
1088+
<message name="IDS_ONC_CELLULAR_IMEI" desc="ONC Property label for Cellular.IMEI">
1089+
IMEI
1090+
</message>
10851091
<message name="IDS_ONC_CELLULAR_APN_ACCESS_POINT_NAME_NONE" desc="ONC Property label for APN-AccessPointName = none (or empty)">
10861092
None
10871093
</message>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
68aac77f2039ee439e7deafdd5ff9868704b7e75
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
68aac77f2039ee439e7deafdd5ff9868704b7e75

ui/webui/resources/cr_components/chromeos/network/network_property_list_mojo.js

+4
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,10 @@ Polymer({
229229
result += 'VPN';
230230
} else if (subKey === 'wifi') {
231231
result += 'WiFi';
232+
} else if (subKey === 'iccid') {
233+
result += 'ICCID';
234+
} else if (subKey === 'imei') {
235+
result += 'IMEI';
232236
} else {
233237
result += subKey.charAt(0).toUpperCase() + subKey.slice(1);
234238
}

0 commit comments

Comments
 (0)