From 6eff2bed7163a176416d57301f14bc34c2fa1732 Mon Sep 17 00:00:00 2001 From: yyanagisawa Date: Thu, 1 Sep 2016 07:23:31 -0700 Subject: [PATCH] Print result returned by compare_files. No differences on dependencies are shown with commit https://crrev.com/29b5fd95fd5f5b1e815cca5ef12c596a4e609620. That is because the code did not print difference at all. Let me print it if exists. Also, shows number of deps. BUG=314403 Review-Url: https://codereview.chromium.org/2293383005 Cr-Commit-Position: refs/heads/master@{#415947} --- tools/determinism/compare_build_artifacts.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/determinism/compare_build_artifacts.py b/tools/determinism/compare_build_artifacts.py index fb5293e118ad2a..d486cb99db63af 100755 --- a/tools/determinism/compare_build_artifacts.py +++ b/tools/determinism/compare_build_artifacts.py @@ -544,19 +544,22 @@ def get_deps(build_dir, target): def compare_deps(first_dir, second_dir, targets): """Print difference of dependent files.""" for target in targets: - print 'Checking %s difference:' % target first_deps = get_deps(first_dir, target) - second_deps =get_deps(second_dir, target) + second_deps = get_deps(second_dir, target) + print 'Checking %s difference: (%s deps)' % (target, len(first_deps)) if set(first_deps) != set(second_deps): # Since we do not thiks this case occur, we do not do anything special # for this case. print 'deps on %s are different: %s' % ( target, set(first_deps).symmetric_difference(set(second_deps))) continue + max_filepath_len = max(len(n) for n in first_deps) for d in first_deps: first_file = os.path.join(first_dir, d) second_file = os.path.join(second_dir, d) - compare_files(first_file, second_file) + result = compare_files(first_file, second_file) + if result: + print('%-*s: %s' % (max_filepath_len, d, result)) def compare_build_artifacts(first_dir, second_dir, target_platform,