Skip to content

Commit 64ed8f3

Browse files
Michael ChecoChromium LUCI CQ
Michael Checo
authored and
Chromium LUCI CQ
committed
Diagnostics: Update select dialog title
Screenshot: http://shortn/_ekjQ4Dqzds Bug: 1128204 Test: chromeos_components_unittests --gtest_filter=*SessionLog* Change-Id: If40fb5ed6422e692f0715343167811a915543e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2687750 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#853203}
1 parent 380899b commit 64ed8f3

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

chromeos/chromeos_strings.grd

+3
Original file line numberDiff line numberDiff line change
@@ -815,6 +815,9 @@ Try tapping the mic to ask me anything.
815815
<message name="IDS_DIAGNOSTICS_SESSION_LOG_TOAST_TEXT_FAILURE" desc="The text shown when the session log download fails.">
816816
Download failed
817817
</message>
818+
<message name="IDS_DIAGNOSTICS_SELECT_DIALOG_TITLE" desc="The text used as the title of the select dialog used for choosing the folder to save the session log to.">
819+
Select a folder to save to
820+
</message>
818821

819822
<!-- Quick Answers -->
820823
<message name="IDS_QUICK_ANSWERS_DEFINITION_TITLE_TEXT" desc="The title text format string used for Quick Answers definition result card. The first placeholder contains the source query text and the second placeholder contains the phonetics.">
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
499dccba6f568535a06cab27239999fa1b3c07be

chromeos/components/diagnostics_ui/backend/BUILD.gn

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ static_library("backend") {
3838
"//chromeos/dbus/power:power_manager_proto",
3939
"//chromeos/services/cros_healthd/public/cpp",
4040
"//chromeos/services/cros_healthd/public/mojom",
41+
"//chromeos/strings/",
4142
"//content/public/browser",
4243
"//services/data_decoder/public/cpp",
4344
"//ui/base",

chromeos/components/diagnostics_ui/backend/session_log_handler.cc

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@
77
#include "base/files/file_path.h"
88
#include "base/files/file_util.h"
99
#include "base/strings/strcat.h"
10-
#include "base/strings/string16.h"
1110
#include "base/strings/utf_string_conversions.h"
1211
#include "base/values.h"
1312
#include "chromeos/components/diagnostics_ui/backend/routine_log.h"
1413
#include "chromeos/components/diagnostics_ui/backend/telemetry_log.h"
14+
#include "chromeos/strings/grit/chromeos_strings.h"
1515
#include "content/public/browser/web_contents.h"
16+
#include "ui/base/l10n/l10n_util.h"
1617
#include "ui/gfx/native_widget_types.h"
1718
#include "ui/shell_dialogs/select_file_policy.h"
1819

@@ -107,10 +108,9 @@ void SessionLogHandler::HandleSaveSessionLogRequest(
107108

108109
select_file_dialog_ = ui::SelectFileDialog::Create(
109110
this, select_file_policy_creator_.Run(web_contents));
110-
// TODO(michaelcheco): Add string for dialog title.
111111
select_file_dialog_->SelectFile(
112112
ui::SelectFileDialog::SELECT_SAVEAS_FILE,
113-
/*title=*/base::ASCIIToUTF16(""),
113+
/*title=*/l10n_util::GetStringUTF16(IDS_DIAGNOSTICS_SELECT_DIALOG_TITLE),
114114
/*default_path=*/base::FilePath(kDefaultSessionLogFileName),
115115
/*file_types=*/nullptr,
116116
/*file_type_index=*/0,

0 commit comments

Comments
 (0)