Skip to content

Commit 4fd49fe

Browse files
danakjCommit bot
authored and
Commit bot
committed
Add a table of contents to the c++11 style guide.
It's hard/annoying to find the library allowed features by scrolling, now we can link to them all, yay. R=thakis@chromium.org BUG=554287 Review URL: https://codereview.chromium.org/1452373002 Cr-Commit-Position: refs/heads/master@{#360409}
1 parent 45bc9a4 commit 4fd49fe

File tree

1 file changed

+23
-7
lines changed

1 file changed

+23
-7
lines changed

styleguide/c++/c++11.html

+23-7
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,28 @@ <h1>C++11 use in Chromium</h1>
3535
Ideally include a short blurb on what the feature is, and why you think it
3636
should or should not be allowed. Ideally, the list will arrive at some
3737
consensus and the wiki page will be updated to mention that consensus. If
38-
there's no consensus, <code>src/styleguide/C++/OWNERS</code> get to decide --
38+
there's no consensus, <code>src/styleguide/c++/OWNERS</code> get to decide --
3939
for divisive features, we expect the decision to be to not use the feature yet
4040
and possibly discuss it again a few months later, when we have more experience
4141
with the language.</p>
4242

43-
<h2 id="whitelist">C++11 Allowed Features</h2>
43+
<h2>Table of Contents</h2>
44+
<ol class="toc">
45+
<li>Allowed Features<ol>
46+
<li><a href="#core-whitelist">Language</a></li>
47+
<li><a href="#library-whitelist">Library</a></li>
48+
</ol></li>
49+
<li>Banned Features<ol>
50+
<li><a href="#core-blacklist">Language</a></li>
51+
<li><a href="#library-blacklist">Library</a></li>
52+
</ol></li>
53+
<li>To Be Discussed<ol>
54+
<li><a href="#core-review">Language</a></li>
55+
<li><a href="#library-review">Library</a></li>
56+
</ol></li>
57+
</ol>
58+
59+
<h2 id="whitelist"><a name="core-whitelist"></a>C++11 Allowed Features</h2>
4460

4561
<p>The following features are currently allowed.</p>
4662

@@ -258,7 +274,7 @@ <h2 id="whitelist">C++11 Allowed Features</h2>
258274
</tbody>
259275
</table>
260276

261-
<h2 id="whitelist">C++11 Allowed Library Features</h2>
277+
<h2 id="whitelist"><a name="library-whitelist"></a>C++11 Allowed Library Features</h2>
262278

263279
<p>The following library features are currently allowed.</p>
264280

@@ -325,7 +341,7 @@ <h2 id="blacklist">C++11 Blacklist (Disallowed and Banned Features)</h2>
325341

326342
<p>This section lists features that are not allowed to be used yet.
327343

328-
<h3 id="blacklist_banned">C++11 Banned Features</h3>
344+
<h3 id="blacklist_banned"><a name="core-blacklist"></a>C++11 Banned Features</h3>
329345

330346
<p>This section lists C++11 features that are not allowed in the Chromium
331347
codebase.
@@ -448,7 +464,7 @@ <h3 id="blacklist_banned">C++11 Banned Features</h3>
448464
</tbody>
449465
</table>
450466

451-
<h3 id="whitelist">C++11 Banned Library Features</h3>
467+
<h3 id="blacklist_stdlib"><a name="library-blacklist"></a>C++11 Banned Library Features</h3>
452468

453469
<p>This section lists C++11 library features that are not allowed in the Chromium codebase.</p>
454470

@@ -492,7 +508,7 @@ <h3 id="whitelist">C++11 Banned Library Features</h3>
492508
</table>
493509

494510

495-
<h3 id="blacklist_review">C++11 Features To Be Discussed</h3>
511+
<h3 id="blacklist_review"><a name="core-review"></a>C++11 Features To Be Discussed</h3>
496512

497513
<p>The following C++ language features are currently disallowed.
498514
See the top of this page on how to propose moving a feature from this list
@@ -590,7 +606,7 @@ <h3 id="blacklist_review">C++11 Features To Be Discussed</h3>
590606
</tbody>
591607
</table>
592608

593-
<h3 id="blacklist_stdlib">C++11 Standard Library Features To Be Discussed</h3>
609+
<h3 id="blacklist_stdlib_review"><a name="library-review"></a>C++11 Standard Library Features To Be Discussed</h3>
594610

595611
<p>The following C++ library features are currently disallowed. See the top of this page on how to propose moving a feature from this list into the allowed or banned sections. Note that not all of these features work in all our compilers yet.</p>
596612

0 commit comments

Comments
 (0)