Skip to content

Commit 4a50b8a

Browse files
nhirokiCommit Bot
authored and
Commit Bot
committed
net: Add NOLINT(build/header_guard) in header files under net/
This CL adds NOLINT(build/header_guard) in header files used for generating enum values to suppress Tricium warning. The comments and guard code are copied from net/base/net_error_list.h Bug: n/a Change-Id: I88df01fe3427a8b2702813457e391a18185adfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061929 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742133}
1 parent c5fdd18 commit 4a50b8a

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

net/base/load_states_list.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
// found in the LICENSE file.
44

55
// This file intentionally does not have header guards, it's included
6-
// inside a macro to generate values. The following line silences a
7-
// presubmit warning that would otherwise be triggered by this:
6+
// inside a macro to generate enum values. The following line silences a
7+
// presubmit and Tricium warning that would otherwise be triggered by this:
88
// no-include-guard-because-multiply-included
9+
// NOLINT(build/header_guard)
910

1011
// This is the list of load states and their values. For the enum values,
1112
// include the file "net/base/load_states.h".

net/base/net_info_source_list.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44

55
// This file intentionally does not have header guards, it's included
66
// inside a macro to generate enum values. The following line silences a
7-
// presubmit warning that would otherwise be triggered by this:
7+
// presubmit and Tricium warning that would otherwise be triggered by this:
88
// no-include-guard-because-multiply-included
9+
// NOLINT(build/header_guard)
910

1011
// Flags used to request different types of information about the current state
1112
// of a URLRequestContext.

net/filter/source_stream_type_list.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
// found in the LICENSE file.
44

55
// This file intentionally does not have header guards, it's included
6-
// inside a macro to generate values. The following line silences a
7-
// presubmit warning that would otherwise be triggered by this:
6+
// inside a macro to generate enum values. The following line silences a
7+
// presubmit and Tricium warning that would otherwise be triggered by this:
88
// no-include-guard-because-multiply-included
9+
// NOLINT(build/header_guard)
910

1011
// Specifies type of filters that can be created. Do not change the values
1112
// of this enum; it is preserved in a histogram.

net/http/http_status_code_list.h

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
// found in the LICENSE file.
44

55
// This file intentionally does not have header guards, it's included
6-
// inside a macro to generate enum. The following line silences a
7-
// presubmit warning that would otherwise be triggered by this:
6+
// inside a macro to generate enum values. The following line silences a
7+
// presubmit and Tricium warning that would otherwise be triggered by this:
88
// no-include-guard-because-multiply-included
9+
// NOLINT(build/header_guard)
910

1011
// This file contains the list of HTTP status codes. Taken from IANA HTTP Status
1112
// Code Registry.

0 commit comments

Comments
 (0)