From 2f0ded1a7eba7d8cc7a749d5156b1d98e1cf81f6 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Thu, 14 Mar 2019 02:08:10 +0000 Subject: [PATCH] DevTools: Don't use event.keyIdentifier It is deprecated. Bug: 633619 Change-Id: I24e33f31bf84fcd53ab5c8878e83ae6be872ff16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504754 Reviewed-by: Erik Luo Commit-Queue: Joel Einbinder Cr-Commit-Position: refs/heads/master@{#640589} --- .../devtools/front_end/accessibility/ARIAAttributesView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/blink/renderer/devtools/front_end/accessibility/ARIAAttributesView.js b/third_party/blink/renderer/devtools/front_end/accessibility/ARIAAttributesView.js index 434cefe9ed14de..a8a61db691268f 100644 --- a/third_party/blink/renderer/devtools/front_end/accessibility/ARIAAttributesView.js +++ b/third_party/blink/renderer/devtools/front_end/accessibility/ARIAAttributesView.js @@ -177,7 +177,7 @@ Accessibility.ARIAAttributesTreeElement = class extends UI.TreeElement { return; } - if (event.keyCode === UI.KeyboardShortcut.Keys.Esc.code || event.keyIdentifier === 'U+001B') { + if (isEscKey(event)) { this._editingCancelled(); event.consume(); return;