From 2b719bc619134f52873a68ce8b590c7057bdd8ed Mon Sep 17 00:00:00 2001 From: Andrey Kosyakov Date: Wed, 29 Sep 2021 23:27:58 +0000 Subject: [PATCH] Remove application_cache domain from headless client AppCache is going away. Bug: 582750, 1084190 Change-Id: I925145aa16cbd62edf2802e2d49fa39f0efa5c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194564 Commit-Queue: Andrey Kosyakov Commit-Queue: Peter Kvitek Auto-Submit: Andrey Kosyakov Reviewed-by: Peter Kvitek Cr-Commit-Position: refs/heads/main@{#926529} --- headless/BUILD.gn | 1 - headless/lib/browser/headless_devtools_client_impl.cc | 5 ----- headless/public/headless_devtools_client.h | 4 ---- headless/public/internal/headless_devtools_client_impl.h | 3 --- 4 files changed, 13 deletions(-) diff --git a/headless/BUILD.gn b/headless/BUILD.gn index 685d8d4e0534d..a6bee3780c721 100644 --- a/headless/BUILD.gn +++ b/headless/BUILD.gn @@ -137,7 +137,6 @@ grit("resources") { devtools_domains = [ "accessibility", "animation", - "application_cache", "browser", "cache_storage", "console", diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc index a8e12b5428f02..ef7379051f480 100644 --- a/headless/lib/browser/headless_devtools_client_impl.cc +++ b/headless/lib/browser/headless_devtools_client_impl.cc @@ -40,7 +40,6 @@ HeadlessDevToolsClient::CreateWithExternalHost(ExternalHost* external_host) { HeadlessDevToolsClientImpl::HeadlessDevToolsClientImpl() : accessibility_domain_(this), animation_domain_(this), - application_cache_domain_(this), browser_domain_(this), cache_storage_domain_(this), console_domain_(this), @@ -320,10 +319,6 @@ animation::Domain* HeadlessDevToolsClientImpl::GetAnimation() { return &animation_domain_; } -application_cache::Domain* HeadlessDevToolsClientImpl::GetApplicationCache() { - return &application_cache_domain_; -} - browser::Domain* HeadlessDevToolsClientImpl::GetBrowser() { return &browser_domain_; } diff --git a/headless/public/headless_devtools_client.h b/headless/public/headless_devtools_client.h index f2c042dd12156..14c7d74441f14 100644 --- a/headless/public/headless_devtools_client.h +++ b/headless/public/headless_devtools_client.h @@ -24,9 +24,6 @@ class Domain; namespace animation { class Domain; } -namespace application_cache { -class Domain; -} namespace browser { class Domain; } @@ -153,7 +150,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClient { // the capabilities of each domain. virtual accessibility::Domain* GetAccessibility() = 0; virtual animation::Domain* GetAnimation() = 0; - virtual application_cache::Domain* GetApplicationCache() = 0; virtual browser::Domain* GetBrowser() = 0; virtual cache_storage::Domain* GetCacheStorage() = 0; virtual console::Domain* GetConsole() = 0; diff --git a/headless/public/internal/headless_devtools_client_impl.h b/headless/public/internal/headless_devtools_client_impl.h index c1c31ae068955..d1825c15931d0 100644 --- a/headless/public/internal/headless_devtools_client_impl.h +++ b/headless/public/internal/headless_devtools_client_impl.h @@ -13,7 +13,6 @@ #include "base/sequenced_task_runner.h" #include "headless/public/devtools/domains/accessibility.h" #include "headless/public/devtools/domains/animation.h" -#include "headless/public/devtools/domains/application_cache.h" #include "headless/public/devtools/domains/browser.h" #include "headless/public/devtools/domains/cache_storage.h" #include "headless/public/devtools/domains/console.h" @@ -71,7 +70,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClientImpl // HeadlessDevToolsClient implementation: accessibility::Domain* GetAccessibility() override; animation::Domain* GetAnimation() override; - application_cache::Domain* GetApplicationCache() override; browser::Domain* GetBrowser() override; cache_storage::Domain* GetCacheStorage() override; console::Domain* GetConsole() override; @@ -197,7 +195,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClientImpl accessibility::ExperimentalDomain accessibility_domain_; animation::ExperimentalDomain animation_domain_; - application_cache::ExperimentalDomain application_cache_domain_; browser::ExperimentalDomain browser_domain_; cache_storage::ExperimentalDomain cache_storage_domain_; console::ExperimentalDomain console_domain_;