From 0d66783912a12489277db9fedfe10231bc8783ec Mon Sep 17 00:00:00 2001 From: Keren Zhu Date: Sat, 16 Jan 2021 00:10:42 +0000 Subject: [PATCH] ui_devtools: Fix crash when closing while inspecting UI A DCHECK in ~EventHandler() of OverlayAgentAura checks if the event handler is removed from its target. Call RemovePreTargetHandler() in ~OverlayAgentAura() so that this condition is met when closing the browser window. Bug: 1163950 Change-Id: Ia8096f057af3bbfc54bc45ccde538dfdb09bf895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633691 Reviewed-by: Wei Li Commit-Queue: Keren Zhu Cr-Commit-Position: refs/heads/master@{#844296} --- components/ui_devtools/views/overlay_agent_aura.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/components/ui_devtools/views/overlay_agent_aura.cc b/components/ui_devtools/views/overlay_agent_aura.cc index 8cbf447db60637..604ad99990b2cb 100644 --- a/components/ui_devtools/views/overlay_agent_aura.cc +++ b/components/ui_devtools/views/overlay_agent_aura.cc @@ -22,6 +22,7 @@ OverlayAgentAura::OverlayAgentAura(DOMAgent* dom_agent) } OverlayAgentAura::~OverlayAgentAura() { + RemovePreTargetHandler(); overlay_agent_aura_ = nullptr; }