Skip to content

Commit 0286b6f

Browse files
author
justincohen@google.com
committed
Gyp changes for ninja iOS build.
Various tweaks to make ninja happy with our gyp files. ninja iOS builds don't CODE_SIGN yet. ninja only supports i386/simulator for now. pass parent_generator to mac_build.gypi for iOS sub-ninja builds BUG=236517 Review URL: https://chromiumcodereview.appspot.com/14577007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198084 0039d316-1c4b-4281-b951-d872f2087c98
1 parent 628f210 commit 0286b6f

File tree

3 files changed

+30
-13
lines changed

3 files changed

+30
-13
lines changed

build/common.gypi

+24-12
Original file line numberDiff line numberDiff line change
@@ -4032,17 +4032,22 @@
40324032
},
40334033
},
40344034
},
4035-
'xcode_settings': {
4036-
'conditions': [
4037-
['chromium_ios_signing', {
4038-
# iOS SDK wants everything for device signed.
4039-
'CODE_SIGN_IDENTITY[sdk=iphoneos*]': 'iPhone Developer',
4040-
}, {
4041-
'CODE_SIGNING_REQUIRED': 'NO',
4042-
'CODE_SIGN_IDENTITY[sdk=iphoneos*]': '',
4043-
}],
4044-
],
4045-
},
4035+
'conditions': [
4036+
# TODO(justincohen): ninja builds don't support signing yet.
4037+
['"<(GENERATOR)"!="ninja"', {
4038+
'xcode_settings': {
4039+
'conditions': [
4040+
['chromium_ios_signing', {
4041+
# iOS SDK wants everything for device signed.
4042+
'CODE_SIGN_IDENTITY[sdk=iphoneos*]': 'iPhone Developer',
4043+
}, {
4044+
'CODE_SIGNING_REQUIRED': 'NO',
4045+
'CODE_SIGN_IDENTITY[sdk=iphoneos*]': '',
4046+
}],
4047+
],
4048+
},
4049+
}],
4050+
],
40464051
}],
40474052
], # target_conditions
40484053
}, # target_defaults
@@ -4391,7 +4396,14 @@
43914396
['OS=="ios"', {
43924397
'conditions': [
43934398
['ios_sdk_path==""', {
4394-
'SDKROOT': 'iphoneos<(ios_sdk)', # -isysroot
4399+
'conditions': [
4400+
# TODO(justincohen): Ninja only supports simulator for now.
4401+
['"<(GENERATOR)"=="ninja"', {
4402+
'SDKROOT': 'iphonesimulator<(ios_sdk)', # -isysroot
4403+
}, {
4404+
'SDKROOT': 'iphoneos<(ios_sdk)', # -isysroot
4405+
}],
4406+
],
43954407
}, {
43964408
'SDKROOT': '<(ios_sdk_path)', # -isysroot
43974409
}],

build/ios/mac_build.gypi

+5
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@
3939
# }
4040
{
4141
'variables': {
42+
'variables': {
43+
'parent_generator%': '<(GENERATOR)',
44+
},
45+
'parent_generator%': '<(parent_generator)',
4246
# Common ninja command line flags.
4347
'ninja_cmd': [
4448
# Bounce through clean_env to clean up the environment so things
@@ -67,6 +71,7 @@
6771
'-Dios_mac_build=1',
6872
# Pass through the Mac SDK version.
6973
'-Dmac_sdk=<(mac_sdk)',
74+
'-Dparent_generator=<(parent_generator)'
7075
],
7176

7277
# Rerun gyp for each of the projects needed. This is what actually

build/landmines.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def get_target_build_dir(build_tool, target, is_iphone=False):
167167
target + ('-iphoneos' if is_iphone else ''))
168168
elif build_tool == 'make':
169169
ret = os.path.join(SRC_DIR, 'out', target)
170-
elif build_tool == 'ninja':
170+
elif build_tool in ['ninja', 'ninja-ios']:
171171
ret = os.path.join(SRC_DIR, 'out', target)
172172
elif build_tool in ['msvs', 'vs', 'ib']:
173173
ret = os.path.join(SRC_DIR, 'build', target)

0 commit comments

Comments
 (0)