forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathsync_reader.cc
303 lines (263 loc) · 11.5 KB
/
sync_reader.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "services/audio/sync_reader.h"
#include <algorithm>
#include <limits>
#include <string>
#include <utility>
#include "base/command_line.h"
#include "base/format_macros.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/stringprintf.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
#include "build/chromeos_buildflags.h"
#include "media/audio/audio_device_thread.h"
#include "media/base/audio_parameters.h"
#include "media/base/media_switches.h"
namespace {
// Used to log if any audio glitches have been detected during an audio session.
// Elements in this enum should not be added, deleted or rearranged.
enum AudioGlitchResult {
AUDIO_RENDERER_NO_AUDIO_GLITCHES = 0,
AUDIO_RENDERER_AUDIO_GLITCHES = 1,
AUDIO_RENDERER_AUDIO_GLITCHES_MAX = AUDIO_RENDERER_AUDIO_GLITCHES
};
void LogAudioGlitchResult(AudioGlitchResult result) {
UMA_HISTOGRAM_ENUMERATION("Media.AudioRendererAudioGlitches", result,
AUDIO_RENDERER_AUDIO_GLITCHES_MAX + 1);
}
} // namespace
namespace audio {
#if !defined(OS_MAC) && !BUILDFLAG(IS_CHROMEOS_ASH) && \
!BUILDFLAG(IS_CHROMEOS_LACROS)
const base::Feature kDynamicAudioTimeout{"DynamicAudioTimeout",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::FeatureParam<double> kBufferDurationPercent{
&kDynamicAudioTimeout, "buffer_duration_percent", 0.5};
#endif
SyncReader::SyncReader(
base::RepeatingCallback<void(const std::string&)> log_callback,
const media::AudioParameters& params,
base::CancelableSyncSocket* foreign_socket)
: log_callback_(std::move(log_callback)),
mute_audio_for_testing_(base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kMuteAudio)),
had_socket_error_(false),
output_bus_buffer_size_(
media::AudioBus::CalculateMemorySize(params.channels(),
params.frames_per_buffer())),
renderer_callback_count_(0),
renderer_missed_callback_count_(0),
trailing_renderer_missed_callback_count_(0),
buffer_index_(0) {
#if defined(OS_MAC) || BUILDFLAG(IS_CHROMEOS_ASH) || \
BUILDFLAG(IS_CHROMEOS_LACROS)
maximum_wait_time_ = params.GetBufferDuration() / 2;
#else
if (base::FeatureList::IsEnabled(kDynamicAudioTimeout)) {
maximum_wait_time_ =
params.GetBufferDuration() * kBufferDurationPercent.Get();
} else {
maximum_wait_time_ = base::Milliseconds(20);
}
#endif
base::CheckedNumeric<size_t> memory_size =
media::ComputeAudioOutputBufferSizeChecked(params);
if (!memory_size.IsValid())
return;
shared_memory_region_ =
base::UnsafeSharedMemoryRegion::Create(memory_size.ValueOrDie());
shared_memory_mapping_ = shared_memory_region_.Map();
if (shared_memory_region_.IsValid() && shared_memory_mapping_.IsValid() &&
base::CancelableSyncSocket::CreatePair(&socket_, foreign_socket)) {
auto* const buffer = reinterpret_cast<media::AudioOutputBuffer*>(
shared_memory_mapping_.memory());
output_bus_ = media::AudioBus::WrapMemory(params, buffer->audio);
output_bus_->Zero();
output_bus_->set_is_bitstream_format(params.IsBitstreamFormat());
}
}
SyncReader::~SyncReader() {
if (!renderer_callback_count_)
return;
// Subtract 'trailing' count of callbacks missed just before the destructor
// call. This happens if the renderer process was killed or e.g. the page
// refreshed while the output device was open etc.
// This trims off the end of both the missed and total counts so that we
// preserve the proportion of counts before the teardown period.
DCHECK_LE(trailing_renderer_missed_callback_count_,
renderer_missed_callback_count_);
DCHECK_LE(trailing_renderer_missed_callback_count_, renderer_callback_count_);
renderer_missed_callback_count_ -= trailing_renderer_missed_callback_count_;
renderer_callback_count_ -= trailing_renderer_missed_callback_count_;
if (!renderer_callback_count_)
return;
// Recording the percentage of deadline misses gives us a rough overview of
// how many users might be running into audio glitches.
int percentage_missed =
100.0 * renderer_missed_callback_count_ / renderer_callback_count_;
UMA_HISTOGRAM_PERCENTAGE("Media.AudioRendererMissedDeadline",
percentage_missed);
TRACE_EVENT_INSTANT1("audio", "~SyncReader", TRACE_EVENT_SCOPE_THREAD,
"Missed callback percentage", percentage_missed);
// Add more detailed information regarding detected audio glitches where
// a non-zero value of |renderer_missed_callback_count_| is added to the
// AUDIO_RENDERER_AUDIO_GLITCHES bin.
renderer_missed_callback_count_ > 0
? LogAudioGlitchResult(AUDIO_RENDERER_AUDIO_GLITCHES)
: LogAudioGlitchResult(AUDIO_RENDERER_NO_AUDIO_GLITCHES);
log_callback_.Run(base::StringPrintf(
"ASR: number of detected audio glitches: %" PRIuS " out of %" PRIuS,
renderer_missed_callback_count_, renderer_callback_count_));
}
bool SyncReader::IsValid() const {
if (output_bus_) {
DCHECK(shared_memory_region_.IsValid());
DCHECK(shared_memory_mapping_.IsValid());
DCHECK_NE(socket_.handle(), base::SyncSocket::kInvalidHandle);
return true;
}
return false;
}
base::UnsafeSharedMemoryRegion SyncReader::TakeSharedMemoryRegion() {
return std::move(shared_memory_region_);
}
// AudioOutputController::SyncReader implementations.
void SyncReader::RequestMoreData(base::TimeDelta delay,
base::TimeTicks delay_timestamp,
int prior_frames_skipped) {
// We don't send arguments over the socket since sending more than 4
// bytes might lead to being descheduled. The reading side will zero
// them when consumed.
auto* const buffer = reinterpret_cast<media::AudioOutputBuffer*>(
shared_memory_mapping_.memory());
// Increase the number of skipped frames stored in shared memory.
buffer->params.frames_skipped += prior_frames_skipped;
buffer->params.delay_us = delay.InMicroseconds();
buffer->params.delay_timestamp_us =
(delay_timestamp - base::TimeTicks()).InMicroseconds();
// Zero out the entire output buffer to avoid stuttering/repeating-buffers
// in the anomalous case if the renderer is unable to keep up with real-time.
output_bus_->Zero();
uint32_t control_signal = 0;
if (delay.is_max()) {
// std::numeric_limits<uint32_t>::max() is a special signal which is
// returned after the browser stops the output device in response to a
// renderer side request.
control_signal = std::numeric_limits<uint32_t>::max();
}
size_t sent_bytes = socket_.Send(&control_signal, sizeof(control_signal));
if (sent_bytes != sizeof(control_signal)) {
// Ensure we don't log consecutive errors as this can lead to a large
// amount of logs.
if (!had_socket_error_) {
had_socket_error_ = true;
static const char* socket_send_failure_message =
"ASR: No room in socket buffer.";
PLOG(WARNING) << socket_send_failure_message;
log_callback_.Run(socket_send_failure_message);
TRACE_EVENT_INSTANT0("audio", socket_send_failure_message,
TRACE_EVENT_SCOPE_THREAD);
}
} else {
had_socket_error_ = false;
}
++buffer_index_;
}
void SyncReader::Read(media::AudioBus* dest) {
++renderer_callback_count_;
if (!WaitUntilDataIsReady()) {
++trailing_renderer_missed_callback_count_;
++renderer_missed_callback_count_;
if (renderer_missed_callback_count_ <= 100 &&
renderer_missed_callback_count_ % 10 == 0) {
LOG(WARNING) << "SyncReader::Read timed out, audio glitch count="
<< renderer_missed_callback_count_;
if (renderer_missed_callback_count_ == 100)
LOG(WARNING) << "(log cap reached, suppressing further logs)";
}
dest->Zero();
return;
}
trailing_renderer_missed_callback_count_ = 0;
// Zeroed buffers may be discarded immediately when outputing compressed
// bitstream.
if (mute_audio_for_testing_ && !output_bus_->is_bitstream_format()) {
dest->Zero();
return;
}
if (output_bus_->is_bitstream_format()) {
// For bitstream formats, we need the real data size and PCM frame count.
auto* const buffer = reinterpret_cast<media::AudioOutputBuffer*>(
shared_memory_mapping_.memory());
uint32_t data_size = buffer->params.bitstream_data_size;
uint32_t bitstream_frames = buffer->params.bitstream_frames;
// |bitstream_frames| is cast to int below, so it must fit.
if (data_size > output_bus_buffer_size_ ||
!base::IsValueInRangeForNumericType<int>(bitstream_frames)) {
// Received data doesn't fit in the buffer, shouldn't happen.
dest->Zero();
return;
}
output_bus_->SetBitstreamDataSize(data_size);
output_bus_->SetBitstreamFrames(bitstream_frames);
output_bus_->CopyTo(dest);
return;
}
// Copy and clip data coming across the shared memory since it's untrusted.
output_bus_->CopyAndClipTo(dest);
}
void SyncReader::Close() {
socket_.Close();
output_bus_.reset();
}
bool SyncReader::WaitUntilDataIsReady() {
TRACE_EVENT0("audio", "SyncReader::WaitUntilDataIsReady");
base::TimeDelta timeout = maximum_wait_time_;
const base::TimeTicks start_time = base::TimeTicks::Now();
const base::TimeTicks finish_time = start_time + timeout;
// Check if data is ready and if not, wait a reasonable amount of time for it.
//
// Data readiness is achieved via parallel counters, one on the renderer side
// and one here. Every time a buffer is requested via UpdatePendingBytes(),
// |buffer_index_| is incremented. Subsequently every time the renderer has a
// buffer ready it increments its counter and sends the counter value over the
// SyncSocket. Data is ready when |buffer_index_| matches the counter value
// received from the renderer.
//
// The counter values may temporarily become out of sync if the renderer is
// unable to deliver audio fast enough. It's assumed that the renderer will
// catch up at some point, which means discarding counter values read from the
// SyncSocket which don't match our current buffer index.
size_t bytes_received = 0;
uint32_t renderer_buffer_index = 0;
while (timeout.InMicroseconds() > 0) {
bytes_received = socket_.ReceiveWithTimeout(
&renderer_buffer_index, sizeof(renderer_buffer_index), timeout);
if (bytes_received != sizeof(renderer_buffer_index)) {
bytes_received = 0;
break;
}
if (renderer_buffer_index == buffer_index_)
break;
// Reduce the timeout value as receives succeed, but aren't the right index.
timeout = finish_time - base::TimeTicks::Now();
}
// Receive timed out or another error occurred. Receive can timeout if the
// renderer is unable to deliver audio data within the allotted time.
if (!bytes_received || renderer_buffer_index != buffer_index_) {
TRACE_EVENT_INSTANT0("audio", "SyncReader::Read timed out",
TRACE_EVENT_SCOPE_THREAD);
base::TimeDelta time_since_start = base::TimeTicks::Now() - start_time;
UMA_HISTOGRAM_CUSTOM_TIMES("Media.AudioOutputControllerDataNotReady",
time_since_start, base::Milliseconds(1),
base::Milliseconds(1000), 50);
return false;
}
return true;
}
} // namespace audio