forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathtcp_client_socket_unittest.cc
1049 lines (859 loc) · 40 KB
/
tcp_client_socket_unittest.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// This file contains some tests for TCPClientSocket.
// transport_client_socket_unittest.cc contans some other tests that
// are common for TCP and other types of sockets.
#include "net/socket/tcp_client_socket.h"
#include <stddef.h>
#include <string>
#include <vector>
#include "base/strings/string_number_conversions.h"
#include "base/test/bind.h"
#include "base/test/power_monitor_test.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "net/base/features.h"
#include "net/base/ip_address.h"
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/log/net_log_source.h"
#include "net/nqe/network_quality_estimator_test_util.h"
#include "net/socket/socket_performance_watcher.h"
#include "net/socket/socket_test_util.h"
#include "net/socket/tcp_server_socket.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/gtest_util.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
// This matches logic in tcp_client_socket.cc. Only used once, but defining it
// in this file instead of just inlining the OS checks where its used makes it
// more grep-able.
#if !defined(OS_ANDROID)
#define TCP_CLIENT_SOCKET_OBSERVES_SUSPEND
#endif
using net::test::IsError;
using net::test::IsOk;
using testing::Not;
namespace base {
class TimeDelta;
}
namespace net {
namespace {
class TCPClientSocketTest : public testing::Test {
public:
TCPClientSocketTest()
: task_environment_(base::test::TaskEnvironment::MainThreadType::IO) {}
~TCPClientSocketTest() override { base::PowerMonitor::ShutdownForTesting(); }
void Suspend() { power_monitor_source_.Suspend(); }
void Resume() { power_monitor_source_.Resume(); }
void CreateConnectedSockets(
std::unique_ptr<StreamSocket>* accepted_socket,
std::unique_ptr<TCPClientSocket>* client_socket,
std::unique_ptr<ServerSocket>* server_socket_opt = nullptr) {
IPAddress local_address = IPAddress::IPv4Localhost();
std::unique_ptr<TCPServerSocket> server_socket =
std::make_unique<TCPServerSocket>(nullptr, NetLogSource());
ASSERT_THAT(server_socket->Listen(IPEndPoint(local_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server_socket->GetLocalAddress(&server_address), IsOk());
*client_socket = std::make_unique<TCPClientSocket>(
AddressList(server_address), nullptr, nullptr, nullptr, NetLogSource());
EXPECT_THAT((*client_socket)->Bind(IPEndPoint(local_address, 0)), IsOk());
IPEndPoint local_address_result;
EXPECT_THAT((*client_socket)->GetLocalAddress(&local_address_result),
IsOk());
EXPECT_EQ(local_address, local_address_result.address());
TestCompletionCallback connect_callback;
int connect_result = (*client_socket)->Connect(connect_callback.callback());
TestCompletionCallback accept_callback;
int result =
server_socket->Accept(accepted_socket, accept_callback.callback());
result = accept_callback.GetResult(result);
ASSERT_THAT(result, IsOk());
ASSERT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_TRUE((*client_socket)->IsConnected());
EXPECT_TRUE((*accepted_socket)->IsConnected());
if (server_socket_opt)
*server_socket_opt = std::move(server_socket);
}
private:
base::test::TaskEnvironment task_environment_;
base::test::ScopedPowerMonitorTestSource power_monitor_source_;
};
// Try binding a socket to loopback interface and verify that we can
// still connect to a server on the same interface.
TEST_F(TCPClientSocketTest, BindLoopbackToLoopback) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(lo_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
TCPClientSocket socket(AddressList(server_address), nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
IPEndPoint local_address_result;
EXPECT_THAT(socket.GetLocalAddress(&local_address_result), IsOk());
EXPECT_EQ(lo_address, local_address_result.address());
TestCompletionCallback connect_callback;
int connect_result = socket.Connect(connect_callback.callback());
TestCompletionCallback accept_callback;
std::unique_ptr<StreamSocket> accepted_socket;
int result = server.Accept(&accepted_socket, accept_callback.callback());
result = accept_callback.GetResult(result);
ASSERT_THAT(result, IsOk());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_TRUE(socket.IsConnected());
socket.Disconnect();
EXPECT_FALSE(socket.IsConnected());
EXPECT_EQ(ERR_SOCKET_NOT_CONNECTED,
socket.GetLocalAddress(&local_address_result));
}
// Try to bind socket to the loopback interface and connect to an
// external address, verify that connection fails.
TEST_F(TCPClientSocketTest, BindLoopbackToExternal) {
IPAddress external_ip(72, 14, 213, 105);
TCPClientSocket socket(AddressList::CreateFromIPAddress(external_ip, 80),
nullptr, nullptr, nullptr, NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(IPAddress::IPv4Localhost(), 0)), IsOk());
TestCompletionCallback connect_callback;
int result = socket.Connect(connect_callback.callback());
// We may get different errors here on different system, but
// connect() is not expected to succeed.
EXPECT_THAT(connect_callback.GetResult(result), Not(IsOk()));
}
// Bind a socket to the IPv4 loopback interface and try to connect to
// the IPv6 loopback interface, verify that connection fails.
TEST_F(TCPClientSocketTest, BindLoopbackToIPv6) {
TCPServerSocket server(nullptr, NetLogSource());
int listen_result =
server.Listen(IPEndPoint(IPAddress::IPv6Localhost(), 0), 1);
if (listen_result != OK) {
LOG(ERROR) << "Failed to listen on ::1 - probably because IPv6 is disabled."
" Skipping the test";
return;
}
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
TCPClientSocket socket(AddressList(server_address), nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(IPAddress::IPv4Localhost(), 0)), IsOk());
TestCompletionCallback connect_callback;
int result = socket.Connect(connect_callback.callback());
EXPECT_THAT(connect_callback.GetResult(result), Not(IsOk()));
}
TEST_F(TCPClientSocketTest, WasEverUsed) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(lo_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
TCPClientSocket socket(AddressList(server_address), nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_FALSE(socket.WasEverUsed());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
// Just connecting the socket should not set WasEverUsed.
TestCompletionCallback connect_callback;
int connect_result = socket.Connect(connect_callback.callback());
EXPECT_FALSE(socket.WasEverUsed());
TestCompletionCallback accept_callback;
std::unique_ptr<StreamSocket> accepted_socket;
int result = server.Accept(&accepted_socket, accept_callback.callback());
ASSERT_THAT(accept_callback.GetResult(result), IsOk());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_FALSE(socket.WasEverUsed());
EXPECT_TRUE(socket.IsConnected());
// Writing some data to the socket _should_ set WasEverUsed.
const char kRequest[] = "GET / HTTP/1.0";
auto write_buffer = base::MakeRefCounted<StringIOBuffer>(kRequest);
TestCompletionCallback write_callback;
socket.Write(write_buffer.get(), write_buffer->size(),
write_callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS);
EXPECT_TRUE(socket.WasEverUsed());
socket.Disconnect();
EXPECT_FALSE(socket.IsConnected());
EXPECT_TRUE(socket.WasEverUsed());
// Re-use the socket, which should set WasEverUsed to false.
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
TestCompletionCallback connect_callback2;
connect_result = socket.Connect(connect_callback2.callback());
EXPECT_FALSE(socket.WasEverUsed());
}
// Tests that DNS aliases can be stored in a socket for reuse.
TEST_F(TCPClientSocketTest, DnsAliasesPersistForReuse) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(lo_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
// Create a socket.
TCPClientSocket socket(AddressList(server_address), nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_FALSE(socket.WasEverUsed());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
// The socket's DNS aliases are unset.
EXPECT_TRUE(socket.GetDnsAliases().empty());
// Set the aliases.
std::vector<std::string> dns_aliases({"alias1", "alias2", "host"});
socket.SetDnsAliases(dns_aliases);
// Verify that the aliases are set.
EXPECT_THAT(socket.GetDnsAliases(),
testing::ElementsAre("alias1", "alias2", "host"));
// Connect the socket.
TestCompletionCallback connect_callback;
int connect_result = socket.Connect(connect_callback.callback());
EXPECT_FALSE(socket.WasEverUsed());
TestCompletionCallback accept_callback;
std::unique_ptr<StreamSocket> accepted_socket;
int result = server.Accept(&accepted_socket, accept_callback.callback());
ASSERT_THAT(accept_callback.GetResult(result), IsOk());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_FALSE(socket.WasEverUsed());
EXPECT_TRUE(socket.IsConnected());
// Write some data to the socket to set WasEverUsed, so that the
// socket can be re-used.
const char kRequest[] = "GET / HTTP/1.0";
auto write_buffer = base::MakeRefCounted<StringIOBuffer>(kRequest);
TestCompletionCallback write_callback;
socket.Write(write_buffer.get(), write_buffer->size(),
write_callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS);
EXPECT_TRUE(socket.WasEverUsed());
socket.Disconnect();
EXPECT_FALSE(socket.IsConnected());
EXPECT_TRUE(socket.WasEverUsed());
// Re-use the socket, and verify that the aliases are still set.
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
TestCompletionCallback connect_callback2;
connect_result = socket.Connect(connect_callback2.callback());
EXPECT_FALSE(socket.WasEverUsed());
EXPECT_THAT(socket.GetDnsAliases(),
testing::ElementsAre("alias1", "alias2", "host"));
}
class TestSocketPerformanceWatcher : public SocketPerformanceWatcher {
public:
TestSocketPerformanceWatcher() : connection_changed_count_(0u) {}
TestSocketPerformanceWatcher(const TestSocketPerformanceWatcher&) = delete;
TestSocketPerformanceWatcher& operator=(const TestSocketPerformanceWatcher&) =
delete;
~TestSocketPerformanceWatcher() override = default;
bool ShouldNotifyUpdatedRTT() const override { return true; }
void OnUpdatedRTTAvailable(const base::TimeDelta& rtt) override {}
void OnConnectionChanged() override { connection_changed_count_++; }
size_t connection_changed_count() const { return connection_changed_count_; }
private:
size_t connection_changed_count_;
};
// TestSocketPerformanceWatcher requires kernel support for tcp_info struct, and
// so it is enabled only on certain platforms.
#if defined(TCP_INFO) || defined(OS_LINUX) || defined(OS_CHROMEOS)
#define MAYBE_TestSocketPerformanceWatcher TestSocketPerformanceWatcher
#else
#define MAYBE_TestSocketPerformanceWatcher TestSocketPerformanceWatcher
#endif
// Tests if the socket performance watcher is notified if the same socket is
// used for a different connection.
TEST_F(TCPClientSocketTest, MAYBE_TestSocketPerformanceWatcher) {
const size_t kNumIPs = 2;
IPAddressList ip_list;
for (size_t i = 0; i < kNumIPs; ++i)
ip_list.push_back(IPAddress(72, 14, 213, i));
std::unique_ptr<TestSocketPerformanceWatcher> watcher(
new TestSocketPerformanceWatcher());
TestSocketPerformanceWatcher* watcher_ptr = watcher.get();
std::vector<std::string> aliases({"example.com"});
TCPClientSocket socket(
AddressList::CreateFromIPAddressList(ip_list, std::move(aliases)),
std::move(watcher), nullptr, nullptr, NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(IPAddress::IPv4Localhost(), 0)), IsOk());
TestCompletionCallback connect_callback;
ASSERT_NE(OK, connect_callback.GetResult(
socket.Connect(connect_callback.callback())));
EXPECT_EQ(kNumIPs - 1, watcher_ptr->connection_changed_count());
}
// On Android, where socket tagging is supported, verify that
// TCPClientSocket::Tag works as expected.
#if defined(OS_ANDROID)
TEST_F(TCPClientSocketTest, Tag) {
if (!CanGetTaggedBytes()) {
DVLOG(0) << "Skipping test - GetTaggedBytes unsupported.";
return;
}
// Start test server.
EmbeddedTestServer test_server;
test_server.AddDefaultHandlers(base::FilePath());
ASSERT_TRUE(test_server.Start());
AddressList addr_list;
ASSERT_TRUE(test_server.GetAddressList(&addr_list));
TCPClientSocket s(addr_list, nullptr, nullptr, nullptr, NetLogSource());
// Verify TCP connect packets are tagged and counted properly.
int32_t tag_val1 = 0x12345678;
uint64_t old_traffic = GetTaggedBytes(tag_val1);
SocketTag tag1(SocketTag::UNSET_UID, tag_val1);
s.ApplySocketTag(tag1);
TestCompletionCallback connect_callback;
int connect_result = s.Connect(connect_callback.callback());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_GT(GetTaggedBytes(tag_val1), old_traffic);
// Verify socket can be retagged with a new value and the current process's
// UID.
int32_t tag_val2 = 0x87654321;
old_traffic = GetTaggedBytes(tag_val2);
SocketTag tag2(getuid(), tag_val2);
s.ApplySocketTag(tag2);
const char kRequest1[] = "GET / HTTP/1.0";
scoped_refptr<IOBuffer> write_buffer1 =
base::MakeRefCounted<StringIOBuffer>(kRequest1);
TestCompletionCallback write_callback1;
EXPECT_EQ(s.Write(write_buffer1.get(), strlen(kRequest1),
write_callback1.callback(), TRAFFIC_ANNOTATION_FOR_TESTS),
static_cast<int>(strlen(kRequest1)));
EXPECT_GT(GetTaggedBytes(tag_val2), old_traffic);
// Verify socket can be retagged with a new value and the current process's
// UID.
old_traffic = GetTaggedBytes(tag_val1);
s.ApplySocketTag(tag1);
const char kRequest2[] = "\n\n";
scoped_refptr<IOBufferWithSize> write_buffer2 =
base::MakeRefCounted<IOBufferWithSize>(strlen(kRequest2));
memmove(write_buffer2->data(), kRequest2, strlen(kRequest2));
TestCompletionCallback write_callback2;
EXPECT_EQ(s.Write(write_buffer2.get(), strlen(kRequest2),
write_callback2.callback(), TRAFFIC_ANNOTATION_FOR_TESTS),
static_cast<int>(strlen(kRequest2)));
EXPECT_GT(GetTaggedBytes(tag_val1), old_traffic);
s.Disconnect();
}
TEST_F(TCPClientSocketTest, TagAfterConnect) {
if (!CanGetTaggedBytes()) {
DVLOG(0) << "Skipping test - GetTaggedBytes unsupported.";
return;
}
// Start test server.
EmbeddedTestServer test_server;
test_server.AddDefaultHandlers(base::FilePath());
ASSERT_TRUE(test_server.Start());
AddressList addr_list;
ASSERT_TRUE(test_server.GetAddressList(&addr_list));
TCPClientSocket s(addr_list, nullptr, nullptr, nullptr, NetLogSource());
// Connect socket.
TestCompletionCallback connect_callback;
int connect_result = s.Connect(connect_callback.callback());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
// Verify socket can be tagged with a new value and the current process's
// UID.
int32_t tag_val2 = 0x87654321;
uint64_t old_traffic = GetTaggedBytes(tag_val2);
SocketTag tag2(getuid(), tag_val2);
s.ApplySocketTag(tag2);
const char kRequest1[] = "GET / HTTP/1.0";
scoped_refptr<IOBuffer> write_buffer1 =
base::MakeRefCounted<StringIOBuffer>(kRequest1);
TestCompletionCallback write_callback1;
EXPECT_EQ(s.Write(write_buffer1.get(), strlen(kRequest1),
write_callback1.callback(), TRAFFIC_ANNOTATION_FOR_TESTS),
static_cast<int>(strlen(kRequest1)));
EXPECT_GT(GetTaggedBytes(tag_val2), old_traffic);
// Verify socket can be retagged with a new value and the current process's
// UID.
int32_t tag_val1 = 0x12345678;
old_traffic = GetTaggedBytes(tag_val1);
SocketTag tag1(SocketTag::UNSET_UID, tag_val1);
s.ApplySocketTag(tag1);
const char kRequest2[] = "\n\n";
scoped_refptr<IOBuffer> write_buffer2 =
base::MakeRefCounted<StringIOBuffer>(kRequest2);
TestCompletionCallback write_callback2;
EXPECT_EQ(s.Write(write_buffer2.get(), strlen(kRequest2),
write_callback2.callback(), TRAFFIC_ANNOTATION_FOR_TESTS),
static_cast<int>(strlen(kRequest2)));
EXPECT_GT(GetTaggedBytes(tag_val1), old_traffic);
s.Disconnect();
}
#endif // defined(OS_ANDROID)
// TCP socket that hangs indefinitely when establishing a connection.
class NeverConnectingTCPClientSocket : public TCPClientSocket {
public:
NeverConnectingTCPClientSocket(
const AddressList& addresses,
std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,
NetworkQualityEstimator* network_quality_estimator,
net::NetLog* net_log,
const net::NetLogSource& source)
: TCPClientSocket(addresses,
std::move(socket_performance_watcher),
network_quality_estimator,
net_log,
source) {}
// Returns the number of times that ConnectInternal() was called.
int connect_internal_counter() const { return connect_internal_counter_; }
private:
int ConnectInternal(const IPEndPoint& endpoint) override {
connect_internal_counter_++;
return ERR_IO_PENDING;
}
int connect_internal_counter_ = 0;
};
// Tests for closing sockets on suspend mode.
#if defined(TCP_CLIENT_SOCKET_OBSERVES_SUSPEND)
// Entering suspend mode shouldn't affect sockets that haven't connected yet, or
// listening server sockets.
TEST_F(TCPClientSocketTest, SuspendBeforeConnect) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(lo_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
TCPClientSocket socket(AddressList(server_address), nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
IPEndPoint local_address_result;
EXPECT_THAT(socket.GetLocalAddress(&local_address_result), IsOk());
EXPECT_EQ(lo_address, local_address_result.address());
TestCompletionCallback accept_callback;
std::unique_ptr<StreamSocket> accepted_socket;
ASSERT_THAT(server.Accept(&accepted_socket, accept_callback.callback()),
IsError(ERR_IO_PENDING));
Suspend();
// Power notifications happen asynchronously, so have to wait for the socket
// to be notified of the suspend event.
base::RunLoop().RunUntilIdle();
TestCompletionCallback connect_callback;
int connect_result = socket.Connect(connect_callback.callback());
ASSERT_THAT(accept_callback.WaitForResult(), IsOk());
ASSERT_THAT(connect_callback.GetResult(connect_result), IsOk());
EXPECT_TRUE(socket.IsConnected());
EXPECT_TRUE(accepted_socket->IsConnected());
}
TEST_F(TCPClientSocketTest, SuspendDuringConnect) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(lo_address, 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
nullptr, nullptr, NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
IPEndPoint local_address_result;
EXPECT_THAT(socket.GetLocalAddress(&local_address_result), IsOk());
EXPECT_EQ(lo_address, local_address_result.address());
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
Suspend();
EXPECT_THAT(connect_callback.WaitForResult(),
IsError(ERR_NETWORK_IO_SUSPENDED));
}
TEST_F(TCPClientSocketTest, SuspendDuringConnectMultipleAddresses) {
IPAddress lo_address = IPAddress::IPv4Localhost();
TCPServerSocket server(nullptr, NetLogSource());
ASSERT_THAT(server.Listen(IPEndPoint(IPAddress(0, 0, 0, 0), 0), 1), IsOk());
IPEndPoint server_address;
ASSERT_THAT(server.GetLocalAddress(&server_address), IsOk());
AddressList address_list;
address_list.push_back(
IPEndPoint(IPAddress(127, 0, 0, 1), server_address.port()));
address_list.push_back(
IPEndPoint(IPAddress(127, 0, 0, 2), server_address.port()));
NeverConnectingTCPClientSocket socket(address_list, nullptr, nullptr, nullptr,
NetLogSource());
EXPECT_THAT(socket.Bind(IPEndPoint(lo_address, 0)), IsOk());
IPEndPoint local_address_result;
EXPECT_THAT(socket.GetLocalAddress(&local_address_result), IsOk());
EXPECT_EQ(lo_address, local_address_result.address());
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
Suspend();
EXPECT_THAT(connect_callback.WaitForResult(),
IsError(ERR_NETWORK_IO_SUSPENDED));
}
TEST_F(TCPClientSocketTest, SuspendWhileIdle) {
std::unique_ptr<StreamSocket> accepted_socket;
std::unique_ptr<TCPClientSocket> client_socket;
std::unique_ptr<ServerSocket> server_socket;
CreateConnectedSockets(&accepted_socket, &client_socket, &server_socket);
Suspend();
// Power notifications happen asynchronously.
base::RunLoop().RunUntilIdle();
scoped_refptr<IOBuffer> buffer = base::MakeRefCounted<IOBuffer>(1);
buffer->data()[0] = '1';
TestCompletionCallback callback;
// Check that the client socket is disconnected, and actions fail with
// ERR_NETWORK_IO_SUSPENDED.
EXPECT_FALSE(client_socket->IsConnected());
EXPECT_THAT(client_socket->Read(buffer.get(), 1, callback.callback()),
IsError(ERR_NETWORK_IO_SUSPENDED));
EXPECT_THAT(client_socket->Write(buffer.get(), 1, callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS),
IsError(ERR_NETWORK_IO_SUSPENDED));
// Check that the accepted socket is disconnected, and actions fail with
// ERR_NETWORK_IO_SUSPENDED.
EXPECT_FALSE(accepted_socket->IsConnected());
EXPECT_THAT(accepted_socket->Read(buffer.get(), 1, callback.callback()),
IsError(ERR_NETWORK_IO_SUSPENDED));
EXPECT_THAT(accepted_socket->Write(buffer.get(), 1, callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS),
IsError(ERR_NETWORK_IO_SUSPENDED));
// Reconnecting the socket should work.
TestCompletionCallback connect_callback;
int connect_result = client_socket->Connect(connect_callback.callback());
accepted_socket.reset();
TestCompletionCallback accept_callback;
int accept_result =
server_socket->Accept(&accepted_socket, accept_callback.callback());
ASSERT_THAT(accept_callback.GetResult(accept_result), IsOk());
EXPECT_THAT(connect_callback.GetResult(connect_result), IsOk());
}
TEST_F(TCPClientSocketTest, SuspendDuringRead) {
std::unique_ptr<StreamSocket> accepted_socket;
std::unique_ptr<TCPClientSocket> client_socket;
CreateConnectedSockets(&accepted_socket, &client_socket);
// Start a read. This shouldn't complete, since the other end of the pipe
// writes no data.
scoped_refptr<IOBuffer> read_buffer = base::MakeRefCounted<IOBuffer>(1);
read_buffer->data()[0] = '1';
TestCompletionCallback callback;
ASSERT_THAT(client_socket->Read(read_buffer.get(), 1, callback.callback()),
IsError(ERR_IO_PENDING));
// Simulate a suspend event. Can't use a real power event, as it would affect
// |accepted_socket| as well.
client_socket->OnSuspend();
EXPECT_THAT(callback.WaitForResult(), IsError(ERR_NETWORK_IO_SUSPENDED));
// Check that the client socket really is disconnected.
EXPECT_FALSE(client_socket->IsConnected());
EXPECT_THAT(client_socket->Read(read_buffer.get(), 1, callback.callback()),
IsError(ERR_NETWORK_IO_SUSPENDED));
EXPECT_THAT(client_socket->Write(read_buffer.get(), 1, callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS),
IsError(ERR_NETWORK_IO_SUSPENDED));
}
TEST_F(TCPClientSocketTest, SuspendDuringWrite) {
std::unique_ptr<StreamSocket> accepted_socket;
std::unique_ptr<TCPClientSocket> client_socket;
CreateConnectedSockets(&accepted_socket, &client_socket);
// Write to the socket until a write doesn't complete synchronously.
const int kBufferSize = 4096;
scoped_refptr<IOBuffer> write_buffer =
base::MakeRefCounted<IOBuffer>(kBufferSize);
memset(write_buffer->data(), '1', kBufferSize);
TestCompletionCallback callback;
while (true) {
int rv =
client_socket->Write(write_buffer.get(), kBufferSize,
callback.callback(), TRAFFIC_ANNOTATION_FOR_TESTS);
if (rv == ERR_IO_PENDING)
break;
ASSERT_GT(rv, 0);
}
// Simulate a suspend event. Can't use a real power event, as it would affect
// |accepted_socket| as well.
client_socket->OnSuspend();
EXPECT_THAT(callback.WaitForResult(), IsError(ERR_NETWORK_IO_SUSPENDED));
// Check that the client socket really is disconnected.
EXPECT_FALSE(client_socket->IsConnected());
EXPECT_THAT(client_socket->Read(write_buffer.get(), 1, callback.callback()),
IsError(ERR_NETWORK_IO_SUSPENDED));
EXPECT_THAT(client_socket->Write(write_buffer.get(), 1, callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS),
IsError(ERR_NETWORK_IO_SUSPENDED));
}
TEST_F(TCPClientSocketTest, SuspendDuringReadAndWrite) {
enum class ReadCallbackAction {
kNone,
kDestroySocket,
kDisconnectSocket,
kReconnectSocket,
};
for (ReadCallbackAction read_callback_action : {
ReadCallbackAction::kNone,
ReadCallbackAction::kDestroySocket,
ReadCallbackAction::kDisconnectSocket,
ReadCallbackAction::kReconnectSocket,
}) {
std::unique_ptr<StreamSocket> accepted_socket;
std::unique_ptr<TCPClientSocket> client_socket;
std::unique_ptr<ServerSocket> server_socket;
CreateConnectedSockets(&accepted_socket, &client_socket, &server_socket);
// Start a read. This shouldn't complete, since the other end of the pipe
// writes no data.
scoped_refptr<IOBuffer> read_buffer = base::MakeRefCounted<IOBuffer>(1);
read_buffer->data()[0] = '1';
TestCompletionCallback read_callback;
// Used int the ReadCallbackAction::kReconnectSocket case, since can't run a
// nested message loop in the read callback.
TestCompletionCallback nested_connect_callback;
int nested_connect_result;
CompletionOnceCallback read_completion_once_callback =
base::BindLambdaForTesting([&](int result) {
EXPECT_FALSE(client_socket->IsConnected());
switch (read_callback_action) {
case ReadCallbackAction::kNone:
break;
case ReadCallbackAction::kDestroySocket:
client_socket.reset();
break;
case ReadCallbackAction::kDisconnectSocket:
client_socket->Disconnect();
break;
case ReadCallbackAction::kReconnectSocket: {
TestCompletionCallback connect_callback;
nested_connect_result =
client_socket->Connect(nested_connect_callback.callback());
break;
}
}
read_callback.callback().Run(result);
});
ASSERT_THAT(client_socket->Read(read_buffer.get(), 1,
std::move(read_completion_once_callback)),
IsError(ERR_IO_PENDING));
// Write to the socket until a write doesn't complete synchronously.
const int kBufferSize = 4096;
scoped_refptr<IOBuffer> write_buffer =
base::MakeRefCounted<IOBuffer>(kBufferSize);
memset(write_buffer->data(), '1', kBufferSize);
TestCompletionCallback write_callback;
while (true) {
int rv = client_socket->Write(write_buffer.get(), kBufferSize,
write_callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS);
if (rv == ERR_IO_PENDING)
break;
ASSERT_GT(rv, 0);
}
// Simulate a suspend event. Can't use a real power event, as it would
// affect |accepted_socket| as well.
client_socket->OnSuspend();
EXPECT_THAT(read_callback.WaitForResult(),
IsError(ERR_NETWORK_IO_SUSPENDED));
if (read_callback_action == ReadCallbackAction::kNone) {
EXPECT_THAT(write_callback.WaitForResult(),
IsError(ERR_NETWORK_IO_SUSPENDED));
// Check that the client socket really is disconnected.
EXPECT_FALSE(client_socket->IsConnected());
EXPECT_THAT(
client_socket->Read(read_buffer.get(), 1, read_callback.callback()),
IsError(ERR_NETWORK_IO_SUSPENDED));
EXPECT_THAT(
client_socket->Write(write_buffer.get(), 1, write_callback.callback(),
TRAFFIC_ANNOTATION_FOR_TESTS),
IsError(ERR_NETWORK_IO_SUSPENDED));
} else {
// Each of the actions taken in the read callback will cancel the pending
// write callback.
EXPECT_FALSE(write_callback.have_result());
}
if (read_callback_action == ReadCallbackAction::kReconnectSocket) {
// Finish establishing a connection, just to make sure the reconnect case
// completely works.
accepted_socket.reset();
TestCompletionCallback accept_callback;
int accept_result =
server_socket->Accept(&accepted_socket, accept_callback.callback());
ASSERT_THAT(accept_callback.GetResult(accept_result), IsOk());
EXPECT_THAT(nested_connect_callback.GetResult(nested_connect_result),
IsOk());
}
}
}
#endif // defined(TCP_CLIENT_SOCKET_OBSERVES_SUSPEND)
// Scoped helper to override the TCP connect attempt policy.
class OverrideTcpConnectAttemptTimeout {
public:
OverrideTcpConnectAttemptTimeout(double rtt_multipilier,
base::TimeDelta min_timeout,
base::TimeDelta max_timeout) {
base::FieldTrialParams params;
params[features::kTimeoutTcpConnectAttemptRTTMultiplier.name] =
base::NumberToString(rtt_multipilier);
params[features::kTimeoutTcpConnectAttemptMin.name] =
base::NumberToString(min_timeout.InMilliseconds()) + "ms";
params[features::kTimeoutTcpConnectAttemptMax.name] =
base::NumberToString(max_timeout.InMilliseconds()) + "ms";
scoped_feature_list_.InitAndEnableFeatureWithParameters(
features::kTimeoutTcpConnectAttempt, params);
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
// Test fixture that uses a MOCK_TIME test environment, so time can
// be advanced programmatically.
class TCPClientSocketMockTimeTest : public testing::Test {
public:
TCPClientSocketMockTimeTest()
: task_environment_(base::test::TaskEnvironment::MainThreadType::IO,
base::test::TaskEnvironment::TimeSource::MOCK_TIME) {}
protected:
base::test::TaskEnvironment task_environment_;
};
// Tests that no TCP connect timeout is enforced by default (i.e.
// when the feature is disabled).
TEST_F(TCPClientSocketMockTimeTest, NoConnectAttemptTimeoutByDefault) {
IPEndPoint server_address(IPAddress::IPv4Localhost(), 80);
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
nullptr, nullptr, NetLogSource());
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// After 4 minutes, the socket should still be connecting.
task_environment_.FastForwardBy(base::Minutes(4));
EXPECT_FALSE(connect_callback.have_result());
EXPECT_FALSE(socket.IsConnected());
// 1 attempt was made.
EXPECT_EQ(1, socket.connect_internal_counter());
}
// Tests that the maximum timeout is used when there is no estimated
// RTT.
TEST_F(TCPClientSocketMockTimeTest, ConnectAttemptTimeoutUsesMaxWhenNoRTT) {
OverrideTcpConnectAttemptTimeout override_timeout(1, base::Seconds(4),
base::Seconds(10));
IPEndPoint server_address(IPAddress::IPv4Localhost(), 80);
// Pass a null NetworkQualityEstimator, so the TCPClientSocket is unable to
// estimate the RTT.
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
nullptr, nullptr, NetLogSource());
// Start connecting.
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// Advance to t=3.1s
// Should still be pending, as this is before the minimum timeout.
task_environment_.FastForwardBy(base::Milliseconds(3100));
EXPECT_FALSE(connect_callback.have_result());
EXPECT_FALSE(socket.IsConnected());
// Advance to t=4.1s
// Should still be pending. This is after the minimum timeout, but before the
// maximum.
task_environment_.FastForwardBy(base::Seconds(1));
EXPECT_FALSE(connect_callback.have_result());
EXPECT_FALSE(socket.IsConnected());
// Advance to t=10.1s
// Should now be timed out, as this is after the maximum timeout.
task_environment_.FastForwardBy(base::Seconds(6));
rv = connect_callback.GetResult(rv);
ASSERT_THAT(rv, IsError(ERR_TIMED_OUT));
// 1 attempt was made.
EXPECT_EQ(1, socket.connect_internal_counter());
}
// Tests that the minimum timeout is used when the adaptive timeout using RTT
// ends up being too low.
TEST_F(TCPClientSocketMockTimeTest, ConnectAttemptTimeoutUsesMinWhenRTTLow) {
OverrideTcpConnectAttemptTimeout override_timeout(5, base::Seconds(4),
base::Seconds(10));
// Set the estimated RTT to 1 millisecond.
TestNetworkQualityEstimator network_quality_estimator;
network_quality_estimator.SetStartTimeNullTransportRtt(base::Milliseconds(1));
IPEndPoint server_address(IPAddress::IPv4Localhost(), 80);
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
&network_quality_estimator, nullptr,
NetLogSource());
// Start connecting.
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// Advance to t=1.1s
// Should be pending, since although the adaptive timeout has been reached, it
// is lower than the minimum timeout.
task_environment_.FastForwardBy(base::Milliseconds(1100));
EXPECT_FALSE(connect_callback.have_result());
EXPECT_FALSE(socket.IsConnected());
// Advance to t=4.1s
// Should have timed out due to hitting the minimum timeout.
task_environment_.FastForwardBy(base::Seconds(3));
rv = connect_callback.GetResult(rv);
ASSERT_THAT(rv, IsError(ERR_TIMED_OUT));
// 1 attempt was made.
EXPECT_EQ(1, socket.connect_internal_counter());
}
// Tests that the maximum timeout is used when the adaptive timeout from RTT is
// too high.
TEST_F(TCPClientSocketMockTimeTest, ConnectAttemptTimeoutUsesMinWhenRTTHigh) {
OverrideTcpConnectAttemptTimeout override_timeout(5, base::Seconds(4),
base::Seconds(10));
// Set the estimated RTT to 5 seconds.
TestNetworkQualityEstimator network_quality_estimator;
network_quality_estimator.SetStartTimeNullTransportRtt(base::Seconds(5));
IPEndPoint server_address(IPAddress::IPv4Localhost(), 80);
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
&network_quality_estimator, nullptr,
NetLogSource());
// Start connecting.
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// Advance to t=10.1s
// The socket should have timed out due to hitting the maximum timeout. Had
// the adaptive timeout been used, the socket would instead be timing out at
// t=25s.
task_environment_.FastForwardBy(base::Milliseconds(10100));
rv = connect_callback.GetResult(rv);
ASSERT_THAT(rv, IsError(ERR_TIMED_OUT));
// 1 attempt was made.
EXPECT_EQ(1, socket.connect_internal_counter());
}
// Tests that an adaptive timeout is used for TCP connection attempts based on
// the estimated RTT.
TEST_F(TCPClientSocketMockTimeTest, ConnectAttemptTimeoutUsesRTT) {
OverrideTcpConnectAttemptTimeout override_timeout(5, base::Seconds(4),
base::Seconds(10));
// Set the estimated RTT to 1 second. Since the multiplier is set to 5, the
// total adaptive timeout will be 5 seconds.
TestNetworkQualityEstimator network_quality_estimator;
network_quality_estimator.SetStartTimeNullTransportRtt(base::Seconds(1));
IPEndPoint server_address(IPAddress::IPv4Localhost(), 80);
NeverConnectingTCPClientSocket socket(AddressList(server_address), nullptr,
&network_quality_estimator, nullptr,
NetLogSource());
// Start connecting.
TestCompletionCallback connect_callback;
int rv = socket.Connect(connect_callback.callback());
ASSERT_THAT(rv, IsError(ERR_IO_PENDING));
// Advance to t=4.1s
// The socket should still be pending. Had the minimum timeout been enforced,
// it would instead have timed out now.
task_environment_.FastForwardBy(base::Milliseconds(4100));
EXPECT_FALSE(connect_callback.have_result());
EXPECT_FALSE(socket.IsConnected());
// Advance to t=5.1s
// The adaptive timeout was at t=5s, so it should now be timed out.