forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathREADME.chromium
28 lines (25 loc) · 1.08 KB
/
README.chromium
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
Name: Checkstyle is a development tool to help programmers write Java code that
adheres to a coding standard.
Short Name: checkstyle
URL: https://github.com/checkstyle/checkstyle
Version: 8.0
License: LGPL 2.1
License File: NOT_SHIPPED
Security Critical: no
Description:
Checkstyle is used to validate Java code style on Chromium PRESUBMIT step.
Local Modifications:
None
Update instructions (requires @google.com account):
- Download fat jar from https://sourceforge.net/projects/checkstyle/files/checkstyle/
- Modify tools/android/checkstyle/checkstyle.py and verify the new fat jar works
- Remove existing SHA1 file
- If gcloud auth tokens are not set up, run
$ download_from_google_storage --config
- Upload new fat jar to gcloud. In third_party/checkstyle, run
$ upload_to_google_storage.py -b chromium-android-tools/checkstyle {new_far_jar}
- Check in new SHA1 file
- Before submitting the change, verify presubmit works fine by:
1) modifying a Java file and including it in the patch
2) running the chromium_presubmit trybot in the CQ on the patch
3) reverting the Java file change