-
Notifications
You must be signed in to change notification settings - Fork 97
Comparing changes
Open a pull request
base repository: FairRootGroup/FairRoot
base: v18.6.7
head repository: FairRootGroup/FairRoot
compare: v18.6.8
- 16 commits
- 174 files changed
- 3 contributors
Commits on Mar 1, 2022
-
Add SetTreeName and SetFolderName setters
Reworked the setting of the tree and folder names. Added the possibility to set these names in the macro. These setters have to be called before calling run->Init().
Configuration menu - View commit details
-
Copy full SHA for 0130aa5 - Browse repository at this point
Copy the full SHA 0130aa5View commit details
Commits on Apr 8, 2022
-
build(FindROOT): Interpret a failed
root-config --has-*
as NOTFOUNDIn ROOT 6.26+ the vmc feature has been removed. The feature check we use returns a string which is implicitely converted to true by CMake. However, the return code tells us the expected value in this case. Co-authored-by: Christian Tacke <@ChristianTackeGSI>
Configuration menu - View commit details
-
Copy full SHA for b2a059c - Browse repository at this point
Copy the full SHA b2a059cView commit details
Commits on Apr 13, 2022
-
Use Lower Case FairLogger Severities
Upper case severities are deprecated in FairLogger 1.10. So switch all severities over to lower case.
Configuration menu - View commit details
-
Copy full SHA for dbd27ae - Browse repository at this point
Copy the full SHA dbd27aeView commit details -
Remove CheckCXX11Features Usage
FairRoot depends on a C++11 compiler. This is fully declared and enforced using CMake native tooling. CheckCXX11Features is not used at all any more. So remove all of its usage in CMakeLists.txt. Also remove it from the templates.
Configuration menu - View commit details
-
Copy full SHA for c95fddc - Browse repository at this point
Copy the full SHA c95fddcView commit details -
Remove CheckCXX11Features.cmake
We do not need it any longer. And we do not want to provide it to our users. So remove it completely.
Configuration menu - View commit details
-
Copy full SHA for ffde06e - Browse repository at this point
Copy the full SHA ffde06eView commit details -
feat(FairMQ): Introduce
FairRoot::FairMQ
wrapper targetWraps the `FairMQ::FairMQ` target to support the cleaned namespaced FairMQ API (FairRootGroup/FairMQ#423). Also ships transition headers * "FairMQ.h" and * "FairRunFairMQDevice.h". The latter provides a transition from the `<fairmq/runFairMQDevice.h>` to the `<fairmq/runDevice.h>` header which changed the signature and return value of the `getDevice` function (see FairRootGroup/FairMQ@978191f and FairRootGroup/FairMQ@a7dbead).
Configuration menu - View commit details
-
Copy full SHA for 8ffcf8f - Browse repository at this point
Copy the full SHA 8ffcf8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c51b8a1 - Browse repository at this point
Copy the full SHA c51b8a1View commit details -
feat(Logger): Do not use
FairMQLogger.h
any moreSince FairMQ v1.4.0 `FairMQLogger.h` was just a wrapper around `fairlogger/Logger.h` because all logging features have been factored out to FairLogger already. See https://github.com/FairRootGroup/FairMQ/blob/v1.4.0/fairmq/FairMQLogger.h
Configuration menu - View commit details
-
Copy full SHA for a4d8466 - Browse repository at this point
Copy the full SHA a4d8466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dd9d87 - Browse repository at this point
Copy the full SHA 7dd9d87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b26a9f - Browse repository at this point
Copy the full SHA 0b26a9fView commit details -
feat(BaseMQ): No longer use deprecated FairMQ serialization API
Deprecated in FairMQ v1.4.41 (FairRootGroup/FairMQ@8e6c50e)
Configuration menu - View commit details
-
Copy full SHA for 07a7e68 - Browse repository at this point
Copy the full SHA 07a7e68View commit details -
feat: Adopt new namespaced FairMQ APIs
* see FairRootGroup/FairMQ#423 * uses transition header `"FairMQ.h"` from `FairRoot::FairMQ` target * minor cleanup of includes and typos
Configuration menu - View commit details
-
Copy full SHA for a750a23 - Browse repository at this point
Copy the full SHA a750a23View commit details -
feat: Adopt new
<fairmq/runDevice.h>
headerUses transition header `"FairRunFairMQDevice.h"` from `FairRoot::FairMQ` target. See FairRootGroup/FairMQ@978191f
Configuration menu - View commit details
-
Copy full SHA for 3f0acb7 - Browse repository at this point
Copy the full SHA 3f0acb7View commit details -
Use override to Mark Overriden Methods
When willingly overriding a virtual method, it is good practice to mark the method with `override`. Most other places already do so.
Configuration menu - View commit details
-
Copy full SHA for 9231e8d - Browse repository at this point
Copy the full SHA 9231e8dView commit details -
Increase some Buffers and Switch to snprintf
Increase the buffers to be large enough for a 32bit integer. And switch to snprintf.
Configuration menu - View commit details
-
Copy full SHA for aace6f0 - Browse repository at this point
Copy the full SHA aace6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8074b - Browse repository at this point
Copy the full SHA ac8074bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v18.6.7...v18.6.8