Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FairRootGroup/FairRoot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v18.6.7
Choose a base ref
...
head repository: FairRootGroup/FairRoot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v18.6.8
Choose a head ref
  • 16 commits
  • 174 files changed
  • 3 contributors

Commits on Mar 1, 2022

  1. Add SetTreeName and SetFolderName setters

    Reworked the setting of the tree and folder names.
    Added the possibility to set these names in the macro.
    These setters have to be called before calling run->Init().
    karabowi committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    0130aa5 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. build(FindROOT): Interpret a failed root-config --has-* as NOTFOUND

    In ROOT 6.26+ the vmc feature has been removed. The feature check we use
    returns a string which is implicitely converted to true by CMake. However,
    the return code tells us the expected value in this case.
    
    Co-authored-by: Christian Tacke <@ChristianTackeGSI>
    dennisklein authored and ChristianTackeGSI committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b2a059c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Use Lower Case FairLogger Severities

    Upper case severities are deprecated in FairLogger 1.10.
    So switch all severities over to lower case.
    ChristianTackeGSI authored and dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    dbd27ae View commit details
    Browse the repository at this point in the history
  2. Remove CheckCXX11Features Usage

    FairRoot depends on a C++11 compiler.
    This is fully declared and enforced using CMake native
    tooling.
    
    CheckCXX11Features is not used at all any more.
    
    So remove all of its usage in CMakeLists.txt.
    Also remove it from the templates.
    ChristianTackeGSI authored and dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    c95fddc View commit details
    Browse the repository at this point in the history
  3. Remove CheckCXX11Features.cmake

    We do not need it any longer.
    And we do not want to provide it to our users.
    So remove it completely.
    ChristianTackeGSI authored and dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ffde06e View commit details
    Browse the repository at this point in the history
  4. feat(FairMQ): Introduce FairRoot::FairMQ wrapper target

    Wraps the `FairMQ::FairMQ` target to support the cleaned namespaced
    FairMQ API (FairRootGroup/FairMQ#423).
    
    Also ships transition headers
    * "FairMQ.h" and
    * "FairRunFairMQDevice.h".
    
    The latter provides a transition from the `<fairmq/runFairMQDevice.h>`
    to the `<fairmq/runDevice.h>` header which changed the signature and
    return value of the `getDevice` function (see
    FairRootGroup/FairMQ@978191f and
    FairRootGroup/FairMQ@a7dbead).
    dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    8ffcf8f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c51b8a1 View commit details
    Browse the repository at this point in the history
  6. feat(Logger): Do not use FairMQLogger.h any more

    Since FairMQ v1.4.0 `FairMQLogger.h` was just a wrapper around
    `fairlogger/Logger.h` because all logging features have been factored out to
    FairLogger already.
    See https://github.com/FairRootGroup/FairMQ/blob/v1.4.0/fairmq/FairMQLogger.h
    dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a4d8466 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7dd9d87 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0b26a9f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    07a7e68 View commit details
    Browse the repository at this point in the history
  10. feat: Adopt new namespaced FairMQ APIs

    * see FairRootGroup/FairMQ#423
    * uses transition header `"FairMQ.h"` from `FairRoot::FairMQ` target
    * minor cleanup of includes and typos
    dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a750a23 View commit details
    Browse the repository at this point in the history
  11. feat: Adopt new <fairmq/runDevice.h> header

    Uses transition header `"FairRunFairMQDevice.h"` from `FairRoot::FairMQ` target.
    
    See FairRootGroup/FairMQ@978191f
    dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    3f0acb7 View commit details
    Browse the repository at this point in the history
  12. Use override to Mark Overriden Methods

    When willingly overriding a virtual method, it is good
    practice to mark the method with `override`.
    Most other places already do so.
    ChristianTackeGSI authored and dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    9231e8d View commit details
    Browse the repository at this point in the history
  13. Increase some Buffers and Switch to snprintf

    Increase the buffers to be large enough for a 32bit
    integer. And switch to snprintf.
    ChristianTackeGSI authored and dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    aace6f0 View commit details
    Browse the repository at this point in the history
  14. Bump v18.6.8

    dennisklein committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ac8074b View commit details
    Browse the repository at this point in the history
Loading