Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage Type Convention Tags #4084

Open
muon-rw opened this issue Sep 11, 2024 · 1 comment
Open

Damage Type Convention Tags #4084

muon-rw opened this issue Sep 11, 2024 · 1 comment

Comments

@muon-rw
Copy link

muon-rw commented Sep 11, 2024

Neoforge (and previously Forge) have tag conventions for damage types not defined by vanilla which might be useful for mod compatibility.

The lack of a proper magic damage type tag is particularly problematic - many mods currently use #minecraft:witch_resistant_to, which is unintuitive and not consistently followed.

Neoforge tags:
https://github.com/neoforged/NeoForge/tree/1.21.x/src/generated/resources/data/neoforge/tags/damage_type

Ideally both platforms would unify these tags into #c:is_magic, #c:is_poison, etc.

@ZsoltMolnarrr
Copy link

ZsoltMolnarrr commented Sep 11, 2024

I support this, especially since the old the old Java damage type group (or whatever it was) IS_MAGIC is gone.

Would be very useful for damage type tag (filter) for my "Magic Protection" enchantment (added by my Spell Power Attributes mod).

The most functionally equivalent vanilla tag is witch_resistant_to, however it is hardly intuitive that should be used, nor does it seem sematnically correct to be referenced from every magic code related logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants