From 3c7206dc3fb27bbc51299fead3293b45616d0946 Mon Sep 17 00:00:00 2001
From: fsdavid <daviti1@mail.com>
Date: Tue, 2 Feb 2021 08:59:49 +0100
Subject: [PATCH 1/4] Fix connectivity dataset external link

---
 docs/releases/v2.3.3.md                       |  2 +-
 docs/releases/v2.3.4.md                       |  5 ++++
 mkdocs.yml                                    |  1 +
 .../connectivityBrowser.component.ts          | 23 +++++++++++--------
 .../connectivityBrowser.template.html         |  5 +++-
 5 files changed, 25 insertions(+), 11 deletions(-)
 create mode 100644 docs/releases/v2.3.4.md

diff --git a/docs/releases/v2.3.3.md b/docs/releases/v2.3.3.md
index ad662197a..daf21d1b8 100644
--- a/docs/releases/v2.3.3.md
+++ b/docs/releases/v2.3.3.md
@@ -1,4 +1,4 @@
-# v2.3.2
+# v2.3.3
 
 ## Bugfixes
 
diff --git a/docs/releases/v2.3.4.md b/docs/releases/v2.3.4.md
new file mode 100644
index 000000000..7874ad493
--- /dev/null
+++ b/docs/releases/v2.3.4.md
@@ -0,0 +1,5 @@
+# v2.3.4
+
+## Bugfixes
+
+- fix connectivity dataset external link
diff --git a/mkdocs.yml b/mkdocs.yml
index 7afc5fcad..f510448ed 100644
--- a/mkdocs.yml
+++ b/mkdocs.yml
@@ -40,6 +40,7 @@ pages:
     - Fetching datasets: 'advanced/datasets.md'
     - Display non-atlas volumes: 'advanced/otherVolumes.md'
   - Release notes:
+    - v2.3.4: 'releases/v2.3.4.md'
     - v2.3.3: 'releases/v2.3.3.md'
     - v2.3.2: 'releases/v2.3.2.md'
     - v2.3.1: 'releases/v2.3.1.md'
diff --git a/src/ui/connectivityBrowser/connectivityBrowser.component.ts b/src/ui/connectivityBrowser/connectivityBrowser.component.ts
index 32c9bac58..12d4fd22e 100644
--- a/src/ui/connectivityBrowser/connectivityBrowser.component.ts
+++ b/src/ui/connectivityBrowser/connectivityBrowser.component.ts
@@ -112,6 +112,8 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
     public datasetList: any[] = []
     public selectedDataset: any
     public selectedDatasetDescription: string = ''
+    public selectedDatasetKgId: string = ''
+    public selectedDatasetKgSchema: string = ''
     public connectedAreas = []
 
     private selectedParcellationFlatRegions$ = this.store$.pipe(
@@ -151,7 +153,8 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
         this.datasetList = res.filter(dl => dl['parcellation id'] === this.parcellationId)
         this.selectedDataset = this.datasetList[0].name
         this.selectedDatasetDescription = this.datasetList[0].description
-
+        this.selectedDatasetKgId = this.datasetList[0].kgId
+        this.selectedDatasetKgSchema = this.datasetList[0].kgschema
         this.changeDataset()
       })
     }
@@ -166,9 +169,9 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
           }
         })
       )
-        
-      /** 
-       * Listen to of clear view entries 
+
+      /**
+       * Listen to of clear view entries
        * can come from within the component (when connectivity is not available for the dataset)
        * --> do not collapse
        * or outside (user clicks x in chip)
@@ -186,7 +189,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
           }
         })
       )
-        
+
 
       this.subscriptions.push(this.overwrittenColorMap$.subscribe(ocm => {
         if (this.accordionIsExpanded && !ocm) {
@@ -278,7 +281,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
       this.restoreDefaultColormap()
       this.subscriptions.forEach(s => s.unsubscribe())
     }
-    
+
     clearViewer() {
       this.store$.dispatch(
         ngViewerActionClearView({
@@ -298,6 +301,8 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
       if (event) {
         this.selectedDataset = event.value
         this.selectedDatasetDescription = this.datasetList.find(d => d.name === this.selectedDataset).description
+        this.selectedDatasetKgId = this.datasetList.find(d => d.name === this.selectedDataset).kgId || null
+        this.selectedDatasetKgSchema = this.datasetList.find(d => d.name === this.selectedDataset).kgschema || null
       }
       if (this.datasetList.length && this.selectedDataset) {
         const selectedDatasetId = this.datasetList.find(d => d.name === this.selectedDataset).id
@@ -355,7 +360,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
 
       const existingMap: Map<string, Map<number, { red: number, green: number, blue: number }>> = (getWindow().interactiveViewer.viewerHandle.getLayersSegmentColourMap())
       const colorMap = new Map(existingMap)
-        
+
       this.allRegions.forEach(r => {
         if (r.ngId) {
           colorMap.get(r.ngId).set(r.labelIndex, {red: 255, green: 255, blue: 255})
@@ -365,7 +370,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
       this.connectedAreas.forEach(area => {
         const areaAsRegion = this.allRegions
           .filter(r => {
-              
+
             if (this.regionHemisphere) {
               let regionName = area.name
               let regionStatus = null
@@ -378,7 +383,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
               }
               return r.name === regionName && r.status === regionStatus
             }
-              
+
             return r.name === area.name
           })
           .map(r => r)
diff --git a/src/ui/connectivityBrowser/connectivityBrowser.template.html b/src/ui/connectivityBrowser/connectivityBrowser.template.html
index 3f69aa9c2..eafa8d10c 100644
--- a/src/ui/connectivityBrowser/connectivityBrowser.template.html
+++ b/src/ui/connectivityBrowser/connectivityBrowser.template.html
@@ -38,7 +38,10 @@
                     <button class="flex-grow-0 flex-shrink-0" mat-icon-button
                             iav-dataset-show-dataset-dialog
                             [iav-dataset-show-dataset-dialog-name]="selectedDataset"
-                            [iav-dataset-show-dataset-dialog-description]="selectedDatasetDescription">
+                            [iav-dataset-show-dataset-dialog-description]="selectedDatasetDescription"
+                            [iav-dataset-show-dataset-dialog-kgid]="selectedDatasetKgId? selectedDatasetKgId : null"
+                            [iav-dataset-show-dataset-dialog-kgschema]="selectedDatasetKgSchema? selectedDatasetKgSchema : null"
+                            >
                         <i class="fas fa-info"></i>
                     </button>
                     <button class="flex-grow-0 flex-shrink-0"

From aaa5a64223f214ae954560002a2cb8a260c4516d Mon Sep 17 00:00:00 2001
From: fsdavid <daviti1@mail.com>
Date: Tue, 2 Feb 2021 13:01:14 +0100
Subject: [PATCH 2/4] Add tests to prevent regression

---
 .../connectivityBrowser.component.spec.ts     | 91 +++++++++++++++++++
 .../connectivityBrowser.component.ts          | 11 ++-
 2 files changed, 97 insertions(+), 5 deletions(-)
 create mode 100644 src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts

diff --git a/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
new file mode 100644
index 000000000..0886c26fe
--- /dev/null
+++ b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
@@ -0,0 +1,91 @@
+import {ConnectivityBrowserComponent} from "src/ui/connectivityBrowser/connectivityBrowser.component";
+import {async, ComponentFixture, TestBed} from "@angular/core/testing";
+import {StoreModule} from "@ngrx/store";
+import {
+    ngViewerState,
+    pluginState,
+    uiState,
+    userConfigState,
+    viewerConfigState,
+    viewerState
+} from "src/services/stateStore.service";
+import {viewerStateHelperReducer, viewerStateMetaReducers} from "src/services/state/viewerState.store.helper";
+import {datasetPreviewMetaReducer} from "src/glue";
+import {HttpClientModule} from "@angular/common/http";
+import {CUSTOM_ELEMENTS_SCHEMA} from "@angular/core";
+import {DatabrowserModule} from "src/ui/databrowserModule";
+
+fdescribe('ConnectivityComponent', () => {
+
+    let component: ConnectivityBrowserComponent;
+    let fixture: ComponentFixture<ConnectivityBrowserComponent>;
+
+    let datasetList = [
+        {
+            id: 'id1',
+            name: 'n1',
+            description: 'd1',
+            kgId: 'kgId1',
+            kgschema: 'kgschema1'
+        }, {
+            id: 'id2',
+            name: 'n2',
+            description: 'd2',
+            kgId: 'kgId2',
+            kgschema: 'kgschema2'
+        }
+    ]
+
+    beforeEach(async (() => {
+        TestBed.configureTestingModule({
+            imports: [StoreModule.forRoot({
+                pluginState,
+                viewerConfigState,
+                ngViewerState,
+                viewerState,
+                viewerStateHelper: viewerStateHelperReducer,
+                uiState,
+                userConfigState,
+            }, {
+                metaReducers: [
+                    // debug,
+                    ...viewerStateMetaReducers,
+                    datasetPreviewMetaReducer,
+                ]
+            }),
+                HttpClientModule,
+                DatabrowserModule
+            ],
+            declarations: [ConnectivityBrowserComponent],
+            schemas: [
+                CUSTOM_ELEMENTS_SCHEMA,
+            ],
+        }).compileComponents()
+    }));
+
+    it('> component can be created', async () => {
+        fixture = TestBed.createComponent(ConnectivityBrowserComponent)
+        component = fixture.componentInstance
+        expect(component).toBeTruthy()
+    })
+
+    it('> change dataset changes description, kgId and kgschema', () => {
+        fixture = TestBed.createComponent(ConnectivityBrowserComponent)
+        component = fixture.componentInstance
+
+        component.datasetList = datasetList
+
+        component.changeDataset({value: 'n1'})
+
+        expect(component.selectedDatasetDescription).toEqual('d1')
+        expect(component.selectedDatasetKgId).toEqual('kgId1')
+        expect(component.selectedDatasetKgSchema).toEqual('kgschema1')
+
+        component.changeDataset({value: 'n2'})
+
+        expect(component.selectedDatasetDescription).toEqual('d2')
+        expect(component.selectedDatasetKgId).toEqual('kgId2')
+        expect(component.selectedDatasetKgSchema).toEqual('kgschema2')
+    })
+
+});
\ No newline at end of file
diff --git a/src/ui/connectivityBrowser/connectivityBrowser.component.ts b/src/ui/connectivityBrowser/connectivityBrowser.component.ts
index 12d4fd22e..5e1996b84 100644
--- a/src/ui/connectivityBrowser/connectivityBrowser.component.ts
+++ b/src/ui/connectivityBrowser/connectivityBrowser.component.ts
@@ -212,7 +212,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
           this.setColorMap$.pipe(
             distinctUntilChanged()
           ),
-          fromEvent(this.connectivityComponentElement.nativeElement, 'connectivityDataReceived').pipe(
+          fromEvent(this.connectivityComponentElement?.nativeElement, 'connectivityDataReceived').pipe(
             map((e: CustomEvent) => e.detail)
           )
         ).subscribe(([flag, connectedAreas]) => {
@@ -300,9 +300,10 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
     changeDataset(event = null) {
       if (event) {
         this.selectedDataset = event.value
-        this.selectedDatasetDescription = this.datasetList.find(d => d.name === this.selectedDataset).description
-        this.selectedDatasetKgId = this.datasetList.find(d => d.name === this.selectedDataset).kgId || null
-        this.selectedDatasetKgSchema = this.datasetList.find(d => d.name === this.selectedDataset).kgschema || null
+        const foundDataset = this.datasetList.find(d => d.name === this.selectedDataset)
+        this.selectedDatasetDescription = foundDataset?.description
+        this.selectedDatasetKgId = foundDataset?.kgId || null
+        this.selectedDatasetKgSchema = foundDataset?.kgschema || null
       }
       if (this.datasetList.length && this.selectedDataset) {
         const selectedDatasetId = this.datasetList.find(d => d.name === this.selectedDataset).id
@@ -405,7 +406,7 @@ export class ConnectivityBrowserComponent implements OnInit, AfterViewInit, OnDe
     }
 
     public exportFullConnectivity() {
-      this.fullConnectivityGridElement.nativeElement['downloadCSV']()
+      this.fullConnectivityGridElement?.nativeElement['downloadCSV']()
     }
 
 }

From bbfba59e5a4e29e42f97b0dec9d5d33acf50aa6a Mon Sep 17 00:00:00 2001
From: fsdavid <daviti1@mail.com>
Date: Tue, 2 Feb 2021 13:02:31 +0100
Subject: [PATCH 3/4] fix unit connectivity unit test

---
 .../connectivityBrowser/connectivityBrowser.component.spec.ts   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
index 0886c26fe..b42c271ae 100644
--- a/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
+++ b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
@@ -15,7 +15,7 @@ import {HttpClientModule} from "@angular/common/http";
 import {CUSTOM_ELEMENTS_SCHEMA} from "@angular/core";
 import {DatabrowserModule} from "src/ui/databrowserModule";
 
-fdescribe('ConnectivityComponent', () => {
+describe('ConnectivityComponent', () => {
 
     let component: ConnectivityBrowserComponent;
     let fixture: ComponentFixture<ConnectivityBrowserComponent>;

From 44cb02380236c3ed242faecb8782f50241bcd143 Mon Sep 17 00:00:00 2001
From: fsdavid <daviti1@mail.com>
Date: Tue, 2 Feb 2021 14:37:04 +0100
Subject: [PATCH 4/4] update connectivity unit tests

---
 .../connectivityBrowser.component.spec.ts     | 35 ++++++-------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
index b42c271ae..72aa760cb 100644
--- a/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
+++ b/src/ui/connectivityBrowser/connectivityBrowser.component.spec.ts
@@ -1,24 +1,21 @@
 import {ConnectivityBrowserComponent} from "src/ui/connectivityBrowser/connectivityBrowser.component";
 import {async, ComponentFixture, TestBed} from "@angular/core/testing";
-import {StoreModule} from "@ngrx/store";
+import {Action} from "@ngrx/store";
 import {
-    ngViewerState,
-    pluginState,
-    uiState,
-    userConfigState,
-    viewerConfigState,
-    viewerState
+    defaultRootState,
 } from "src/services/stateStore.service";
-import {viewerStateHelperReducer, viewerStateMetaReducers} from "src/services/state/viewerState.store.helper";
-import {datasetPreviewMetaReducer} from "src/glue";
 import {HttpClientModule} from "@angular/common/http";
 import {CUSTOM_ELEMENTS_SCHEMA} from "@angular/core";
 import {DatabrowserModule} from "src/ui/databrowserModule";
+import {provideMockActions} from "@ngrx/effects/testing";
+import {provideMockStore} from "@ngrx/store/testing";
+import {Observable, of} from "rxjs";
 
 describe('ConnectivityComponent', () => {
 
     let component: ConnectivityBrowserComponent;
     let fixture: ComponentFixture<ConnectivityBrowserComponent>;
+    const actions$: Observable<Action> = of({type: 'TEST'})
 
     let datasetList = [
         {
@@ -38,24 +35,14 @@ describe('ConnectivityComponent', () => {
 
     beforeEach(async (() => {
         TestBed.configureTestingModule({
-            imports: [StoreModule.forRoot({
-                pluginState,
-                viewerConfigState,
-                ngViewerState,
-                viewerState,
-                viewerStateHelper: viewerStateHelperReducer,
-                uiState,
-                userConfigState,
-            }, {
-                metaReducers: [
-                    // debug,
-                    ...viewerStateMetaReducers,
-                    datasetPreviewMetaReducer,
-                ]
-            }),
+            imports: [
                 HttpClientModule,
                 DatabrowserModule
             ],
+            providers: [
+                provideMockActions(() => actions$),
+                provideMockStore({ initialState: defaultRootState })
+            ],
             declarations: [ConnectivityBrowserComponent],
             schemas: [
                 CUSTOM_ELEMENTS_SCHEMA,