Error in "documentation.ipynb" - Section 6.4.2 Cooling

[thamer-eng]

Hello,

I was following the "documentation.ipynb" notebook, and everything was going smoothly until I reached Section 6.4.2 titled "Cooling" (under the "Validation" section). It seems the required output files were not created. I've gone through "hplib_database.py", and it appears that none of the functions are used to create the "database_cooling.csv" file which is used in functions related to cooling section.

Could someone assist in this? Or perhaps provide guidance in case I'm missing something?

Many thanks.

[k-rieck]

Hello, thanks for your comment!
Did you import the cooling data at some point as it is mentioned in the documentation under section "2. Database preparation".
With the command db.import_cooling_data() the database_cooling.csv should be generated in the output folder normally.

If that is not helping, please let us know and we will try to fix the problem.

[thamer-eng]

Thanks @k-rieck for the quick reply.

I don't recall seeing db.import_cooling_data() in hplib_database.py or its mention in Section "2. Database Preparation".

I will go through it once more later in the day, with also running the scripts in "2. Database Preparation", I'll let you know if the issue persists.

Many thanks

[thamer-eng]

Hi @k-rieck,

I tried running the script from the beginning, including the "Data Preparation" section. I encountered the following error when executing db.combine_raw_csv(foldername='csv'):
ParserError: Error tokenizing data. C error: Expected 8 fields in line 18, saw 14.

I'm uncertain whether this error is reproducible or if it's specific to my setup.

Moving on to the main issue, I think that the current version of the GitHub code does not contain thedb.import_cooling_data() function that you're referring to. It's possible that you might have an earlier version which includes this function in hplib_database.py.

Thanks again for your time and help in this issue.

[xihaui]

To the first point:
I fixed the issue for the validation for the cooling data and opend a merge request. We changed the way the validation was done but didnt fix it. Sorry for that.