-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for terminal like caret #1121
Comments
PRs are welcome for new features :-) |
@Jugen I suggested to use RichTextFX for terminalFX - javaterminal/TerminalFX#58 It seems to me, that this issue (caret support absence) can be the only problem. |
I had a quick look at terminalFX and I don't think it'll be able to use RichTextFX because it just uses JavaFX as a view wrapper for the Javascript hterm library. |
@Jugen Yes, you are right. I didn't expect that they use JavaScript. It seems that JS becomes more popular in Java project (for example https://github.com/nidi3/graphviz-java) but it is not what I like. Have you ever come across a JavaFX terminal with RichTextFX? It is what I need, and I don't want to do :) |
Sorry, haven't seen a JavaFX terminal :-( |
For anyone interested RichTextFX currently gets its caret shape from the JavaFX TextFlow control via the
This is invoked for each caret in ParagraphText RichTextFX/richtextfx/src/main/java/org/fxmisc/richtext/ParagraphText.java Lines 328 to 331 in 57f70b2
This the place where the caret's visible shape could be altered depending on any caret features added to CaretNode. Note that doing this may have side affects to how RichTextFX behaves as the main caret's bounds are used in other places. |
RichTextFX is also used for building terminal emulator applications. At the same time, currently it is not possible to style caret to look like in terminals. This problem was also discussed in #397 , but later the issue was closed without resolving.
I suggest to support the following caret features:
The text was updated successfully, but these errors were encountered: