Workflow: Rework and build for ROS2 Humble and Jazzy #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouter-heerwegh
force-pushed
the
dev/rework-workflow
branch
3 times, most recently
from
cf8d718
to
f4fb615
Compare
wouter-heerwegh
force-pushed
the
dev/rework-workflow
branch
from
f4fb615
to
8ac818a
Compare
|
Hello @wouter-heerwegh , sorry for the delayed reply. The changes look good to me so far and apart from the changes to gcc, I don't notice anything missing. |
pmo73
reviewed
Oct 29, 2024
|
@pmo73 Do you think it's worth keeping the gcc parts from your initial PR? |
|
No I don't think so, There were a lot of changes, which would reduce the warnings, but as far as I could check the ros2 packages, they should be able to be compile with GCC also. I mean, if you want to be absolutely sure, you could add another matrix entry and compile the packages with both compilers. |
|
Okay in that case I will just leave it as is, and I will close #359. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce ROS2 building for Humble and Jazzy.