tests: test_static_timing fixes #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
donaldsharp
reviewed
Oct 14, 2021
| network = ipaddress.ip_network(super_prefix) | ||
| return tuple(network.subnets(count_log2))[0:count] | ||
| return tuple(network.subnets(new_prefix=network.prefixlen + 14))[0:count] |
There was a problem hiding this comment.
Do we need to have some guards against prefixlen overflowing the 32 bit space? I don't know enough about what super_prefix is but if it is a pre-existing address + mask then we probably do need to guard right?
There was a problem hiding this comment.
in tech meeting the decision was to put a big ol text warning about ensuring that when we use this functionality that the network size will work with a blind + 14
There was a problem hiding this comment.
I pushed a proper fix instead of adding a comment.
On the first step, the test creates 10000 static routes. It passes 10000 to `get_ip_networks` and it generates 10000 /22 routes. On the fourth step, the test tries to remove 5000 previously created routes. It passes 5000 to `get_ip_networks` and here starts the problem. Instead of generating 5000 /22 routes, it generates 5000 /21 routes. And the whole step is a no-op, we constantly see the following logs: ``` % Refusing to remove a non-existent route ``` To consistently generate same routes, `get_ip_networks` must always use the same prefix length. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
When the CI system is heavily loaded, we might see the following failures: ``` test failed at "test_config_timing/test_static_timing": assert 20.083204 <= 19.487716 ``` Currently we allow each step to run 2 times slower than the initial measurement. Let's allow them to run 3 times slower. Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
idryzhov
force-pushed
the
config-timing-fixes
branch
from
f052f5f to
e57c66d
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 3: Incomplete(check logs for details)Topotests debian 10 amd64 part 8: Incomplete(check logs for details)IPv6 protocols on Ubuntu 18.04: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 2: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 6: Incomplete(check logs for details)Topotests debian 10 amd64 part 3: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 4: Incomplete(check logs for details)Addresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 3: Incomplete(check logs for details)Topotests debian 10 amd64 part 9: Incomplete(check logs for details)IPv4 protocols on Ubuntu 18.04: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 9: Incomplete(check logs for details)Topotests debian 10 amd64 part 4: Incomplete(check logs for details)Topotests debian 10 amd64 part 2: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 9: Incomplete(check logs for details)Addresssanitizer topotests part 9: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 2: Incomplete(check logs for details)Static analyzer (clang): Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 7: Incomplete(check logs for details)Topotests debian 10 amd64 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 6: Incomplete(check logs for details)IPv4 ldp protocol on Ubuntu 18.04: Incomplete(check logs for details)Topotests debian 10 amd64 part 1: Incomplete(check logs for details)Addresssanitizer topotests part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 1: Incomplete(check logs for details)Topotests debian 10 amd64 part 6: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 6: Incomplete(check logs for details)Addresssanitizer topotests part 3: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 5: Incomplete(check logs for details)Topotests debian 10 amd64 part 5: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 4: Incomplete(check logs for details)Topotests debian 10 amd64 part 7: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 3: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 2: Incomplete(check logs for details)Addresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 7: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 i386 part 0: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 1: Incomplete(check logs for details)Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 1: Failed (click for details)Topotests debian 10 amd64 part 1: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1048/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, check individual commits.