Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: build libyang2 along with FRR [8.0] #9515

Merged

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Aug 29, 2021

Alpine images have been broken for some time because libyang2 is not
available in Alpine. This patch updates our Dockerfile to build a
libyang2 APK and install it into the image to satisfy FRR's libyang2
dependency.

Unfortunately, libyang2 erroneously includes an internal header from
libc which musl does not provide. FRR's official Docker
images are based on Alpine, which only offers musl libc. Until libyang2
fixes this problem, the libyang2 source that is installed in this image
is a patched version that is compatible with musl libc and not an
official version.

Signed-off-by: Quentin Young qlyoung@nvidia.com

@qlyoung qlyoung requested a review from wesl-ee August 29, 2021 23:35
@qlyoung qlyoung changed the title docker: build libyang2 along with FRR docker: build libyang2 along with FRR [8.0] Aug 29, 2021
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 30, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9515 6b5f9d8
Date 08/29/2021
Start 19:40:22
Finish 20:06:43
Run-Time 26:21
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-29-19:40:22.txt
Log autoscript-2021-08-29-19:41:37.log.bz2
Memory 508 517 425

For details, please contact louberger

@qlyoung
Copy link
Member Author

qlyoung commented Aug 30, 2021

@polychaeta rereview

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 30, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21452/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@donaldsharp
Copy link
Member

LGTM

@qlyoung qlyoung force-pushed the fix-alpine-docker-images-stable80 branch from 6b5f9d8 to 11df7c0 Compare August 30, 2021 14:41
@qlyoung qlyoung force-pushed the fix-alpine-docker-images-stable80 branch 2 times, most recently from 7f9dd12 to 28e4787 Compare August 30, 2021 15:38
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 30, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9515 28e4787
Date 08/30/2021
Start 11:55:22
Finish 12:21:39
Run-Time 26:17
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-11:55:22.txt
Log autoscript-2021-08-30-11:56:29.log.bz2
Memory 516 515 426

For details, please contact louberger

Alpine images have been broken for some time because libyang2 is not
available in Alpine. This patch updates our Dockerfile to build a
libyang2 APK and install it into the image to satisfy FRR's libyang2
dependency.

Unfortunately, libyang2 erroneously includes an internal header from
glibc, making it dependent on glibc to build. FRR's official Docker
images are based on Alpine, which only offers musl libc. Until libyang2
fixes this problem, the libyang2 source that is installed in this image
is a patched version that is compatible with musl libc and not an
official version.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
Some basic functions are required by frrcommon.sh

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
The install statement was putting the daemons file at "/etc/frr" instead
of making a new directory "/etc/frr" and putting it inside there.

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung qlyoung force-pushed the fix-alpine-docker-images-stable80 branch from 28e4787 to c3341c0 Compare August 30, 2021 19:25
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 30, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21468/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests debian 10 amd64 part 3: Incomplete (check logs for details)
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-21468/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:

2021-08-30 15:33:06,877 ERROR: assert failed at "test_bgp_features/test_bgp_shutdown_message": BGP shutdown message not received on router R2
assert '' != ''
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/08/30 15:45:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:43 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:44 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/08/30 15:45:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:46 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:45:58 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/08/30 15:47:21 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:21 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/08/30 15:47:22 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:23 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:23 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:23 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:30 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:30 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:47:36 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/08/30 15:49:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:09 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/08/30 15:49:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:09 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/08/30 15:49:10 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:10 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/08/30 15:49:10 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:10 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/08/30 15:49:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:24 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/08/30 15:49:40 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/08/30 15:49:40 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:40 BGP: [M7Q4P-46WDR] vty[??]@# do show logging
2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@# do write terminal

2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/08/30 15:49:41 BGP: [M7Q4P-46WDR] vty[??]@(config)# no log commands

2021/08/30 15:49:41 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/08/30 15:49:41 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/08/30 15:49:43 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/08/30 15:49:46 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/08/30 15:49:46 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/08/30 15:50:17 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/08/30 15:50:20 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/08/30 15:50:20 BGP: [HTQD2-0R1WR][EC 33554451] bgp_process_packet: BGP OPEN receipt failed for peer: 192.168.0.2
2021/08/30 15:50:22 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/08/30 15:51:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:51:49 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/08/30 15:52:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:47 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:48 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/08/30 15:52:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:52:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:53:02 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/08/30 15:53:02 BGP: [M7Q4P-46WDR] vty[??]@# do write memory

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21468/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 6
  • Ubuntu 16.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 2
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 9
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 1

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 30, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21469/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-21469/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1:

2021-08-30 15:32:04,085 ERROR: 'router_json_cmp' failed after 139.25 seconds
2021-08-30 15:32:04,088 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-08-30 15:32:25,051 ERROR: r2: bgpd left a dead pidfile (pid=21107)
2021-08-30 16:00:08,738 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-08-30 16:00:09,108 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21469/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 3
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 i386 part 4
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 9
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 amd64 part 5
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests debian 10 amd64 part 7
  • IPv4 protocols on Ubuntu 18.04

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 30, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9515 c3341c0
Date 08/30/2021
Start 15:25:23
Finish 15:51:36
Run-Time 26:13
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-08-30-15:25:23.txt
Log autoscript-2021-08-30-15:26:34.log.bz2
Memory 516 491 425

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 30, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21472/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21479/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link
Contributor

@wesl-ee wesl-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@qlyoung qlyoung requested a review from choppsv1 August 31, 2021 15:49
@eqvinox eqvinox merged commit 0ea609d into FRRouting:stable/8.0 Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants