Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: Displaying GR helper enabled router-id list in 'show ip ospf g… #9317

Closed
wants to merge 1 commit into from

Conversation

rgirada
Copy link
Contributor

@rgirada rgirada commented Aug 6, 2021

…r helper json'

Description:
GR helper enabled router-ids info is missing from json output of
"show ip ospf gr helper json" command.
Added the relevant json keys to add this info as part of this change.

Signed-off-by: Rajesh Girada rgirada@vmware.com

@polychaeta polychaeta added the ospf label Aug 6, 2021
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop
Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/b62721966937b325f6c843e16e681306/raw/3bc6fccc1575860b5f4ee9b6e1320f8c52c1687b/cr_9317_1628271917.diff | git apply

diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 46dc174348..9e6f2f886e 100644
--- a/ospfd/ospf_vty.c
+++ b/ospfd/ospf_vty.c
@@ -10132,7 +10132,7 @@ static int ospf_print_vty_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
 }
 
 static int ospf_print_json_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
-		void *arg)
+						 void *arg)
 {
 	struct advRtr *rtr = bucket->data;
 	struct json_object *json_rid_array = (struct json_object *)arg;
@@ -10141,7 +10141,7 @@ static int ospf_print_json_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
 	json_rid = json_object_new_object();
 
 	json_object_string_add(json_rid, "routerId",
-			inet_ntoa(rtr->advRtrAddr));
+			       inet_ntoa(rtr->advRtrAddr));
 	json_object_array_add(json_rid_array, json_rid);
 
 	return HASHWALK_CONTINUE;
@@ -10271,11 +10271,11 @@ static int ospf_show_gr_helper_details(struct vty *vty, struct ospf *ospf,
 				json_object_new_array();
 
 			json_object_object_add(json_vrf, "enabledRouterIds",
-					json_rid_array);
+					       json_rid_array);
 
 			hash_walk(ospf->enable_rtr_list,
-					ospf_print_json_helper_dis_rtr_walkcb,
-					json_rid_array);
+				  ospf_print_json_helper_dis_rtr_walkcb,
+				  json_rid_array);
 		}
 	}
 

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 6, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 c9f6696
Date 08/06/2021
Start 14:21:44
Finish 14:47:21
Run-Time 25:37
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-08-06-14:21:44.txt
Log autoscript-2021-08-06-14:22:58.log.bz2
Memory 515 489 400

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 6, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20845/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop
Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/3dd438540a9ef7a2e5c60e631a4294bf/raw/3bc6fccc1575860b5f4ee9b6e1320f8c52c1687b/cr_9317_1628589775.diff | git apply

diff --git a/ospfd/ospf_vty.c b/ospfd/ospf_vty.c
index 46dc174348..9e6f2f886e 100644
--- a/ospfd/ospf_vty.c
+++ b/ospfd/ospf_vty.c
@@ -10132,7 +10132,7 @@ static int ospf_print_vty_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
 }
 
 static int ospf_print_json_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
-		void *arg)
+						 void *arg)
 {
 	struct advRtr *rtr = bucket->data;
 	struct json_object *json_rid_array = (struct json_object *)arg;
@@ -10141,7 +10141,7 @@ static int ospf_print_json_helper_dis_rtr_walkcb(struct hash_bucket *bucket,
 	json_rid = json_object_new_object();
 
 	json_object_string_add(json_rid, "routerId",
-			inet_ntoa(rtr->advRtrAddr));
+			       inet_ntoa(rtr->advRtrAddr));
 	json_object_array_add(json_rid_array, json_rid);
 
 	return HASHWALK_CONTINUE;
@@ -10271,11 +10271,11 @@ static int ospf_show_gr_helper_details(struct vty *vty, struct ospf *ospf,
 				json_object_new_array();
 
 			json_object_object_add(json_vrf, "enabledRouterIds",
-					json_rid_array);
+					       json_rid_array);
 
 			hash_walk(ospf->enable_rtr_list,
-					ospf_print_json_helper_dis_rtr_walkcb,
-					json_rid_array);
+				  ospf_print_json_helper_dis_rtr_walkcb,
+				  json_rid_array);
 		}
 	}
 

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Aug 10, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20961/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 11, 2021

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, autoscript-2021-08-10-20:15:52.log.bz2 tests failed, has VALGRIND issues

_ _
Result SUCCESS git merge/9317 6dd9545
Date 08/10/2021
Start 20:14:35
Finish 20:40:22
Run-Time 25:47
Total 1813
Pass 1813
Fail 0
Details vncregress-2021-08-10-20:14:35.txt
Log autoscript-2021-08-10-20:15:52.log.bz2
Memory 498 484 426

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 13, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 6dd9545
Date 08/10/2021
Start 20:14:35
Finish 20:40:22
Run-Time 25:47
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-08-10-20:14:35.txt
Log autoscript-2021-08-10-20:15:52.log.bz2
Memory 498 484 426

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 14, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 6dd9545 6dd9545
Date 08/14/2021
Start 02:01:00
Finish 02:26:52
Run-Time 25:52
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-08-14-02:01:00.txt
Log autoscript-2021-08-14-02:02:16.log.bz2
Memory 497 516 423

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 14, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 6dd9545 6dd9545
Date 08/14/2021
Start 02:27:16
Finish 02:53:01
Run-Time 25:45
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-08-14-02:27:16.txt
Log autoscript-2021-08-14-02:28:31.log.bz2
Memory 516 512 426

For details, please contact louberger

ospfd/ospf_vty.c Outdated
struct json_object *json_rid_array =
json_object_new_array();

json_object_object_add(json_vrf, "enabledRouterIds",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: grEnabledRouterIds would be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the change.

@rgirada
Copy link
Contributor Author

rgirada commented Oct 18, 2021

ci: rerun

@rgirada
Copy link
Contributor Author

rgirada commented Oct 18, 2021

ci:rerun

@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 18, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 3b328c5
Date 10/18/2021
Start 08:16:06
Finish 08:42:16
Run-Time 26:10
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-10-18-08:16:06.txt
Log autoscript-2021-10-18-08:17:19.log.bz2
Memory 520 517 428

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 18, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-812/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 arm8 part 5
  • CentOS 7 rpm pkg check
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests debian 10 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 0
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 5
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 4
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 2
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 9

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 18, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-815/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: No useful log found
Topotests Ubuntu 18.04 i386 part 2: Failed (click for details) Topotests Ubuntu 18.04 i386 part 2: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-815/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:

r1: Daemon zebra not running

From frr r1 zebra log file:
b''
r2: Daemon zebra not running

From frr r2 zebra log file:
b''
P1: Daemon zebra not running

From frr P1 zebra log file:
b''
PE1: Daemon zebra not running

From frr PE1 zebra log file:
b''
PE2: Daemon zebra not running

From frr PE2 zebra log file:
b''
host1: Daemon zebra not running

From frr host1 zebra log file:
b''
host2: Daemon zebra not running

From frr host2 zebra log file:
b''
r1: Daemon zebra not running

From frr r1 zebra log file:
b''
r2: Daemon zebra not running

From frr r2 zebra log file:
b''
r3: Daemon zebra not running

From frr r3 zebra log file:
b''
r4: Daemon zebra not running

From frr r4 zebra log file:
b''
r5: Daemon zebra not running

From frr r5 zebra log file:
b''
r1: Daemon zebra not running

From frr r1 zebra log file:
b''

see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-815/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Fedora 29 rpm pkg check
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Static analyzer (clang)
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 1
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 9
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 0

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 18, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-814/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@rgirada rgirada force-pushed the gr_json_fix branch 2 times, most recently from 345ac13 to f67c4b6 Compare October 20, 2021 08:02
@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 20, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 345ac13
Date 10/20/2021
Start 03:41:00
Finish 04:07:22
Run-Time 26:22
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-10-20-03:41:00.txt
Log autoscript-2021-10-20-03:42:15.log.bz2
Memory 439 517 426

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 20, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9317 f67c4b6
Date 10/20/2021
Start 04:36:01
Finish 05:02:28
Run-Time 26:27
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-10-20-04:36:01.txt
Log autoscript-2021-10-20-04:37:23.log.bz2
Memory 491 513 426

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 20, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-863/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Static analyzer (clang)
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 0
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 4
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 4

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 20, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-864/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 8, 2022

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-2566/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@rgirada rgirada requested review from Spantik and polychaeta January 11, 2022 09:30
…r helper json'

Description:
	GR helper enabled router-ids info is missing from json output of
	"show ip ospf gr helper json" command.
	Added the relevant json keys to add this info as part of this change.

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5828/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@rgirada
Copy link
Contributor Author

rgirada commented Oct 20, 2022

This is already addressed in this following PR
#11848

@rgirada rgirada closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants