-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: triaging ospf failure using micronet branch #9288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:
************* Module bfd_ospf_topo1.test_bfd_ospf_topo1
my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:141:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.54/10
Pylint report for my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:
************* Module test_bgp_as_allow_in
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:256:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:401:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:449:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:603:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.23/10
Pylint report for my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:
************* Module bgp_basic_functionality_topo1.test_bgp_basic_functionality
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1140:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1157:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.72/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:
************* Module test_bgp_communities
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:344:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:350:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:396:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:400:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:583:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:587:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:633:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:637:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 7.75/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:
************* Module test_bgp_communities_topo2
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:295:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:314:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:333:43: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:379:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:405:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:416:35: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 6.79/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:
************* Module bgp_large_community.test_bgp_large_community_topo_1
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:90:4: E1205: Too many arguments for logging format string (logging-too-many-args)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:816:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.67/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:
************* Module bgp_large_community.test_bgp_large_community_topo_2
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:601:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:906:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:1353:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:2243:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.58/10
Pylint report for my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:
************* Module bgp_path_attributes_topo1.test_bgp_path_attributes
my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:241:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.80/10
Pylint report for my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:
************* Module bgp_prefix_list_topo1.test_prefix_lists
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:368:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:466:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:666:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:800:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:904:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1073:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1179:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1346:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 8.73/10
Pylint report for my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:
************* Module test_bgp_aggregation
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:245:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:276:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:416:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:423:11: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:428:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:431:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:457:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:485:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:490:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:495:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:582:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:587:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:592:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:611:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:648:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:672:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:719:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:729:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:736:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:741:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:796:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:829:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:980:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1020:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1138:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1148:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1155:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1160:39: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 4.98/10
Pylint report for my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:
************* Module test_route_map_topo2
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:105:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:106:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:108:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:109:0: C0413: Import "import inspect" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:110:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:111:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1053:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1065:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1319:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1330:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2159:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2570:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2815:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2846:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3652:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3663:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3965:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.29/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo1
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:230:14: E0602: Undefined variable 'request' (undefined-variable)
-----------------------------------
Your code has been rated at 9.89/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo2
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:918:31: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_chaos_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:256:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:274:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:344:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:868:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:870:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1005:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1037:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.92/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:258:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:276:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:346:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:881:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:888:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1350:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1352:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1357:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1359:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1433:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1435:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1438:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1440:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1534:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1536:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1539:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1541:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1993:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2004:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2019:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2022:20: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.14/10
Pylint report for my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:
************* Module isis_lfa_topo1.test_isis_lfa_topo1
my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:177:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:
************* Module isis_rlfa_topo1.test_isis_rlfa_topo1
my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:179:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:
************* Module test_ldp_topo1
my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:345:63: E0602: Undefined variable 'ospfStatus' (undefined-variable)
-----------------------------------
Your code has been rated at 9.86/10
Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1966:15: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.95/10
Pylint report for my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:
************* Module test_mcast_pim_bsmp_01
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:688:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:712:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:1328:11: E1306: Not enough arguments for format string (too-few-format-args)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:356:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:433:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:514:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:557:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:961:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1187:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1299:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.41/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:
************* Module test_multicast_pim_sm_topo4
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1044:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1060:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1079:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1095:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1120:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1143:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.24/10
Pylint report for my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:
************* Module test_ospf_p2mp
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:231:20: E0602: Undefined variable 'unicode' (undefined-variable)
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:282:20: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.21/10
Pylint report for my_frr/tests/topotests/pim_acl/test_pim_acl.py:
************* Module test_pim_acl
my_frr/tests/topotests/pim_acl/test_pim_acl.py:101:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:102:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:103:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:104:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:105:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:106:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:108:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:109:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
-----------------------------------
Your code has been rated at 9.46/10
Pylint report for my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:
************* Module test_pim_vrf
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:88:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:89:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:90:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:91:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:92:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:93:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:94:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:95:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:96:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:419:16: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.28/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topotests Ubuntu 18.04 i386 part 5: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests debian 10 amd64 part 7: Failed (click for details)Topotests debian 10 amd64 part 7: No useful log foundTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 7: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topotests debian 10 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topotests Ubuntu 18.04 i386 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 9: No useful log foundTopotests Ubuntu 18.04 arm8 part 3: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests debian 10 amd64 part 5: Failed (click for details)Topotests debian 10 amd64 part 5: No useful log foundTopotests debian 10 amd64 part 0: Failed (click for details)Topotests debian 10 amd64 part 0: No useful log foundTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topotests Ubuntu 18.04 i386 part 2: No useful log foundTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topotests Ubuntu 18.04 i386 part 7: No useful log foundTopotests debian 10 amd64 part 1: Failed (click for details)Topotests debian 10 amd64 part 1: No useful log foundTopotests debian 10 amd64 part 6: Failed (click for details)Topotests debian 10 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundTopotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 2: No useful log foundTopotests debian 10 amd64 part 2: Failed (click for details)Topotests debian 10 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topotests Ubuntu 18.04 i386 part 6: No useful log foundTopotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topotests Ubuntu 18.04 i386 part 4: No useful log foundTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topotests Ubuntu 18.04 i386 part 1: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topotests Ubuntu 18.04 i386 part 9: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 0: No useful log foundTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 6: No useful log foundTopotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topotests debian 10 amd64 part 4: No useful log foundTopotests debian 10 amd64 part 3: Failed (click for details)Topotests debian 10 amd64 part 3: No useful log foundTopotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 1: No useful log foundSuccessful on other platforms/tests
|
1095878
to
3efea0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:
************* Module bfd_ospf_topo1.test_bfd_ospf_topo1
my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:141:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.54/10
Pylint report for my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:
************* Module test_bgp_as_allow_in
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:256:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:401:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:449:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:603:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.23/10
Pylint report for my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:
************* Module bgp_basic_functionality_topo1.test_bgp_basic_functionality
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1140:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1157:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.72/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:
************* Module test_bgp_communities
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:344:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:350:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:396:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:400:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:583:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:587:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:633:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:637:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 7.75/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:
************* Module test_bgp_communities_topo2
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:295:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:314:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:333:43: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:379:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:405:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:416:35: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 6.79/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:
************* Module bgp_large_community.test_bgp_large_community_topo_1
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:90:4: E1205: Too many arguments for logging format string (logging-too-many-args)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:816:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.67/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:
************* Module bgp_large_community.test_bgp_large_community_topo_2
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:601:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:906:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:1353:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:2243:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.58/10
Pylint report for my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:
************* Module bgp_path_attributes_topo1.test_bgp_path_attributes
my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:241:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.80/10
Pylint report for my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:
************* Module bgp_prefix_list_topo1.test_prefix_lists
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:368:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:466:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:666:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:800:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:904:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1073:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1179:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1346:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 8.73/10
Pylint report for my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:
************* Module test_bgp_aggregation
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:245:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:276:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:416:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:423:11: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:428:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:431:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:457:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:485:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:490:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:495:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:582:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:587:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:592:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:611:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:648:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:672:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:719:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:729:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:736:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:741:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:796:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:829:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:980:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1020:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1138:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1148:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1155:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1160:39: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 4.98/10
Pylint report for my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:
************* Module test_route_map_topo2
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:105:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:106:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:108:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:109:0: C0413: Import "import inspect" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:110:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:111:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1053:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1065:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1319:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1330:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2159:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2570:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2815:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2846:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3652:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3663:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3965:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.29/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo1
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:230:14: E0602: Undefined variable 'request' (undefined-variable)
-----------------------------------
Your code has been rated at 9.89/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo2
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:918:31: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_chaos_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:256:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:274:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:344:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:868:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:870:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1005:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1037:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.92/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:258:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:276:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:346:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:881:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:888:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1350:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1352:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1357:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1359:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1433:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1435:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1438:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1440:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1534:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1536:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1539:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1541:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1993:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2004:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2019:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2022:20: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.14/10
Pylint report for my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:
************* Module isis_lfa_topo1.test_isis_lfa_topo1
my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:177:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:
************* Module isis_rlfa_topo1.test_isis_rlfa_topo1
my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:179:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:
************* Module test_ldp_topo1
my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:345:63: E0602: Undefined variable 'ospfStatus' (undefined-variable)
-----------------------------------
Your code has been rated at 9.86/10
Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1966:15: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.95/10
Pylint report for my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:
************* Module test_mcast_pim_bsmp_01
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:688:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:712:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:1328:11: E1306: Not enough arguments for format string (too-few-format-args)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:356:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:433:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:514:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:557:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:961:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1187:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1299:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.41/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:
************* Module test_multicast_pim_sm_topo4
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1044:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1060:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1079:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1095:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1120:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1143:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.24/10
Pylint report for my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:
************* Module test_ospf_p2mp
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:231:20: E0602: Undefined variable 'unicode' (undefined-variable)
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:282:20: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.21/10
Pylint report for my_frr/tests/topotests/pim_acl/test_pim_acl.py:
************* Module test_pim_acl
my_frr/tests/topotests/pim_acl/test_pim_acl.py:101:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:102:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:103:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:104:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:105:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:106:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:108:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:109:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
-----------------------------------
Your code has been rated at 9.46/10
Pylint report for my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:
************* Module test_pim_vrf
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:88:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:89:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:90:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:91:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:92:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:93:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:94:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:95:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:96:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:419:16: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.28/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests debian 10 amd64 part 2: Failed (click for details)Topotests debian 10 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 2: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topotests Ubuntu 18.04 i386 part 2: No useful log foundTopotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 2: No useful log foundSuccessful on other platforms/tests
|
3efea0c
to
fd1f40d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-by
line; we can't accept your contribution until all of your commits have one - One of your commits does not have a blank line between the summary and body; this will break
git log --oneline
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:
************* Module bfd_ospf_topo1.test_bfd_ospf_topo1
my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:141:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.54/10
Pylint report for my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:
************* Module test_bgp_as_allow_in
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:256:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:401:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:449:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:603:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.23/10
Pylint report for my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:
************* Module bgp_basic_functionality_topo1.test_bgp_basic_functionality
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1140:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1157:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.72/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:
************* Module test_bgp_communities
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:344:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:350:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:396:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:400:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:583:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:587:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:633:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:637:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 7.75/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:
************* Module test_bgp_communities_topo2
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:295:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:314:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:333:43: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:379:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:405:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:416:35: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 6.79/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:
************* Module bgp_large_community.test_bgp_large_community_topo_1
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:90:4: E1205: Too many arguments for logging format string (logging-too-many-args)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:816:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.67/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:
************* Module bgp_large_community.test_bgp_large_community_topo_2
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:601:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:906:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:1353:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:2243:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.58/10
Pylint report for my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:
************* Module bgp_path_attributes_topo1.test_bgp_path_attributes
my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:241:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.80/10
Pylint report for my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:
************* Module bgp_prefix_list_topo1.test_prefix_lists
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:368:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:466:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:666:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:800:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:904:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1073:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1179:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1346:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 8.73/10
Pylint report for my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:
************* Module test_bgp_aggregation
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:245:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:276:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:416:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:423:11: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:428:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:431:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:457:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:485:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:490:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:495:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:582:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:587:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:592:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:611:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:648:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:672:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:719:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:729:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:736:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:741:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:796:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:829:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:980:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1020:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1138:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1148:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1155:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1160:39: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 4.98/10
Pylint report for my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:
************* Module test_route_map_topo2
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:105:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:106:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:108:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:109:0: C0413: Import "import inspect" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:110:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:111:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1053:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1065:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1319:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1330:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2159:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2570:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2815:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2846:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3652:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3663:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3965:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.29/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo1
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:230:14: E0602: Undefined variable 'request' (undefined-variable)
-----------------------------------
Your code has been rated at 9.89/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo2
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:918:31: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_chaos_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:256:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:274:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:344:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:868:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:870:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1005:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1037:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.92/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:258:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:276:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:346:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:881:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:888:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1350:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1352:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1357:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1359:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1433:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1435:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1438:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1440:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1534:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1536:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1539:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1541:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1993:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2004:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2019:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2022:20: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.14/10
Pylint report for my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:
************* Module isis_lfa_topo1.test_isis_lfa_topo1
my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:177:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:
************* Module isis_rlfa_topo1.test_isis_rlfa_topo1
my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:179:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:
************* Module test_ldp_topo1
my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:345:63: E0602: Undefined variable 'ospfStatus' (undefined-variable)
-----------------------------------
Your code has been rated at 9.86/10
Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1966:15: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.95/10
Pylint report for my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:
************* Module test_mcast_pim_bsmp_01
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:688:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:712:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:1328:11: E1306: Not enough arguments for format string (too-few-format-args)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:356:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:433:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:514:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:557:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:961:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1187:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1299:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.41/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:
************* Module test_multicast_pim_sm_topo4
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1044:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1060:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1079:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1095:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1120:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1143:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.24/10
Pylint report for my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:
************* Module test_ospf_p2mp
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:231:20: E0602: Undefined variable 'unicode' (undefined-variable)
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:282:20: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.21/10
Pylint report for my_frr/tests/topotests/pim_acl/test_pim_acl.py:
************* Module test_pim_acl
my_frr/tests/topotests/pim_acl/test_pim_acl.py:101:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:102:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:103:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:104:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:105:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:106:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:108:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:109:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
-----------------------------------
Your code has been rated at 9.46/10
Pylint report for my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:
************* Module test_pim_vrf
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:88:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:89:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:90:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:91:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:92:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:93:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:94:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:95:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:96:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:419:16: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.28/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
fd1f40d
to
56631bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-by
line; we can't accept your contribution until all of your commits have one - One of your commits does not have a blank line between the summary and body; this will break
git log --oneline
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:
************* Module bfd_ospf_topo1.test_bfd_ospf_topo1
my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:141:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.54/10
Pylint report for my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:
************* Module test_bgp_as_allow_in
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:256:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:401:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:449:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:603:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.23/10
Pylint report for my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:
************* Module bgp_basic_functionality_topo1.test_bgp_basic_functionality
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1140:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1157:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.72/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:
************* Module test_bgp_communities
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:344:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:350:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:396:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:400:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:583:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:587:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:633:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:637:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 7.75/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:
************* Module test_bgp_communities_topo2
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:295:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:314:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:333:43: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:379:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:405:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:416:35: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 6.79/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:
************* Module bgp_large_community.test_bgp_large_community_topo_1
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:90:4: E1205: Too many arguments for logging format string (logging-too-many-args)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:816:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.67/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:
************* Module bgp_large_community.test_bgp_large_community_topo_2
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:601:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:906:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:1353:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:2243:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.58/10
Pylint report for my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:
************* Module bgp_path_attributes_topo1.test_bgp_path_attributes
my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:241:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.80/10
Pylint report for my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:
************* Module bgp_prefix_list_topo1.test_prefix_lists
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:368:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:466:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:666:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:800:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:904:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1073:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1179:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1346:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 8.73/10
Pylint report for my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:
************* Module test_bgp_aggregation
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:245:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:276:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:416:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:423:11: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:428:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:431:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:457:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:485:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:490:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:495:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:582:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:587:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:592:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:611:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:648:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:672:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:719:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:729:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:736:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:741:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:796:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:829:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:980:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1020:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1138:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1148:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1155:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1160:39: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 4.98/10
Pylint report for my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:
************* Module test_route_map_topo2
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:105:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:106:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:108:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:109:0: C0413: Import "import inspect" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:110:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:111:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1053:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1065:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1319:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1330:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2159:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2570:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2815:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2846:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3652:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3663:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3965:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.29/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo1
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:230:14: E0602: Undefined variable 'request' (undefined-variable)
-----------------------------------
Your code has been rated at 9.89/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo2
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:918:31: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_chaos_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:256:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:274:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:344:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:868:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:870:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1005:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1037:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.92/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:258:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:276:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:346:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:881:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:888:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1350:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1352:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1357:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1359:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1433:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1435:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1438:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1440:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1534:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1536:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1539:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1541:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1993:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2004:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2019:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2022:20: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.14/10
Pylint report for my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:
************* Module isis_lfa_topo1.test_isis_lfa_topo1
my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:177:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:
************* Module isis_rlfa_topo1.test_isis_rlfa_topo1
my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:179:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:
************* Module test_ldp_topo1
my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:345:63: E0602: Undefined variable 'ospfStatus' (undefined-variable)
-----------------------------------
Your code has been rated at 9.86/10
Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1966:15: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.95/10
Pylint report for my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:
************* Module test_mcast_pim_bsmp_01
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:688:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:712:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:1328:11: E1306: Not enough arguments for format string (too-few-format-args)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:356:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:433:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:514:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:557:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:961:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1187:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1299:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.41/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:
************* Module test_multicast_pim_sm_topo4
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1044:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1060:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1079:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1095:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1120:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1143:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.24/10
Pylint report for my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:
************* Module test_ospf_p2mp
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:231:20: E0602: Undefined variable 'unicode' (undefined-variable)
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:282:20: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.21/10
Pylint report for my_frr/tests/topotests/pim_acl/test_pim_acl.py:
************* Module test_pim_acl
my_frr/tests/topotests/pim_acl/test_pim_acl.py:101:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:102:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:103:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:104:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:105:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:106:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:108:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:109:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
-----------------------------------
Your code has been rated at 9.46/10
Pylint report for my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:
************* Module test_pim_vrf
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:88:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:89:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:90:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:91:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:92:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:93:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:94:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:95:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:96:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:419:16: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.28/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
While defaults are good picks for "reasonable" guesses, min and max range values really aren't. Operators and experimenters often like to configure "unreasonable" values to stress test, tests boundary conditions and explore innovations. With that in mind, change all ranges to 1..max (of type). While we're here add optional ignored values in the "no" CLI forms. Signed-off-by: Christian Hopps <chopps@labn.net>
- cleanup pim configuration code Signed-off-by: Christian Hopps <chopps@labn.net>
- completes change made in FRRouting#9190 - also lowers other pim and igmp timer values to speed things up. Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
- also good for testing infra features Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
- format with black in emacs - wrap text at 88 (black) - find the project pylint file Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 0:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO0DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-20873/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO7U18I386/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 6:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 4:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 2:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO2U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 2:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPOU1804/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 3: No useful log foundTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 5:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO5DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO1U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 7:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO7DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO8DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO3DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 3:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO3DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 2:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO2DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5U18AMD64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 5:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO5U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 1:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO0U18I386/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-20873/test Topology Tests failed for Topotests debian 10 amd64 part 9:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 5:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO5U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-20873/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-20873/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundTopotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO3U18I386-20873/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20873/artifact/TOPO3U18I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
- Decrease igmp query interval to fix pim test run times Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
Signed-off-by: Christian Hopps <chopps@labn.net>
We already, reasonably, require python3 elsewhere. Do so here, and reap some benefit. Signed-off-by: Christian Hopps <chopps@labn.net>
56631bd
to
b3b3438
Compare
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: FailedCheckout code: Failed (click for details)PullReq merge failed. Please rebase your branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
- One of your commits has a missing or badly formatted
Signed-off-by
line; we can't accept your contribution until all of your commits have one - One of your commits does not have a blank line between the summary and body; this will break
git log --oneline
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:
************* Module bfd_ospf_topo1.test_bfd_ospf_topo1
my_frr/tests/topotests/bfd_ospf_topo1/test_bfd_ospf_topo1.py:141:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.54/10
Pylint report for my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:
************* Module test_bgp_as_allow_in
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:256:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:401:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:449:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_as_allow_in/test_bgp_as_allow_in.py:603:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.23/10
Pylint report for my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:
************* Module bgp_basic_functionality_topo1.test_bgp_basic_functionality
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1140:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_basic_functionality_topo1/test_bgp_basic_functionality.py:1157:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.72/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:
************* Module test_bgp_communities
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:344:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:350:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:396:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:400:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:583:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:587:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:633:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities.py:637:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 7.75/10
Pylint report for my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:
************* Module test_bgp_communities_topo2
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:295:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:314:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:333:43: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:379:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:405:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_communities_topo1/test_bgp_communities_topo2.py:416:35: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 6.79/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:
************* Module bgp_large_community.test_bgp_large_community_topo_1
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:90:4: E1205: Too many arguments for logging format string (logging-too-many-args)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_1.py:816:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.67/10
Pylint report for my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:
************* Module bgp_large_community.test_bgp_large_community_topo_2
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:601:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:906:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:1353:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_large_community/test_bgp_large_community_topo_2.py:2243:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.58/10
Pylint report for my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:
************* Module bgp_path_attributes_topo1.test_bgp_path_attributes
my_frr/tests/topotests/bgp_path_attributes_topo1/test_bgp_path_attributes.py:241:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 9.80/10
Pylint report for my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:
************* Module bgp_prefix_list_topo1.test_prefix_lists
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:368:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:466:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:666:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:800:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:904:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1073:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1179:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/bgp_prefix_list_topo1/test_prefix_lists.py:1346:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
-----------------------------------
Your code has been rated at 8.73/10
Pylint report for my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:
************* Module test_bgp_aggregation
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:245:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:276:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:361:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:416:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:423:11: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:428:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:431:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:457:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:485:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:490:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:495:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:582:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:587:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:592:35: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:611:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:648:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:672:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:719:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:729:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:736:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:741:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:796:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:829:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:980:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1020:31: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1138:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1148:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1155:39: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_aggregation/test_bgp_aggregation.py:1160:39: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 4.98/10
Pylint report for my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:
************* Module test_route_map_topo2
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:105:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:106:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:108:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:109:0: C0413: Import "import inspect" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:110:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:111:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1053:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1065:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1319:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:1330:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2159:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2570:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2815:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:2846:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3652:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3663:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_route_map/test_route_map_topo2.py:3965:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.29/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo1
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo1.py:230:14: E0602: Undefined variable 'request' (undefined-variable)
-----------------------------------
Your code has been rated at 9.89/10
Pylint report for my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:
************* Module test_bgp_vrf_dynamic_route_leak_topo2
my_frr/tests/topotests/bgp_vrf_dynamic_route_leak/test_bgp_vrf_dynamic_route_leak_topo2.py:918:31: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_chaos_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:256:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:274:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:344:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:868:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:870:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1005:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_chaos_topo1.py:1037:8: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.92/10
Pylint report for my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:
************* Module evpn_type5_test_topo1.test_evpn_type5_topo1
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:258:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:276:12: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:346:69: E0602: Undefined variable 'tc_name' (undefined-variable)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:881:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:888:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1350:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1352:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1357:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1359:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1433:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1435:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1438:17: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1440:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1534:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1536:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1539:13: E1123: Unexpected keyword argument 'expected' in function call (unexpected-keyword-arg)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1541:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:1993:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2004:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2019:20: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/evpn_type5_test_topo1/test_evpn_type5_topo1.py:2022:20: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 8.14/10
Pylint report for my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:
************* Module isis_lfa_topo1.test_isis_lfa_topo1
my_frr/tests/topotests/isis_lfa_topo1/test_isis_lfa_topo1.py:177:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:
************* Module isis_rlfa_topo1.test_isis_rlfa_topo1
my_frr/tests/topotests/isis_rlfa_topo1/test_isis_rlfa_topo1.py:179:25: E1101: Instance of 'dict' has no 'iteritems' member (no-member)
-----------------------------------
Your code has been rated at 9.81/10
Pylint report for my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:
************* Module test_ldp_topo1
my_frr/tests/topotests/ldp_topo1/test_ldp_topo1.py:345:63: E0602: Undefined variable 'ospfStatus' (undefined-variable)
-----------------------------------
Your code has been rated at 9.86/10
Pylint report for my_frr/tests/topotests/lib/topotest.py:
************* Module lib.topotest
my_frr/tests/topotests/lib/topotest.py:1966:15: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.95/10
Pylint report for my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:
************* Module test_mcast_pim_bsmp_01
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:688:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:712:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py:1328:11: E1306: Not enough arguments for format string (too-few-format-args)
-----------------------------------
Your code has been rated at 9.79/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:356:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:433:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:514:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:557:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:961:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1187:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1299:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.41/10
Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:
************* Module test_multicast_pim_sm_topo4
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1044:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1060:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1079:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1095:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1120:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo3/test_multicast_pim_sm_topo4.py:1143:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.24/10
Pylint report for my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:
************* Module test_ospf_p2mp
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:231:20: E0602: Undefined variable 'unicode' (undefined-variable)
my_frr/tests/topotests/ospf_basic_functionality/test_ospf_p2mp.py:282:20: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.21/10
Pylint report for my_frr/tests/topotests/pim_acl/test_pim_acl.py:
************* Module test_pim_acl
my_frr/tests/topotests/pim_acl/test_pim_acl.py:101:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:102:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:103:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:104:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:105:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:106:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:107:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:108:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_acl/test_pim_acl.py:109:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
-----------------------------------
Your code has been rated at 9.46/10
Pylint report for my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:
************* Module test_pim_vrf
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:88:0: C0413: Import "import json" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:89:0: C0413: Import "import functools" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:90:0: C0413: Import "import os" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:91:0: C0413: Import "import sys" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:92:0: C0413: Import "import pytest" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:93:0: C0413: Import "import re" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:94:0: C0413: Import "import time" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:95:0: C0413: Import "from time import sleep" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:96:0: C0413: Import "import socket" should be placed at the top of the module (wrong-import-position)
my_frr/tests/topotests/pim_igmp_vrf/test_pim_vrf.py:419:16: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.28/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
🚧 Basic BGPD CI results: Partial FAILURE, autoscript-2021-08-10-19:23:18.log.bz2 tests failed, has VALGRIND issuesResults table
For details, please contact louberger |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
No description provided.