-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtysh: deal with '!' in frr configuration file. #9250
Conversation
'!' means return to parent node in vtysh, we should not regard it same to '#' or ' '. Signed-off-by: anlan_cs <anlan_cs@tom.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An exclamation mark is only a config label. It can be used anywhere in the config file and exiting the node when seeing an !
can break a lot of existing configs. We can't merge this.
I am going to work on a fix for this issue – the idea is to print the explicit exit
command at the end of the node's config.
@polychaeta autoclose in 1 day |
Just to add a bit of additional info - |
Of course instead of "An exclamation mark is only a config label" I wanted to say "An exclamation mark is only a comment label" 😄 |
See. Thanks! |
'!' means return to parent node in vtysh, we should not regard it same to '#'
or ' '.
fix #9206
Signed-off-by: anlan_cs anlan_cs@tom.com