vtysh: deal with '!' in frr configuration file. #9250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'!' means return to parent node in vtysh, we should not regard it same to '#' or ' '. Signed-off-by: anlan_cs <anlan_cs@tom.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
idryzhov
requested changes
Aug 2, 2021
There was a problem hiding this comment.
An exclamation mark is only a config label. It can be used anywhere in the config file and exiting the node when seeing an ! can break a lot of existing configs. We can't merge this.
I am going to work on a fix for this issue – the idea is to print the explicit exit command at the end of the node's config.
|
@polychaeta autoclose in 1 day |
|
Just to add a bit of additional info - |
|
Of course instead of "An exclamation mark is only a config label" I wanted to say "An exclamation mark is only a comment label" 😄 |
|
See. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'!' means return to parent node in vtysh, we should not regard it same to '#'
or ' '.
fix #9206
Signed-off-by: anlan_cs anlan_cs@tom.com