Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtysh: deal with '!' in frr configuration file. #9250

Closed
wants to merge 1 commit into from

Conversation

anlancs
Copy link
Contributor

@anlancs anlancs commented Aug 1, 2021

'!' means return to parent node in vtysh, we should not regard it same to '#'
or ' '.

fix #9206

Signed-off-by: anlan_cs anlan_cs@tom.com

'!' means return to parent node in vtysh, we should not regard it same to '#'
or ' '.

Signed-off-by: anlan_cs <anlan_cs@tom.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 1, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9250 24c6ed3
Date 08/01/2021
Start 04:15:55
Finish 04:41:22
Run-Time 25:27
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-08-01-04:15:55.txt
Log autoscript-2021-08-01-04:17:11.log.bz2
Memory 483 479 426

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20687/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 3
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 8
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 1
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 4
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 0
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 5
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 4
  • IPv6 protocols on Ubuntu 18.04

Copy link
Contributor

@idryzhov idryzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An exclamation mark is only a config label. It can be used anywhere in the config file and exiting the node when seeing an ! can break a lot of existing configs. We can't merge this.

I am going to work on a fix for this issue – the idea is to print the explicit exit command at the end of the node's config.

@idryzhov
Copy link
Contributor

idryzhov commented Aug 2, 2021

@polychaeta autoclose in 1 day

@qlyoung
Copy link
Member

qlyoung commented Aug 3, 2021

Just to add a bit of additional info - ! is a comment character, by design. It is working as intended.

@idryzhov
Copy link
Contributor

idryzhov commented Aug 3, 2021

Of course instead of "An exclamation mark is only a config label" I wanted to say "An exclamation mark is only a comment label" 😄
Thank you, Quentin.

@anlancs
Copy link
Contributor Author

anlancs commented Aug 4, 2021

See. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtysh -b: % Unknown command
6 participants