Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospf6d: introduce support for Graceful Restart (restarting mode) #8985

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

rwestphal
Copy link
Member

This is the ospf6d equivalent of #8767. The code started as a copy of the ospfd GR code, then several adaptations were made to make it work on ospf6d.

This PR is based on top of #8935, which implements the OSPFv3 GR helper mode (which is necessary for the included topotest to pass).

Any feedback would be appreciated!

@polychaeta polychaeta added ospfv3 tests Topotests, make check, etc labels Jul 6, 2021
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 6, 2021

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/8985 58da626 frr.github Build
Date 07/05/2021
Start 22:31:05
Finish 22:32:02
Run-Time 00:57
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-05-22:31:05.txt
Log make-2021-07-05-22:31:05.out.bz2
Memory

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 6, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:14709:7: error: 'OSPF_GR_STR' undeclared here (not in a function); did you mean 'OSPF_RI_STR'?
./lib/command.h:244:10: note: in definition of macro 'DEFUN_CMD_ELEMENT'
vtysh/vtysh_cmd.c:14707:1: note: in expansion of macro 'DEFSH'
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:14710:7: error: expected '}' before string constant
./lib/command.h:244:10: note: in definition of macro 'DEFUN_CMD_ELEMENT'

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/FBSD12AMD64/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804AMD64/config.log/config.log.gz

Debian 11 amd64 build: Failed (click for details) Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB11AMD64/config.status/config.status

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB11AMD64/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:1319: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
15028 |       OSPF_GR_STR
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
15026 | DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
15029 |       "Maximum length of the 'grace period'\n"

Debian 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB11AMD64/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details) CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2737: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CENTOS8BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh, 
 ^
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI021BUILD/config.log/config.log.gz

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI011BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_cmd.c:13779:7: error: use of undeclared identifier 'OSPF_GR_STR'
vtysh/vtysh_cmd.c:13814:48: error: expected '}'
vtysh/vtysh_cmd.c:13812:1: note: to match this '{'
DEFSH (VTYSH_OSPF6D, ospf6_no_graceful_restart_cmd_vtysh, 
^
./lib/command.h:310:2: note: expanded from macro 'DEFSH'
./lib/command.h:241:44: note: expanded from macro 'DEFUN_CMD_ELEMENT'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI011BUILD/config.status/config.status
OpenBSD 6 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI011BUILD/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:1319: WARNING: duplicate clicmd description of debug zebra pbr, other instance in pbr
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:14709:7: error: 'OSPF_GR_STR' undeclared here (not in a function); did you mean 'OSPF_RI_STR'?
14709 |       OSPF_GR_STR
./lib/command.h:244:10: note: in definition of macro 'DEFUN_CMD_ELEMENT'
vtysh/vtysh_cmd.c:14707:1: note: in expansion of macro 'DEFSH'
14707 | DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
vtysh/vtysh_cmd.c:14710:7: error: expected '}' before string constant
14710 |       "Maximum length of the 'grace period'\n"

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI009BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI012BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2737: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:14709:7: error: 'OSPF_GR_STR' undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro 'DEFUN_CMD_ELEMENT'
vtysh/vtysh_cmd.c:14707:1: note: in expansion of macro 'DEFSH'
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh, 
 ^
vtysh/vtysh_cmd.c:14710:7: error: expected '}' before string constant
./lib/command.h:244:10: note: in definition of macro 'DEFUN_CMD_ELEMENT'

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI012BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI005BUILD/ErrorLog/log_make.txt)

make  all-am
make[1]: Entering directory `/home/ci/cibuild.20067/frr-source'
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.  CC       bgpd/bgp_addpath.o
deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed.deprecation warning: io.FileInput() argument `handle_io_errors` is ignored since "Docutils 0.10 (2012-12-16)" and will soon be removed./home/ci/cibuild.20067/frr-source/doc/user/basic.rst:23: SEVERE: Duplicate ID: "clicmd-domainnameDOMAINNAME".
/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2753: ERROR: Unexpected indentation.
/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI005BUILD/config.status/config.status
CentOS 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI005BUILD/config.log/config.log.gz

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM7BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh, 
 ^
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details) Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
Ubuntu 20.04 amd64 build: Failed (click for details) Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2737: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
15028 |       OSPF_GR_STR
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
15026 | DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
15029 |       "Maximum length of the 'grace period'\n"

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 18.04 i386 build: Failed (click for details) Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18I386BUILD/config.status/config.status

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U18I386BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2755: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh, 
 ^
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U1604I386/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/F29BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2737: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/F29BUILD/config.log/config.log.gz

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB10BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/bgp.rst:2737: WARNING: Block quote ends without a blank line; unexpected unindent.
In file included from vtysh/vtysh_cmd.c:3:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function); did you mean OSPF_RI_STR?
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh,
 ^~~~~
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.20067/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
In file included from vtysh/vtysh_cmd.c:3:0:
vtysh/vtysh_cmd.c:15028:7: error: OSPF_GR_STR undeclared here (not in a function)
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT
vtysh/vtysh_cmd.c:15026:1: note: in expansion of macro DEFSH
 DEFSH (VTYSH_OSPF6D, ospf6_graceful_restart_cmd_vtysh, 
 ^
vtysh/vtysh_cmd.c:15029:7: error: expected } before string constant
./lib/command.h:244:10: note: in definition of macro DEFUN_CMD_ELEMENT

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20067/artifact/U16ARM8BUILD/config.status/config.status

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 11, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git pull/8985 7cdb612 (merge failed)
Date 07/10/2021
Start 21:45:44
Finish 22:11:11
Run-Time 25:27
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-10-21:45:44.txt
Log autoscript-2021-07-10-21:46:59.log.bz2
Memory 483 496 427

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 11, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/frratomic.h:21:0,
ospf6d/ospf6_gr.c: In function ospf6_gr_nvm_update:
./config.h:640:25: error: passing argument 1 of json_object_to_file_ext discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
 #define OSPF6D_GR_STATE "/var/run/ospf6d-gr.json"
ospf6d/ospf6_gr.c:506:26: note: in expansion of macro OSPF6D_GR_STATE
In file included from /usr/include/json-c/json.h:24:0,
/usr/include/json-c/json_util.h:26:12: note: expected char * but argument is of type const char *
 extern int json_object_to_file_ext(char *filename, struct json_object *obj, int flags);
In file included from ./lib/frratomic.h:21:0,

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/frratomic.h:21:0,
ospf6d/ospf6_gr.c: In function ospf6_gr_nvm_update:
./config.h:640:25: error: passing argument 1 of json_object_to_file_ext discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
 #define OSPF6D_GR_STATE "/var/run/ospf6d-gr.json"
ospf6d/ospf6_gr.c:506:26: note: in expansion of macro OSPF6D_GR_STATE
In file included from /usr/include/json-c/json.h:24:0,
/usr/include/json-c/json_util.h:26:12: note: expected char * but argument is of type const char *
 extern int json_object_to_file_ext(char *filename, struct json_object *obj, int flags);
In file included from ./lib/frratomic.h:21:0,

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U1604I386/config.log/config.log.gz

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/frratomic.h:21:0,
ospf6d/ospf6_gr.c: In function ospf6_gr_nvm_update:
./config.h:640:25: error: passing argument 1 of json_object_to_file_ext discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
 #define OSPF6D_GR_STATE "/var/run/ospf6d-gr.json"
ospf6d/ospf6_gr.c:506:26: note: in expansion of macro OSPF6D_GR_STATE
In file included from /usr/include/json-c/json.h:24:0,
/usr/include/json-c/json_util.h:26:12: note: expected char * but argument is of type const char *
 extern int json_object_to_file_ext(char *filename, struct json_object *obj, int flags);
In file included from ./lib/frratomic.h:21:0,

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20168/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/frratomic.h:21:0,
ospf6d/ospf6_gr.c: In function ospf6_gr_nvm_update:
./config.h:640:25: error: passing argument 1 of json_object_to_file_ext discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
 #define OSPF6D_GR_STATE "/var/run/ospf6d-gr.json"
ospf6d/ospf6_gr.c:506:26: note: in expansion of macro OSPF6D_GR_STATE
In file included from /usr/include/json-c/json.h:24:0,
/usr/include/json-c/json_util.h:26:12: note: expected char * but argument is of type const char *
 extern int json_object_to_file_ext(char *filename, struct json_object *obj, int flags);
In file included from ./lib/frratomic.h:21:0,
Successful on other platforms/tests
  • NetBSD 8 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 arm7 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • OpenBSD 6 amd64 build
  • FreeBSD 11 amd64 build
  • Fedora 29 amd64 build
  • CentOS 8 amd64 build
  • Ubuntu 18.04 i386 build
  • Debian 10 amd64 build
  • FreeBSD 12 amd64 build

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 12, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20190/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20190/artifact/CHECKOUT/ErrorLog/log_merge.txt

@rwestphal
Copy link
Member Author

CI:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 12, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20193/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Failed

Checkout code: Failed (click for details)

PullReq merge failed. Please rebase your branch:
see merge log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20193/artifact/CHECKOUT/ErrorLog/log_merge.txt

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 12, 2021

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_ _
Result SUCCESS git merge/8985 f6c66e4
Date 07/12/2021
Start 10:06:13
Finish 10:31:38
Run-Time 25:25
Total 1815
Pass 1814
Fail 1
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-12-10:06:13.txt
Log autoscript-2021-07-12-10:07:22.log.bz2
Memory 450 511 408

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 12, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 7: Incomplete (check logs for details)
Addresssanitizer topotests part 7: Incomplete (check logs for details)
Addresssanitizer topotests part 8: Incomplete (check logs for details)
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 6
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 1
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 3
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 7

@rwestphal
Copy link
Member Author

rwestphal commented Jul 12, 2021 via email

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 12, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20205/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Incomplete

Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 16.04 arm8 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 16.04 arm8 build: Incomplete (check logs for details)
Ubuntu 18.04 arm8 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 16.04 arm8 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 ppc64le build: Incomplete (check logs for details)
Ubuntu 18.04 arm7 build: Incomplete (check logs for details)
Ubuntu 16.04 arm8 build: Incomplete (check logs for details)
Ubuntu 18.04 arm8 build: Incomplete (check logs for details)
Ubuntu 16.04 arm7 build: Incomplete (check logs for details)
Successful on other platforms/tests
  • Ubuntu 20.04 amd64 build
  • Debian 9 amd64 build
  • NetBSD 8 amd64 build
  • Fedora 29 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • CentOS 7 amd64 build
  • OpenBSD 6 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 i386 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 amd64 build
  • CentOS 8 amd64 build
### Basic Tests: Incomplete

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 12, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/config.log/config.log.gz
Ubuntu 18.04 ppc64le build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz

Successful on other platforms/tests
  • Debian 11 amd64 build
  • Ubuntu 18.04 amd64 build
  • CentOS 7 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 16.04 arm7 build
  • CentOS 8 amd64 build
  • Debian 9 amd64 build
  • NetBSD 8 amd64 build
  • OpenBSD 6 amd64 build
  • Ubuntu 16.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 16.04 i386 build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build
  • Ubuntu 16.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 18.04 ppc64le build: Failed (click for details)

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt
Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/config.log/config.log.gz
Ubuntu 18.04 ppc64le build: Unknown Log <frr.xref.xz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20194/artifact/U1804PPC64LEBUILD/frr.xref.xz/frr.xref.xz

Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1072: FILE: /tmp/f1-14191/ospf6_flood.c:1072:

@rwestphal
Copy link
Member Author

CI:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 13, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20212/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20212/test

Topology Tests failed for Topotests debian 10 amd64 part 1:

2021-07-13 04:15:48,489 ERROR: 'router_json_cmp' failed after 129.12 seconds
2021-07-13 04:15:48,491 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-13 04:32:06,777 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-13 04:32:07,383 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20212/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 6
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 0
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 3
  • Static analyzer (clang)
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 1
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 7
  • Ubuntu 20.04 deb pkg check
  • IPv4 ldp protocol on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests debian 10 amd64 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20212/test

Topology Tests failed for Topotests debian 10 amd64 part 1:

2021-07-13 04:15:48,489 ERROR: 'router_json_cmp' failed after 129.12 seconds
2021-07-13 04:15:48,491 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-13 04:32:06,777 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-13 04:32:07,383 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20212/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1072: FILE: /tmp/f1-30685/ospf6_flood.c:1072:

CLANG Static Analyzer Summary

  • Github Pull Request 8985, comparing to Git base SHA 507559a
  • Base image data for Git 507559a does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20212/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • sprintf, strcat, strcpy, inet_ntoa are banned; please use snprintf, strlcat, strlcpy, inet_ntop

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@rwestphal
Copy link
Member Author

Rebased on top of master to fix a merge conflict.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 13, 2021

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_ _
Result SUCCESS git merge/8985 50a761d
Date 07/13/2021
Start 08:26:10
Finish 08:51:53
Run-Time 25:43
Total 1815
Pass 1814
Fail 1
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-13-08:26:10.txt
Log autoscript-2021-07-13-08:27:32.log.bz2
Memory 518 495 428

For details, please contact louberger

@rwestphal
Copy link
Member Author

Rebased on top of master in order to adapt the new topotest to the latest API changes.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 7, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-59/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details) OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/frr.xref.xz/frr.xref.xz OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
__________________________ TestFlag.test_exit_cleanly __________________________
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           frrtest.MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:90: MultiTestFailure
__________________ TestFlag.test_peer_advertisement_interval ___________________
self = <test_peer_attr.TestFlag object at 0x14f84bca4080>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
line = b'peer\\advertisement-interval'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'peer\\advertisement-interval' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
____________________ TestFlag.test_peer_capability_dynamic _____________________
self = <test_peer_attr.TestFlag object at 0x14f84bc86400>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
line = b'peer\\capability dynamic'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'peer\\capability dynamic' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
________________ TestFlag.test_peer_capability_extended_nexthop ________________
self = <test_peer_attr.TestFlag object at 0x14f84bca4668>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
Successful on other platforms/tests
  • Debian 9 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • CentOS 8 amd64 build
  • FreeBSD 12 amd64 build
  • Fedora 29 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 arm7 build
  • Debian 11 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 18.04 i386 build
  • CentOS 7 amd64 build
  • NetBSD 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
OpenBSD 6 amd64 build: Failed (click for details) OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/frr.xref.xz/frr.xref.xz OpenBSD 6 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/config.log/config.log.gz OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-PULLREQ2-59/artifact/CI011BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
__________________________ TestFlag.test_exit_cleanly __________________________
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
    def _exit_cleanly(self):
        if self.exitcode != 0:
>           raise MultiTestFailure("Program did not terminate with exit code 0")
E           frrtest.MultiTestFailure: Program did not terminate with exit code 0
helpers/python/frrtest.py:90: MultiTestFailure
__________________ TestFlag.test_peer_advertisement_interval ___________________
self = <test_peer_attr.TestFlag object at 0x14f84bca4080>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
line = b'peer\\advertisement-interval'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'peer\\advertisement-interval' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
____________________ TestFlag.test_peer_capability_dynamic _____________________
self = <test_peer_attr.TestFlag object at 0x14f84bc86400>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x14f8813fd9e8>
line = b'peer\\capability dynamic'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode("utf8")
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx + len(line) :]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           frrtest.MultiTestFailure: b'peer\\capability dynamic' could not be found
helpers/python/frrtest.py:149: MultiTestFailure
________________ TestFlag.test_peer_capability_extended_nexthop ________________
self = <test_peer_attr.TestFlag object at 0x14f84bca4668>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:108: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrsix.py:62: in reraise
    raise value
helpers/python/frrtest.py:82: in _run_tests
    test(self)
helpers/python/frrtest.py:100: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:152: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-28991/ospf6_flood.c:1123:

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 7, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8985 281fbce
Date 09/07/2021
Start 11:39:06
Finish 12:05:26
Run-Time 26:20
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-09-07-11:39:06.txt
Log autoscript-2021-09-07-11:40:22.log.bz2
Memory 514 497 426

For details, please contact louberger

@rwestphal
Copy link
Member Author

CI:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-62/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 2
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 3
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 7
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 7: Failed (click for details) Topotests Ubuntu 18.04 i386 part 7: No useful log found
Topotests debian 10 amd64 part 9: Failed (click for details) Topotests debian 10 amd64 part 9: No useful log found
Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 5: No useful log found
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-27800/ospf6_flood.c:1123:

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 7, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8985 db8b876
Date 09/07/2021
Start 19:21:06
Finish 19:47:23
Run-Time 26:17
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-09-07-19:21:06.txt
Log autoscript-2021-09-07-19:22:20.log.bz2
Memory 504 498 424

For details, please contact louberger

@rwestphal
Copy link
Member Author

CI:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-81/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Successful on other platforms/tests
  • Topotests debian 10 amd64 part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • CentOS 7 rpm pkg check
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 1
  • Debian 9 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 1
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 9
  • IPv4 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 0
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests debian 10 amd64 part 0: Failed (click for details) Topotests debian 10 amd64 part 0: No useful log found
Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 9: No useful log found
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-1350/ospf6_flood.c:1123:

@riw777
Copy link
Member

riw777 commented Sep 8, 2021

failure doesn't look immediately related ... let's try a rerun

@riw777
Copy link
Member

riw777 commented Sep 8, 2021

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-92/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-13303/ospf6_flood.c:1123:

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777
Copy link
Member

riw777 commented Sep 10, 2021

waiting on conflicts now ... :-)

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 14, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8985 794467d
Date 09/13/2021
Start 23:16:11
Finish 23:42:13
Run-Time 26:02
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-09-13-23:16:11.txt
Log autoscript-2021-09-13-23:17:16.log.bz2
Memory 473 502 426

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Successful on other platforms/tests
  • Ubuntu 18.04 ppc64le build
  • FreeBSD 12 amd64 build
  • CentOS 8 amd64 build
  • Fedora 29 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build
  • OpenBSD 6 amd64 build
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 16.04 arm7 build
  • Ubuntu 18.04 i386 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 20.04 amd64 build
  • NetBSD 8 amd64 build
  • Debian 9 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 arm8 build
  • Ubuntu 16.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/frr.xref.xz/frr.xref.xz Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/config.status/config.status Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/artifact/U1604I386/ErrorLog/ Ubuntu 16.04 i386 build: No useful log found
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-7530/ospf6_flood.c:1123:

Commit b8212e0 introduced OSPF6_SPF_FLAGS_ASBR_STATUS_CHANGE but
didn't update the 'ospf6_spf_reason_str' array accordingly. Fix this.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
RFC 5187 specifies the Graceful Restart enhancement to the OSPFv3
routing protocol. This commit implements support for the GR
restarting mode.

Here's a quick summary of how the GR restarting mode works:
* GR can be enabled on a per-instance basis using the `graceful-restart
  [grace-period (1-1800)]` command;
* To perform a graceful shutdown, the `graceful-restart prepare ipv6
  ospf` EXEC-level command needs to be issued before restarting the
  ospf6d daemon (there's no specific requirement on how the daemon
  should be restarted);
* `graceful-restart prepare ospf` will initiate the graceful restart
  for all GR-enabled instances by taking the following actions:
  o Flooding Grace-LSAs over all interfaces
  o Freezing the OSPF routes in the RIB
  o Saving the end of the grace period in non-volatile memory (a JSON
    file stored in `$frr_statedir`)
* Once ospf6d is started again, it will follow the procedures
  described in RFC 3623 until it detects it's time to exit the graceful
  restart (either successfully or unsuccessfully).

Testing done:
* New topotest featuring a multi-area OSPF topology (including stub
  and NSSA areas);
* Successful interop tests against IOS-XR routers acting as helpers.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Add a new topotest that features a topology with seven routers spread
across four OSPF areas:
* 1 backbone area;
* 1 regular non-backbone area (0.0.0.1);
* 1 stub area (0.0.0.2);
* 1 NSSA area (0.0.0.3).

All routers have both GR and GR helper functionality enabled in
the configuration. The test consists of restarting each router,
one at time, and checking that all forwarding planes (and LSDBs)
are kept intact during those restarts.

A successful run takes about three minutes to finish.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Some CI VMs are using really old versions of json-c (pre 2013 [1])
that expect filenames to be passed as "char *" instead of "const char *".

Add some explicit casts to fix the resulting compiler errors on those
VMs (passing "char *" when the API expects "const char *" is fine).
Hopefully this commit should be reverted once the CI is updated to use
newer versions of json-c.

[1] json-c/json-c@20e4708c

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 16, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8985 b275f44
Date 09/16/2021
Start 11:36:06
Finish 12:02:28
Run-Time 26:22
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-09-16-11:36:06.txt
Log autoscript-2021-09-16-11:37:17.log.bz2
Memory 483 483 406

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-153/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 8
  • IPv4 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 7
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 0
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 9
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 4
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 5
  • Topotests debian 10 amd64 part 0
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 2
  • CentOS 7 rpm pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 9: Failed (click for details) Topotests Ubuntu 18.04 i386 part 9: No useful log found
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-7530/ospf6_flood.c:1123:

@rwestphal
Copy link
Member Author

CI:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-215/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-29320/ospf6_flood.c:1123:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-224/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for ospf6_flood.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1123: FILE: /tmp/f1-26310/ospf6_flood.c:1123:

@riw777 riw777 merged commit ca45d9e into FRRouting:master Sep 17, 2021
@eqvinox eqvinox deleted the ospf6d-gr branch May 26, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix feature ospfv3 tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants