Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup support bundles, fix bugs, add CLI timestamp #8939

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

choppsv1
Copy link
Contributor

Speedup (large topo): OLD: ~6 minutes NEW: ~1 second.

  • Collect from each node in parallel
  • On each node collect each "proc" support in parallel
  • For each "proc" only call vtysh once with all commands

Bug fixes:

  • output was broken, a dump of python "repr" format of str.
  • sub-directory test name was the same internal pytest function name
    for any test, and not the actual test name.

Needed timestamp to replace old gather bundle behavior so:

vtysh: add CLI timestamp '-t' flag

Example output:

flk# show version
% 2021/06/29 00:25:01.562

FRRouting 8.1-dev-my-manual-build (flk).
Copyright 1996-2005 Kunihiro Ishiguro, et al.

@polychaeta polychaeta added bugfix tests Topotests, make check, etc vtysh labels Jun 29, 2021
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10



Pylint report for my_frr/tools/generate_support_bundle.py:
************* Module generate_support_bundle
my_frr/tools/generate_support_bundle.py:70:8: E1205: Too many arguments for logging format string (logging-too-many-args)

-----------------------------------
Your code has been rated at 9.02/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from a8b7ff1 to b32a375 Compare June 29, 2021 01:49
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from b32a375 to 1e65cba Compare June 29, 2021 01:53
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from 1e65cba to 89f2c4a Compare June 29, 2021 01:57
@polychaeta polychaeta dismissed stale reviews from themself June 29, 2021 01:57

blocking comments addressed

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from 89f2c4a to 42ef367 Compare June 29, 2021 01:59
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@choppsv1
Copy link
Contributor Author

Thanks for your contribution to FRR!

Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

This is fixed by #8887

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8939 b32a375
Date 06/28/2021
Start 21:50:49
Finish 22:16:23
Run-Time 25:34
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-28-21:50:49.txt
Log autoscript-2021-06-28-21:52:03.log.bz2
Memory 515 520 423

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/U1604I386/config.log/config.log.gz

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI021BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
vtysh/vtysh_main.c: In function 'main':
vtysh/vtysh_main.c:312:6: error: variable 'ts_flag' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9854: vtysh/vtysh_main.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15022: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15032: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19892/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI014BUILD/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19892/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
Successful on other platforms/tests
  • Ubuntu 18.04 i386 build
  • Ubuntu 20.04 amd64 build
  • Debian 10 amd64 build
  • Debian 11 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 amd64 build
  • CentOS 8 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 18.04 arm8 build
  • OpenBSD 6 amd64 build
  • Ubuntu 18.04 arm7 build

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U1604I386/config.log/config.log.gz

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/U16ARM8BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI021BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
vtysh/vtysh_main.c: In function 'main':
vtysh/vtysh_main.c:312:6: error: variable 'ts_flag' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9854: vtysh/vtysh_main.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15022: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15032: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI012BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19891/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19891/artifact/CI014BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • Ubuntu 20.04 amd64 build
  • Ubuntu 18.04 i386 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 12 amd64 build
  • Debian 11 amd64 build
  • CentOS 8 amd64 build
  • Ubuntu 18.04 ppc64le build
  • OpenBSD 6 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/U1604I386/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19893/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI021BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
vtysh/vtysh_main.c: In function 'main':
vtysh/vtysh_main.c:312:6: error: variable 'ts_flag' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9854: vtysh/vtysh_main.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15022: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15032: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19893/artifact/CI012BUILD/config.status/config.status

Successful on other platforms/tests
  • Ubuntu 18.04 i386 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 12 amd64 build
  • CentOS 8 amd64 build
  • Debian 11 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 20.04 amd64 build
  • OpenBSD 6 amd64 build
  • Ubuntu 18.04 arm8 build

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
vtysh/vtysh_main.c: In function 'main':
vtysh/vtysh_main.c:312:6: error: variable 'ts_flag' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9854: vtysh/vtysh_main.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15022: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15032: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/U1604I386/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19895/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19895/artifact/CI021BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • FreeBSD 11 amd64 build
  • CentOS 8 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Debian 10 amd64 build
  • Ubuntu 18.04 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 20.04 amd64 build
  • OpenBSD 6 amd64 build

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
Ubuntu 16.04 arm7 build: Failed (click for details) Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI101BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI014BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U1604I386/ErrorLog/log_make.txt)

/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/U1604I386/config.log/config.log.gz

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
NetBSD 8 amd64 build: Failed (click for details) NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI012BUILD/ErrorLog/log_make.txt)

 static void elffile_add_dynreloc(struct elffile *w, Elf_Data *reldata,
vtysh/vtysh_main.c: In function 'main':
vtysh/vtysh_main.c:312:6: error: variable 'ts_flag' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:9854: vtysh/vtysh_main.o] Error 1
ld: warning: libintl.so.1, needed by /usr/pkg/lib/libpython3.7.so, may conflict with libintl.so.8
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:15022: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:15032: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI021BUILD/ErrorLog/log_make.txt)

/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
vtysh/vtysh_main.c: In function main:
vtysh/vtysh_main.c:312:6: error: variable ts_flag might be clobbered by longjmp or vfork [-Werror=clobbered]
cc1: all warnings being treated as errors
Makefile:9226: recipe for target 'vtysh/vtysh_main.o' failed
make[1]: *** [vtysh/vtysh_main.o] Error 1
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".
/home/ci/cibuild.19894/frr-source/doc/user/zebra.rst:23: SEVERE: Duplicate ID: "cmdoption-configure-arg-net".

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19894/artifact/CI021BUILD/config.log/config.log.gz

Successful on other platforms/tests
  • CentOS 8 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 i386 build
  • Debian 10 amd64 build
  • Debian 11 amd64 build
  • Ubuntu 18.04 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm8 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 18.04 ppc64le build
  • Ubuntu 20.04 amd64 build
  • OpenBSD 6 amd64 build

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8895 33df0a8
Date 06/21/2021
Start 22:20:50
Finish 22:46:14
Run-Time 25:24
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-21-22:20:50.txt
Log autoscript-2021-06-21-22:22:01.log.bz2
Memory 516 501 424
SUCCESS git merge/8939 42ef367 SUCCESS git merge/8584 c921cf3
06/28/2021 04/27/2021
22:20:52 22:20:50
22:46:19 23:01:55
25:27 41:05
1815 1815
1815 1815
0 0
0
0
vncregress-2021-06-28-22:20:52.txt vncregress-2021-04-27-22:20:50.txt
autoscript-2021-06-28-22:22:04.log.bz2 autoscript-2021-04-27-22:22:00.log.bz2
512 487 429 502 505 428

For details, please contact louberger

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from 42ef367 to f74e630 Compare June 29, 2021 06:56
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from f74e630 to 00f8069 Compare June 29, 2021 07:30
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 29 amd64 build: Failed (click for details) Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/F29BUILD/ErrorLog/ Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/F29BUILD/config.status/config.status Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/F29BUILD/config.log/config.log.gz Fedora 29 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/F29BUILD/frr.xref.xz/frr.xref.xz Fedora 29 amd64 build: No useful log found
CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/CI005BUILD/ErrorLog/ CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/CI005BUILD/config.status/config.status CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/CI005BUILD/config.log/config.log.gz CentOS 7 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19900/artifact/CI005BUILD/frr.xref.xz/frr.xref.xz CentOS 7 amd64 build: No useful log found
Successful on other platforms/tests
  • Debian 10 amd64 build
  • FreeBSD 11 amd64 build
  • Ubuntu 18.04 arm8 build
  • OpenBSD 6 amd64 build
  • Ubuntu 18.04 i386 build
  • FreeBSD 12 amd64 build
  • Ubuntu 18.04 amd64 build
  • Ubuntu 16.04 arm7 build
  • CentOS 8 amd64 build
  • Debian 9 amd64 build
  • Ubuntu 18.04 ppc64le build
  • NetBSD 8 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 arm7 build
  • Ubuntu 16.04 arm8 build
  • Debian 11 amd64 build
  • Ubuntu 20.04 amd64 build
  • Ubuntu 16.04 i386 build

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8939 f74e630
Date 06/29/2021
Start 03:25:50
Finish 03:51:22
Run-Time 25:32
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-29-03:25:50.txt
Log autoscript-2021-06-29-03:27:04.log.bz2
Memory 521 498 417

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8939 00f8069
Date 06/29/2021
Start 03:55:48
Finish 04:21:28
Run-Time 25:40
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-29-03:55:48.txt
Log autoscript-2021-06-29-03:56:58.log.bz2
Memory 494 499 417

For details, please contact louberger

@donaldsharp donaldsharp requested a review from pushpasis June 29, 2021 15:26
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 29, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19902/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit tests: generate support bundles in parallel.. really needs to be broken up into 2 commits. The common_config.py and the support bundle change. They are independent issues.

vtysh/vtysh.c Outdated
@@ -56,6 +56,9 @@ struct vty *vty;
/* VTY shell pager name. */
char *vtysh_pager_name = NULL;

/* VTY should add timestamp */
int vtysh_add_timestamp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool and use vtysh_add_timestamp = true; or = false in the code instead of 1 and 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will do. I put them together b/c I saw them as a single enhancement which was "parallelize the support bundle collection", the commong_config.py runs the .py processes (per router) in parallel, the generate_support_bundle.py runs the vtysh's in parallel -- the glue was that the output is a support bundle. The enhancements also stand on their own though so --- ok. :)

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from 00f8069 to 02fda0f Compare June 29, 2021 22:06
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1673:64: E0602: Undefined variable 'unicode' (undefined-variable)

-----------------------------------
Your code has been rated at 9.97/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 29, 2021

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_ _
Result SUCCESS git merge/8939 02fda0f
Date 06/29/2021
Start 18:10:47
Finish 18:36:14
Run-Time 25:27
Total 1815
Pass 1814
Fail 1
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-29-18:10:47.txt
Log autoscript-2021-06-29-18:12:00.log.bz2
Memory 475 519 414

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 30, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19930/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 6
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 2
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 7
  • Addresssanitizer topotests part 3
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 4
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 4
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 3
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests debian 10 amd64 part 6
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 i386 part 2

@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from 02fda0f to d44ecba Compare June 30, 2021 09:06
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:353:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:430:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:511:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:554:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:958:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1184:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1296:4: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.41/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 30, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8939 d44ecba
Date 06/30/2021
Start 05:36:47
Finish 06:02:18
Run-Time 25:31
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-30-05:36:47.txt
Log autoscript-2021-06-30-05:38:01.log.bz2
Memory 521 497 431

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 30, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19942/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-19942/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8:

2021-06-30 11:12:07,071 ERROR: l1: bgpd left a dead pidfile (pid=16000)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19942/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 8: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Failed (click for details) Topotests Ubuntu 18.04 i386 part 8: No useful log found
Topotests debian 10 amd64 part 8: Failed (click for details) Topotests debian 10 amd64 part 8: No useful log found
Successful on other platforms/tests
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Ubuntu 18.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 6
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 9
  • Static analyzer (clang)
  • Addresssanitizer topotests part 1
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 6
  • Fedora 29 rpm pkg check

choppsv1 added 4 commits June 30, 2021 15:46
Signed-off-by: Christian Hopps <chopps@labn.net>
Example output:

    flk# show version
    % 2021/06/29 00:25:01.562

    FRRouting 8.1-dev-my-manual-build (flk).
    Copyright 1996-2005 Kunihiro Ishiguro, et al.

    ...

Signed-off-by: Christian Hopps <chopps@labn.net>
Speedup (large topo): OLD: ~6 minutes NEW: ~1 second.
  (when paired with common_config.py changes)
- Collect each "proc" support in parallel
- For each "proc" only call vtysh once with all commands

Bug fixes:
- output was broken, a dump of python "repr" format of str.

Signed-off-by: Christian Hopps <chopps@labn.net>
Speedup (large topo): OLD: ~6 minutes NEW: ~1 second
  (when paired with generate_support_bundle.py changes)
- Collect from each node in parallel

Bug fixes:
- sub-directory test name was the same internal pytest function name
  for any test, and not the actual test name.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1 choppsv1 force-pushed the chopps/sup-bund-fixes branch from d44ecba to 0ef5bf1 Compare June 30, 2021 15:46
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!


Pylint found errors in source files changed by this PR:

Pylint report for my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:
************* Module test_multicast_pim_sm_topo1
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:353:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:430:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:511:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:554:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:958:8: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1184:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/multicast_pim_sm_topo1/test_multicast_pim_sm_topo1.py:1296:4: E1305: Too many arguments for format string (too-many-format-args)

-----------------------------------
Your code has been rated at 9.41/10




If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 30, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8939 0ef5bf1
Date 06/30/2021
Start 12:23:53
Finish 12:49:21
Run-Time 25:28
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-30-12:23:53.txt
Log autoscript-2021-06-30-12:25:06.log.bz2
Memory 481 508 421

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19971/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@choppsv1 choppsv1 requested a review from donaldsharp July 2, 2021 15:33
@donaldsharp donaldsharp merged commit 432bb28 into FRRouting:master Jul 6, 2021
@choppsv1 choppsv1 deleted the chopps/sup-bund-fixes branch July 7, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix tests Topotests, make check, etc vtysh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants