Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 backports #8882

Merged
merged 9 commits into from
Jun 19, 2021
Merged

8.0 backports #8882

merged 9 commits into from
Jun 19, 2021

Conversation

idryzhov
Copy link
Contributor

No description provided.

sworleys and others added 9 commits June 18, 2021 16:59
Always terminate default VRF last during FRR shutdown.

On shutdown we were simply looping over the RB tree and terminating
VRFs from the ROOT. This is not guaranteed to be the default last ever.

Instead switch to RB_SAFE and skip the default VRF till the very end.

Signed-off-by: Stephen Worley <sworley@nvidia.com>
Signed-off-by: anlancs <anlan_cs@tom.com>
Currently, if the routemap already exists, we delete the pointer to it
when it is updated. We should delete the pointer only if the route-map
is actually deleted.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
When creating a new area, we're adding all circuits in the same VRF to
this area. We should only add circuits configured with the same tag.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
isis_circuit_enable can be called for an already enabled circuit. In this
case we would add the circuit to the area multiple times.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Currently, the dynamic hostname cache is global. It is incorrect because
neighbors in different VRFs may have the same system ID and different
hostnames.

This also fixes a memory leak - when the instance is deleted, the cache
must be cleaned up and the cleanup thread must be cancelled.

Fixes FRRouting#8832.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
- vnc_routemap_update is called only for the last bgp instance
- vpn_policy_routemap_event is not called at all
- unguarded debug (there's already a debug inside the called function)

Make the code consistent with the callback code that is used when the
delay timer is enabled.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
tini is a hyper-minimal PID 0 which spawns a child process (watchfrr.sh
in our case), reaps zombies and forwards signals to the script. Starting
watchfrr.sh directly instead of through the old `tail /dev/null` or
`sleep 365d` helps keep things clean too :)

While tini was previously only used in the Alpine container it is useful
to apply this PID 0 to all containers except the special CI ones.

Fixes: FRRouting#8788
Signed-off-by: Wesley Coakley <w@wesleycoakley.com>
At shutdown, try to stop the grpc module and its
dedicated pthread cleanly.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 19, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8882 eac07a3
Date 06/19/2021
Start 12:04:31
Finish 12:30:02
Run-Time 25:31
Total 1815
Pass 1815
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-06-19-12:04:31.txt
Log autoscript-2021-06-19-12:05:47.log.bz2
Memory 494 517 422

For details, please contact louberger

@idryzhov
Copy link
Contributor Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 19, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19703/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-19703/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:

2021-06-19 13:42:29,242 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-06-19 13:42:29,533 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-06-19 13:42:29,758 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-06-19 13:42:30,041 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-06-19 13:42:31,530 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-06-19 13:45:12,286 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Unknown command[4]: bgp large-community-list standard Test1 permit  


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/06/19 13:47:07 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/06/19 13:47:07 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/06/19 13:47:08 BGP: [T83RR-8SM5G] bgpd 8.0-dev-20210618-09-geac07a35b starting: vty@2605, bgp@10.0.0.1:179
2021/06/19 13:47:08 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 1000 

2021/06/19 13:47:11 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/06/19 13:47:11 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/06/19 13:47:11 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-06-19 13:47:13,390 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r1: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19703/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-19703/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7:

2021-06-19 13:31:12,653 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:12,653 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:12,908 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:12,908 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:13,073 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:13,074 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,261 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:29,261 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,496 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:29,496 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,675 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:29,675 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:45,837 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:45,838 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:46,081 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:46,081 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:46,263 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:46,264 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:00,648 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:32:00,648 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:00,873 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:32:00,873 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:01,135 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:32:01,135 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:17,623 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:32:17,623 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:17,804 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:32:17,804 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:18,033 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:32:18,033 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
r2 failed MPLS LDP neighbor output Check:
--- actual MPLS LDP neighbor output
+++ expected MPLS LDP neighbor output
@@ -1,2 +1,4 @@
 AF   ID              State       Remote Address    Uptime
 ipv4 1.1.1.1         OPERATIONAL 1.1.1.1         xx:xx:xx
+ipv4 3.3.3.3         OPERATIONAL 3.3.3.3         xx:xx:xx
+ipv4 4.4.4.4         OPERATIONAL 4.4.4.4         xx:xx:xx
2021-06-19 13:34:51,809 ERROR: assert failed at "test_ldp_topo1/test_mpls_ldp_neighbor": MPLS LDP Interface neighbor output for router r2:
  --- actual MPLS LDP neighbor output
  +++ expected MPLS LDP neighbor output
  @@ -1,2 +1,4 @@
   AF   ID              State       Remote Address    Uptime
   ipv4 1.1.1.1         OPERATIONAL 1.1.1.1         xx:xx:xx
  +ipv4 3.3.3.3         OPERATIONAL 3.3.3.3         xx:xx:xx
  +ipv4 4.4.4.4         OPERATIONAL 4.4.4.4         xx:xx:xx
assert 1 == 0
  -1
  +0
2021-06-19 13:35:50,409 ERROR: ce3: zebra left a dead pidfile (pid=13872)
2021-06-19 13:53:30,281 ERROR: r2: zebra left a dead pidfile (pid=32366)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19703/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 5
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 4
  • Static analyzer (clang)
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 amd64 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 2
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 6
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-19703/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4:

2021-06-19 13:42:29,242 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-06-19 13:42:29,533 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-06-19 13:42:29,758 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-06-19 13:42:30,041 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-06-19 13:42:31,530 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-06-19 13:45:12,286 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO4U18I386/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Unknown command[4]: bgp large-community-list standard Test1 permit  


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/06/19 13:47:07 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/06/19 13:47:07 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/06/19 13:47:08 BGP: [T83RR-8SM5G] bgpd 8.0-dev-20210618-09-geac07a35b starting: vty@2605, bgp@10.0.0.1:179
2021/06/19 13:47:08 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/06/19 13:47:11 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 1000 

2021/06/19 13:47:11 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/06/19 13:47:11 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/06/19 13:47:11 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-06-19 13:47:13,390 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r1: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19703/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-19703/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7:

2021-06-19 13:31:12,653 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:12,653 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:12,908 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:12,908 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:13,073 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:13,074 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,261 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:29,261 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,496 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:29,496 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:29,675 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:29,675 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:45,837 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:31:45,838 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:46,081 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:31:46,081 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:31:46,263 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:31:46,264 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:00,648 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:32:00,648 WARNING: {'1': {'r1-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:00,873 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Config, Active, Circuit Id: 0x0', ' Type: Unknown, Level: L1', ' Level-1 Information:', ' Metric: 16777214, Active neighbors: 0', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:32:00,873 WARNING: {'1': {'r2-eth1': [{'metric': '16777214', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:01,135 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:32:01,135 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:17,623 WARNING: ['Area 1:', ' Interface: r1-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.1/24', ' IPv6 Link-Locals:', ' fe80::d885:64ff:fe7d:53af/64', '', ' Interface: r1-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.1/24', ' IPv6 Link-Locals:', ' fe80::8c5:3dff:fe5b:1d42/64']
2021-06-19 13:32:17,623 WARNING: {'1': {'r1-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r1-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:17,804 WARNING: ['Area 1:', ' Interface: r2-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.1.2/24', ' IPv6 Link-Locals:', ' fe80::3c81:d8ff:fe2d:2443/64', '', ' Interface: r2-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.2/24', ' IPv6 Link-Locals:', ' fe80::8c50:18ff:fe40:4526/64']
2021-06-19 13:32:17,804 WARNING: {'1': {'r2-eth1': [{'metric': '10', 'level': 'Level-1'}], 'r2-eth2': [{'metric': '10', 'level': 'Level-1'}]}}
2021-06-19 13:32:18,033 WARNING: ['Area 1:', ' Interface: r3-eth1, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.2.3/24', ' IPv6 Link-Locals:', ' fe80::c48b:30ff:fe00:42d2/64', '', ' Interface: r3-eth2, State: Up, Active, Circuit Id: 0x0', ' Type: p2p, Level: L1', ' Level-1 Information:', ' Metric: 10, Active neighbors: 1', ' Hello interval: 3, Holddown count: 10 (pad)', ' CNSP interval: 10, PSNP interval: 2', ' IP Prefix(es):', ' 10.0.3.3/24', ' IPv6 Link-Locals:', ' fe80::2ce7:abff:feb7:711c/64']
2021-06-19 13:32:18,033 WARNING: {'1': {'r3-eth2': [{'metric': '10', 'level': 'Level-1'}], 'r3-eth1': [{'metric': '10', 'level': 'Level-1'}]}}
r2 failed MPLS LDP neighbor output Check:
--- actual MPLS LDP neighbor output
+++ expected MPLS LDP neighbor output
@@ -1,2 +1,4 @@
 AF   ID              State       Remote Address    Uptime
 ipv4 1.1.1.1         OPERATIONAL 1.1.1.1         xx:xx:xx
+ipv4 3.3.3.3         OPERATIONAL 3.3.3.3         xx:xx:xx
+ipv4 4.4.4.4         OPERATIONAL 4.4.4.4         xx:xx:xx
2021-06-19 13:34:51,809 ERROR: assert failed at "test_ldp_topo1/test_mpls_ldp_neighbor": MPLS LDP Interface neighbor output for router r2:
  --- actual MPLS LDP neighbor output
  +++ expected MPLS LDP neighbor output
  @@ -1,2 +1,4 @@
   AF   ID              State       Remote Address    Uptime
   ipv4 1.1.1.1         OPERATIONAL 1.1.1.1         xx:xx:xx
  +ipv4 3.3.3.3         OPERATIONAL 3.3.3.3         xx:xx:xx
  +ipv4 4.4.4.4         OPERATIONAL 4.4.4.4         xx:xx:xx
assert 1 == 0
  -1
  +0
2021-06-19 13:35:50,409 ERROR: ce3: zebra left a dead pidfile (pid=13872)
2021-06-19 13:53:30,281 ERROR: r2: zebra left a dead pidfile (pid=32366)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19703/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt

Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f1-20992/isis_misc.c:511:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#508: FILE: /tmp/f2-20992/isis_misc.c:508:
39c39
< #538: FILE: /tmp/f1-20992/isis_misc.c:538:

@donaldsharp donaldsharp merged commit 37b17d4 into FRRouting:dev/8.0 Jun 19, 2021
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19708/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#511: FILE: /tmp/f1-30891/isis_misc.c:511:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#508: FILE: /tmp/f2-30891/isis_misc.c:508:
39c39
< #538: FILE: /tmp/f1-30891/isis_misc.c:538:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants