-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several Alpine build issues related to ELF parsing #8491
Fix several Alpine build issues related to ELF parsing #8491
Conversation
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18434/ This is a comment from an automated CI system. |
I don't think this is related to this change (I mean, Alpine was broken before so this is a needed fix) but I get this on starting a built container now:
I can go in and inspect the container and see that /etc/frr is a regular file, not a directory.
The file is just an /etc/frr/daemons file
Just curious if you can build & run or if my docker is playing tricks with me. |
The correct package seems to be |
Right you are...couldn't find that anywhere |
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
'latest' isn't appropriate for us Signed-off-by: Quentin Young <qlyoung@nvidia.com>
3df81c2
to
9513086
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundSuccessful on other platforms/tests
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18453/ This is a comment from an automated CI system. |
Merging, since it was b0rked before this can't make it worse ;) |
Several issues:
libelf-dev
dependency was not added toAPKBUILD.in
for Alpine packaginglatest
tag, which is unstable and not appropriate for uslibelf-dev
is added, our FRR Alpine images no longer build becauselibelf-dev
hasn't been available in Alpine since 3.9; work around this by adding 3.9 Alpine repository to the 3.13 base image before building FRRFixes: #8489