docker: prefer CMD to ENTRYPOINT for flexibility #8482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesl-ee
force-pushed
the
docker-prefer-cmd-to-entrypoint
branch
from
b000da8 to
76df05d
Compare
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18405/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundSuccessful on other platforms/tests
|
|
ci:rerun |
wesl-ee
force-pushed
the
docker-prefer-cmd-to-entrypoint
branch
from
76df05d to
42d723d
Compare
|
Missed |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18418/ This is a comment from an automated CI system. |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-18428/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18428/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
qlyoung
approved these changes
Apr 15, 2021
|
|
Specifying watchfrr as CMD instead of ENTRYPOINT allows one to easily override this command when starting a docker container. This allows simple, manual testing via (e.g.) bash. With ENTRYPOINT only the container will simply explode with an exit code if watchfrr exits. For instance one could start a shell session in this container via: ``` docker run --name test --rm -i -t <frr-container> bash ``` The default behavior (`docker run <frr-container>` with no command specified) is not changed. Signed-off-by: Wesley Coakley <wcoakley@nvidia.com>
wesl-ee
force-pushed
the
docker-prefer-cmd-to-entrypoint
branch
from
42d723d to
3a33be1
Compare
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18442/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying watchfrr in Dockerfiles as CMD instead of ENTRYPOINT allows one to easily override the watchfrr command when starting a docker container. This allows simple, manual testing via (e.g.) bash. With ENTRYPOINT only the container will simply explode with an exit code if watchfrr exits.
If you tried to do this before you'd see this from
docker ps:Which shows that /usr/lib/frr/docker-start (a wrapper around frrinit.sh) tried to start frrinit.sh with the
bashparameter which clearly won't do anything. Now, one could start a shell session in this container via:The default behavior (
docker run <frr-container>with no command specified) is not changed.