lib: preparations for RFC5424 syslog support #8457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
reviewed
Apr 13, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/9c4b0cb89b2d22f93413f014a60ac28b/raw/78502b2b184e4442536ea67fd638afd87f67c2cf/cr_8457_1618272570.diff | git apply
diff --git a/lib/log_vty.c b/lib/log_vty.c
index 69b155be2..860d13a57 100644
--- a/lib/log_vty.c
+++ b/lib/log_vty.c
@@ -596,13 +596,8 @@ DEFUN (no_config_log_filterfile,
return CMD_SUCCESS;
}
-DEFPY (log_filter,
- log_filter_cmd,
- "[no] log filter-text WORD$filter",
- NO_STR
- "Logging control\n"
- FILTER_LOG_STR
- "String to filter by\n")
+DEFPY(log_filter, log_filter_cmd, "[no] log filter-text WORD$filter",
+ NO_STR "Logging control\n" FILTER_LOG_STR "String to filter by\n")
{
int ret = 0;
@@ -625,24 +620,16 @@ DEFPY (log_filter,
}
/* Clear all log filters */
-DEFPY (log_filter_clear,
- log_filter_clear_cmd,
- "clear log filter-text",
- CLEAR_STR
- "Logging control\n"
- FILTER_LOG_STR)
+DEFPY(log_filter_clear, log_filter_clear_cmd, "clear log filter-text",
+ CLEAR_STR "Logging control\n" FILTER_LOG_STR)
{
zlog_filter_clear();
return CMD_SUCCESS;
}
/* Show log filter */
-DEFPY (show_log_filter,
- show_log_filter_cmd,
- "show logging filter-text",
- SHOW_STR
- "Show current logging configuration\n"
- FILTER_LOG_STR)
+DEFPY(show_log_filter, show_log_filter_cmd, "show logging filter-text",
+ SHOW_STR "Show current logging configuration\n" FILTER_LOG_STR)
{
char log_filters[ZLOG_FILTERS_MAX * (ZLOG_FILTER_LENGTH_MAX + 3)] = "";
int len = 0;
diff --git a/lib/zlog_targets.c b/lib/zlog_targets.c
index 8c609c907..708f341ee 100644
--- a/lib/zlog_targets.c
+++ b/lib/zlog_targets.c
@@ -120,8 +120,7 @@ void zlog_fd(struct zlog_target *zt, struct zlog_msg *msgs[], size_t nmsgs)
* - this being the last message in the batch
* - not enough remaining iov entries
*/
- if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN
- || i + 1 == nmsgs
+ if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN || i + 1 == nmsgs
|| array_size(iov) - iovpos < 5) {
writev(fd, iov, iovpos);
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
|
9a684f0 is breaking CI, investigating. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-18356/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 16.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1604I386-18356/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TP4U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-18356/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U16I386-18356/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TOPO9U16I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-18356/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests Ubuntu 16.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1604I386-18356/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TP4U1604I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-18356/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 16.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U16I386-18356/test Topology Tests failed for Topotests Ubuntu 16.04 i386 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18356/artifact/TOPO9U16I386/ErrorLog/log_topotests.txt |
polychaeta
reviewed
Apr 19, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/84ee0ae4e4c81ed1ccb29a324c13d44d/raw/5b121f30e409463cbcf12738149f48def3bb34ca/cr_8457_1618831302.diff | git apply
diff --git a/lib/log_vty.c b/lib/log_vty.c
index 1cf90697c..fb8ac1ef8 100644
--- a/lib/log_vty.c
+++ b/lib/log_vty.c
@@ -596,13 +596,8 @@ DEFUN (no_config_log_filterfile,
return CMD_SUCCESS;
}
-DEFPY (log_filter,
- log_filter_cmd,
- "[no] log filter-text WORD$filter",
- NO_STR
- "Logging control\n"
- FILTER_LOG_STR
- "String to filter by\n")
+DEFPY(log_filter, log_filter_cmd, "[no] log filter-text WORD$filter",
+ NO_STR "Logging control\n" FILTER_LOG_STR "String to filter by\n")
{
int ret = 0;
@@ -625,24 +620,16 @@ DEFPY (log_filter,
}
/* Clear all log filters */
-DEFPY (log_filter_clear,
- log_filter_clear_cmd,
- "clear log filter-text",
- CLEAR_STR
- "Logging control\n"
- FILTER_LOG_STR)
+DEFPY(log_filter_clear, log_filter_clear_cmd, "clear log filter-text",
+ CLEAR_STR "Logging control\n" FILTER_LOG_STR)
{
zlog_filter_clear();
return CMD_SUCCESS;
}
/* Show log filter */
-DEFPY (show_log_filter,
- show_log_filter_cmd,
- "show logging filter-text",
- SHOW_STR
- "Show current logging configuration\n"
- FILTER_LOG_STR)
+DEFPY(show_log_filter, show_log_filter_cmd, "show logging filter-text",
+ SHOW_STR "Show current logging configuration\n" FILTER_LOG_STR)
{
char log_filters[ZLOG_FILTERS_MAX * (ZLOG_FILTER_LENGTH_MAX + 3)] = "";
int len = 0;
diff --git a/lib/zlog_targets.c b/lib/zlog_targets.c
index 8c609c907..708f341ee 100644
--- a/lib/zlog_targets.c
+++ b/lib/zlog_targets.c
@@ -120,8 +120,7 @@ void zlog_fd(struct zlog_target *zt, struct zlog_msg *msgs[], size_t nmsgs)
* - this being the last message in the batch
* - not enough remaining iov entries
*/
- if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN
- || i + 1 == nmsgs
+ if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN || i + 1 == nmsgs
|| array_size(iov) - iovpos < 5) {
writev(fd, iov, iovpos);
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18476/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsCLANG Static Analyzer Summary
6 Static Analyzer issues remaining.See details at |
|
This should be ready to go now. No idea what to do about the Travis CI thing, the log just stops and even with logging in with my github account I can't click rerun on it (HTTP 403, so I'm missing some permissions?) |
|
Also the first commit in this series is kinda high priority, while I haven't seen people run into the |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
polychaeta
reviewed
Apr 20, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/7680eeeed969fed813ea5cec436a5f5d/raw/5b121f30e409463cbcf12738149f48def3bb34ca/cr_8457_1618919822.diff | git apply
diff --git a/lib/log_vty.c b/lib/log_vty.c
index 1cf90697c..fb8ac1ef8 100644
--- a/lib/log_vty.c
+++ b/lib/log_vty.c
@@ -596,13 +596,8 @@ DEFUN (no_config_log_filterfile,
return CMD_SUCCESS;
}
-DEFPY (log_filter,
- log_filter_cmd,
- "[no] log filter-text WORD$filter",
- NO_STR
- "Logging control\n"
- FILTER_LOG_STR
- "String to filter by\n")
+DEFPY(log_filter, log_filter_cmd, "[no] log filter-text WORD$filter",
+ NO_STR "Logging control\n" FILTER_LOG_STR "String to filter by\n")
{
int ret = 0;
@@ -625,24 +620,16 @@ DEFPY (log_filter,
}
/* Clear all log filters */
-DEFPY (log_filter_clear,
- log_filter_clear_cmd,
- "clear log filter-text",
- CLEAR_STR
- "Logging control\n"
- FILTER_LOG_STR)
+DEFPY(log_filter_clear, log_filter_clear_cmd, "clear log filter-text",
+ CLEAR_STR "Logging control\n" FILTER_LOG_STR)
{
zlog_filter_clear();
return CMD_SUCCESS;
}
/* Show log filter */
-DEFPY (show_log_filter,
- show_log_filter_cmd,
- "show logging filter-text",
- SHOW_STR
- "Show current logging configuration\n"
- FILTER_LOG_STR)
+DEFPY(show_log_filter, show_log_filter_cmd, "show logging filter-text",
+ SHOW_STR "Show current logging configuration\n" FILTER_LOG_STR)
{
char log_filters[ZLOG_FILTERS_MAX * (ZLOG_FILTER_LENGTH_MAX + 3)] = "";
int len = 0;
diff --git a/lib/zlog_targets.c b/lib/zlog_targets.c
index 8c609c907..708f341ee 100644
--- a/lib/zlog_targets.c
+++ b/lib/zlog_targets.c
@@ -120,8 +120,7 @@ void zlog_fd(struct zlog_target *zt, struct zlog_msg *msgs[], size_t nmsgs)
* - this being the last message in the batch
* - not enough remaining iov entries
*/
- if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN
- || i + 1 == nmsgs
+ if (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN || i + 1 == nmsgs
|| array_size(iov) - iovpos < 5) {
writev(fd, iov, iovpos);
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-18505/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18505/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Addresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-18505/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18505/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Addresssanitizer topotests part 7: Incomplete(check logs for details)Addresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-18505/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18505/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Addresssanitizer topotests part 8: Incomplete(check logs for details)Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-18505/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18505/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Addresssanitizer topotests part 7: Incomplete(check logs for details)Addresssanitizer topotests part 5: Incomplete(check logs for details)Successful on other platforms/tests
|
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 8: Incomplete(check logs for details)Addresssanitizer topotests part 8: Incomplete(check logs for details)Addresssanitizer topotests part 7: Incomplete(check logs for details)Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18505/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsCLANG Static Analyzer Summary
6 Static Analyzer issues remaining.See details at |
If the last message in a batched logging operation isn't printed due to priority, this skips the code that flushes prepared messages through writev() and can trigger the assert() at the end of zlog_fd(). Since any logmsg above info priority triggers a buffer flush, running into this situation requires a log file target configured for info priority, at least 1 message of info priority buffered, a debug message buffered after that, and then a buffer flush (explicit or due to buffer full). I haven't seen this chain of events happen in the wild, but it needs fixing anyway. Signed-off-by: David Lamparter <equinox@diac24.net>
The (legacy) code for reading split configs tries to execute config commands in parent nodes, but doesn't call the node_exit function when it goes up to a parent node. This breaks BGP RPKI setup (and extended syslog, which is in the next commit.) Doing this correctly is a slight bit involved since the node_exit callbacks should only be called if the command is actually executed on a parent node. Signed-off-by: David Lamparter <equinox@diac24.net>
`log-filter WORD` was giving me a serious headache since it also matches `log WORD` due to the way the CLI token handling works. This meant that a mistyped `log something` command would silently be interpreted as a filter string, causing me serious headscratching and WTFs until I figured what was going on. Remove this UX pitfall so noone else falls into it. (Since the command was never saved to config, renaming it shouldn't cause trouble.) [Also I apparently forgot to update the docs when I transferred this over to the new zlog bits...] TODO for a rainy day: since we collect all the CLI commands anyway, we should warn somewhere for "2nd level ambiguous" commands like this. Signed-off-by: David Lamparter <equinox@diac24.net>
... so additional targets can print their state. Signed-off-by: David Lamparter <equinox@diac24.net>
printfrr() recently acquired the capability to record start/end of formatting outputs. Make use of this in the zlog code so logging targets have access to this information. (This also records how long the `[XXXXX-XXXXX][EC 9999999]` prefix was so log targets can choose to skip over it.) Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
This is old-style syslog, used among other things for /dev/log. Signed-off-by: David Lamparter <equinox@diac24.net>
Since the file targets append one anyway, save them some extra work. syslog can use `%.*s` since it's "forced" printf by API anyway. Signed-off-by: David Lamparter <equinox@diac24.net>
glibc removed its pid cache a while back, and grabbing this from TLS is faster than repeatedly calling the kernel... Also use `intmax_t` which is more appropriate for both PID & TID. Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
Might've made a few things too many `static` there. Signed-off-by: David Lamparter <equinox@diac24.net>
*sigh*. It doesn't accept `%m` otherwise. Signed-off-by: David Lamparter <equinox@diac24.net>
polychaeta
reviewed
Apr 21, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/5b51414332bc23ce624dc0ab699a727b/raw/3d0b8ad34097d1a05813ef98253dcb20d7c6e30f/cr_8457_1619015291.diff | git apply
diff --git a/lib/log_vty.c b/lib/log_vty.c
index 1cf90697c..fb8ac1ef8 100644
--- a/lib/log_vty.c
+++ b/lib/log_vty.c
@@ -596,13 +596,8 @@ DEFUN (no_config_log_filterfile,
return CMD_SUCCESS;
}
-DEFPY (log_filter,
- log_filter_cmd,
- "[no] log filter-text WORD$filter",
- NO_STR
- "Logging control\n"
- FILTER_LOG_STR
- "String to filter by\n")
+DEFPY(log_filter, log_filter_cmd, "[no] log filter-text WORD$filter",
+ NO_STR "Logging control\n" FILTER_LOG_STR "String to filter by\n")
{
int ret = 0;
@@ -625,24 +620,16 @@ DEFPY (log_filter,
}
/* Clear all log filters */
-DEFPY (log_filter_clear,
- log_filter_clear_cmd,
- "clear log filter-text",
- CLEAR_STR
- "Logging control\n"
- FILTER_LOG_STR)
+DEFPY(log_filter_clear, log_filter_clear_cmd, "clear log filter-text",
+ CLEAR_STR "Logging control\n" FILTER_LOG_STR)
{
zlog_filter_clear();
return CMD_SUCCESS;
}
/* Show log filter */
-DEFPY (show_log_filter,
- show_log_filter_cmd,
- "show logging filter-text",
- SHOW_STR
- "Show current logging configuration\n"
- FILTER_LOG_STR)
+DEFPY(show_log_filter, show_log_filter_cmd, "show logging filter-text",
+ SHOW_STR "Show current logging configuration\n" FILTER_LOG_STR)
{
char log_filters[ZLOG_FILTERS_MAX * (ZLOG_FILTER_LENGTH_MAX + 3)] = "";
int len = 0;
diff --git a/lib/zlog_targets.c b/lib/zlog_targets.c
index 48785ad29..ba0a54e20 100644
--- a/lib/zlog_targets.c
+++ b/lib/zlog_targets.c
@@ -120,9 +120,9 @@ void zlog_fd(struct zlog_target *zt, struct zlog_msg *msgs[], size_t nmsgs)
* - this being the last message in the batch
* - not enough remaining iov entries
*/
- if (iovpos > 0 && (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN
- || i + 1 == nmsgs
- || array_size(iov) - iovpos < 5)) {
+ if (iovpos > 0
+ && (ts_buf + sizeof(ts_buf) - ts_pos < TS_LEN
+ || i + 1 == nmsgs || array_size(iov) - iovpos < 5)) {
writev(fd, iov, iovpos);
iovpos = 0;
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18530/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsCLANG Static Analyzer Summary
6 Static Analyzer issues remaining.See details at |
|
reopening PR in an attempt to breathe life into this 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all the preparatory commits for the upcoming RFC5424 PR which I'll open in a minute. This is split off because everything here should be ready to go regardless of polishing or adjustments on the RFC5424 bits.
The first 2 commits
lib: fix possible assert() fail in zlog_fd()(c239e0b)lib: correctly exit CLI nodes on file config load(9a684f0)also need to be applied on 7.5 & 7.4. (The second one is kinda "meh", but the first one is a bit more "narf".)