staticd: forbid blackhole and non-blackhole nexthops in a single route #8158

idryzhov · 2021-02-26T15:34:29Z

PIM test will probably fail, because it is using such nexthops.
This PR will be rebased on top of #8157 once it's merged.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/c09c48fa471f3f21f4524f9f48ec34b0/raw/7f866fd1ab8bb77a3ea29e73ece256060223bff1/cr_8158_1614353672.diff | git apply

diff --git a/staticd/static_nb_config.c b/staticd/static_nb_config.c
index 5f61c7d40..db154992f 100644
--- a/staticd/static_nb_config.c
+++ b/staticd/static_nb_config.c
@@ -155,10 +155,12 @@ static bool static_nexthop_create(struct nb_cb_create_args *args,
 		iter.blackhole = false;
 
 		pn_dnode = yang_dnode_get_parent(args->dnode, "path-list");
-		yang_dnode_iterate(nexthop_iter_cb, &iter, pn_dnode, "./frr-nexthops/nexthop");
+		yang_dnode_iterate(nexthop_iter_cb, &iter, pn_dnode,
+				   "./frr-nexthops/nexthop");
 
 		if (iter.blackhole && iter.count > 1) {
-			snprintf(args->errmsg, args->errmsg_len,
+			snprintf(
+				args->errmsg, args->errmsg_len,
 				"Route can not have blackhole and non-blackhole nexthops simultaneously");
 			return NB_ERR_VALIDATION;
 		}

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2021-02-26T16:15:02Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8158 `23af0e3`
Date	02/26/2021
Start	10:35:41
Finish	11:15:00
Run-Time	39:19
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-26-10:35:41.txt
Log	autoscript-2021-02-26-10:36:44.log.bz2
Memory	484 493 427

For details, please contact louberger

donaldsharp · 2021-02-26T18:07:23Z

LGTM

NetDEF-CI · 2021-02-26T18:48:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 16.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16I386-17337/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 8:

2021-02-26 17:10:16,665 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 17:10:16,667 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/to...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U16I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 16.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16AMD64-17337/test

Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 8:

2021-02-26 17:10:21,754 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 17:10:21,755 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U16AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-17337/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8:

2021-02-26 16:10:10,023 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 16:10:10,026 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17337/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:

*** defaultIntf: warning: r1 has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 16.04 amd64 part 6
Addresssanitizer topotests part 1
Debian 8 deb pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 0
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 16.04 i386 part 1
Topotests Ubuntu 16.04 i386 part 4
Addresssanitizer topotests part 6
Topotests Ubuntu 16.04 i386 part 6
Topotests Ubuntu 16.04 amd64 part 5
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 2
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 16.04 amd64 part 9
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 4
Debian 10 deb pkg check
Topotests Ubuntu 16.04 i386 part 3
Topotests Ubuntu 16.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 9
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 7
Topotests Ubuntu 16.04 i386 part 5
Static analyzer (clang)
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Topotests Ubuntu 16.04 amd64 part 2
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 16.04 i386 part 7
CentOS 7 rpm pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 16.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16I386-17337/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 8:

2021-02-26 17:10:16,665 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 17:10:16,667 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/to...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U16I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 16.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16AMD64-17337/test

Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 8:

2021-02-26 17:10:21,754 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 17:10:21,755 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U16AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 6: No useful log found

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-17337/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8:

2021-02-26 16:10:10,023 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 

% Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 16:10:10,026 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 2: Failure to communicate[13] to staticd, line: ip route 1.1.2.7/32 blackhole 
  
  % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17337/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:

*** defaultIntf: warning: r1 has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17337/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Report for static_nb_config.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #384: FILE: /tmp/f1-32731/static_nb_config.c:384:

NetDEF-CI · 2021-02-26T20:51:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17345/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 6: No useful log found

Topotests Ubuntu 16.04 i386 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16I386-17345/test

Topology Tests failed for Topotests Ubuntu 16.04 i386 part 8:

2021-02-26 18:46:04,207 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 18:46:04,208 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16I386/to...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17345/artifact/TOPO8U16I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Topotests Ubuntu 16.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U16AMD64-17345/test

Topology Tests failed for Topotests Ubuntu 16.04 amd64 part 8:

2021-02-26 18:46:36,120 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 18:46:36,124 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U16AMD64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17345/artifact/TOPO8U16AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-17345/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8:

2021-02-26 17:54:33,977 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
    tgen, router, static_routes_list, "static_route", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Configuration failed.

Error type: validation
Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 



2021-02-26 17:54:33,983 ERROR: assert failed at "test_mcast_pim_bsmp_01/test_BSR_CRP_with_blackhole_address_p1": Testcase test_BSR_CRP_with_blackhole_address_p1 :Failed 
   Error Traceback (most recent call last):
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 1808, in create_static_routes
      tgen, router, static_routes_list, "static_route", build=build
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 290, in create_common_configuration
      load_config_to_router(tgen, router)
    File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/topotests/lib/common_config.py", line 576, in load_config_to_router
      raise InvalidCLIError("%s" % output)
  InvalidCLIError: % Configuration failed.
  
  Error type: validation
  Error description: Route can not have blackhole and non-blackhole nexthops simultaneously
  line 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole 
  
  
  
assert 'Traceback (most recent call last):\n  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO8U18ARM64/t...imultaneously\r\nline 3: Failure to communicate[13] to staticd, line: ip route 210.210.210.210/32 blackhole \r\n\r\n\n' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17345/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17345/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:

*** defaultIntf: warning: r1 has no interfaces
2021-02-26 17:55:15,164 ERROR: r2: bgpd left a dead pidfile (pid=19030)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17345/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 1
Topotests Ubuntu 16.04 amd64 part 6
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 16.04 i386 part 1
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 6
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 5
Debian 8 deb pkg check
Topotests Ubuntu 16.04 i386 part 9
Topotests Ubuntu 16.04 amd64 part 0
Topotests Ubuntu 16.04 i386 part 4
Debian 9 deb pkg check
Topotests Ubuntu 16.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 16.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 16.04 i386 part 0
Topotests Ubuntu 16.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 4
Topotests Ubuntu 16.04 i386 part 6
Debian 10 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 2
Fedora 29 rpm pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 16.04 i386 part 5
Topotests Ubuntu 16.04 amd64 part 4
Topotests Ubuntu 16.04 amd64 part 5
Topotests Ubuntu 16.04 amd64 part 3
Topotests Ubuntu 16.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 7
Topotests Ubuntu 16.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 5
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Addresssanitizer topotests part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 1
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 16.04 amd64 part 2

LabN-CI · 2021-02-26T20:58:50Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8158 `0e7644a`
Date	02/26/2021
Start	15:19:25
Finish	15:58:47
Run-Time	39:22
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-02-26-15:19:25.txt
Log	autoscript-2021-02-26-15:20:31.log.bz2
Memory	494 504 428

For details, please contact louberger

1. There were few tests where routes were configured with blackhole and non-blackhole nexthops simultaneously, enhanced tests accordingly and verified in master branch and with PR FRRouting#8158 changes. Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>

tests: Fix for test failure in PR #8158

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

LabN-CI · 2021-03-03T16:29:19Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/8158 `cd07806`
Date	03/03/2021
Start	10:49:58
Finish	11:29:16
Run-Time	39:18
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-03-03-10:49:58.txt
Log	autoscript-2021-03-03-10:51:01.log.bz2
Memory	496 496 428

For details, please contact louberger

NetDEF-CI · 2021-03-03T18:37:31Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17449/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

riw777

looks good

polychaeta added the staticd label Feb 26, 2021

polychaeta reviewed Feb 26, 2021

View reviewed changes

idryzhov force-pushed the staticd-fix-blackhole branch from 23af0e3 to 0e7644a Compare February 26, 2021 17:13

riw777 self-requested a review March 2, 2021 16:47

kuldeepkash mentioned this pull request Mar 2, 2021

tests: Fix for test failure in PR #8158 #8183

Merged

idryzhov added a commit that referenced this pull request Mar 3, 2021

Merge pull request #8183 from kuldeepkash/multicast_pim_bsm

f60e5fd

tests: Fix for test failure in PR #8158

staticd: forbid blackhole and non-blackhole nexthops in a single route

cd07806

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

idryzhov force-pushed the staticd-fix-blackhole branch from 0e7644a to cd07806 Compare March 3, 2021 15:06

rzalamena approved these changes Mar 5, 2021

View reviewed changes

riw777 approved these changes Mar 9, 2021

View reviewed changes

riw777 merged commit 955ee64 into FRRouting:master Mar 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

staticd: forbid blackhole and non-blackhole nexthops in a single route #8158

staticd: forbid blackhole and non-blackhole nexthops in a single route #8158

idryzhov commented Feb 26, 2021

polychaeta left a comment

LabN-CI commented Feb 26, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

donaldsharp commented Feb 26, 2021

NetDEF-CI commented Feb 26, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Feb 26, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

LabN-CI commented Feb 26, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Mar 3, 2021

NetDEF-CI commented Mar 3, 2021

riw777 left a comment

staticd: forbid blackhole and non-blackhole nexthops in a single route #8158

staticd: forbid blackhole and non-blackhole nexthops in a single route #8158

Conversation

idryzhov commented Feb 26, 2021

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Feb 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

donaldsharp commented Feb 26, 2021

NetDEF-CI commented Feb 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Feb 26, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

LabN-CI commented Feb 26, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Mar 3, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 3, 2021

Continuous Integration Result: SUCCESSFUL

riw777 left a comment

Choose a reason for hiding this comment

LabN-CI commented Feb 26, 2021 •

edited

Loading

NetDEF-CI commented Feb 26, 2021 •

edited

Loading

NetDEF-CI commented Feb 26, 2021 •

edited

Loading

LabN-CI commented Feb 26, 2021 •

edited

Loading