Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: builder fixups #7890

Merged
merged 2 commits into from
Jan 23, 2021
Merged

docker: builder fixups #7890

merged 2 commits into from
Jan 23, 2021

Conversation

wesl-ee
Copy link
Contributor

@wesl-ee wesl-ee commented Jan 20, 2021

Just some housekeeping for our Docker containers, fixing issues I found while building our Docker containers for use in network simulation:

  1. Use alpine:latest instead of alpine:edge tag for Alpine builds, as edge was causing automake failures
  2. Exclude use of edge package repository in Alpine builder for above reason (they have had libyang 1.0.84 for some time in the community branch so use that)
  3. Update the CentOS 7, 8 containers to use libyang 1.0.84 as well (was 0.16.111 before)
  4. CentOS PowerTools repository was recently renamed to powertools so use that instead because that made the whole builder fail

I've verified that the containers now build on all my machines, albeit these are all Gentoo boxes 🙂

ton31337
ton31337 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 20, 2021 •
edited
Loading

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/7890 bba8e92
Date 01/20/2021
Start 05:25:36
Finish 06:04:48
Run-Time 39:12
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-01-20-05:25:36.txt
Log autoscript-2021-01-20-05:26:34.log.bz2
Memory 497 504 427

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 20, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16599/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 3 on Ubuntu 18.04 arm8: Failed (click for details) Topo tests part 3 on Ubuntu 18.04 arm8: No useful log found
Successful on other platforms/tests
  • Topo tests part 2 on Ubuntu 18.04 arm8
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Topo tests part 0 on Ubuntu 18.04 amd64
  • Debian 10 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 4 on Ubuntu 16.04 i386
  • Topo tests part 0 on Ubuntu 18.04 arm8
  • Topo tests part 1 on Ubuntu 16.04 i386
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 0
  • Debian 9 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 i386
  • Topo tests part 1 on Ubuntu 18.04 amd64
  • Topo tests part 3 on Ubuntu 16.04 i386
  • Static analyzer (clang)
  • Topo tests part 4 on Ubuntu 18.04 arm8
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 2
  • Topo tests part 4 on Ubuntu 16.04 amd64
  • Topo tests part 1 on Ubuntu 16.04 amd64
  • Fedora 29 rpm pkg check
  • Topo tests part 3 on Ubuntu 18.04 amd64
  • Debian 8 deb pkg check
  • Topo tests part 4 on Ubuntu 18.04 amd64
  • IPv4 protocols on Ubuntu 18.04
  • Topo tests part 0 on Ubuntu 16.04 amd64
  • Topo tests part 3 on Ubuntu 16.04 amd64
  • Topo tests part 1 on Ubuntu 18.04 arm8

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16599/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1

@ton31337
Copy link
Member

ci:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jan 21, 2021 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16609/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 3 on Ubuntu 18.04 arm8: Failed (click for details) Topo tests part 3 on Ubuntu 18.04 arm8: No useful log found
Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-16609/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64:

2021-01-21 10:24:33,059 ERROR: r4: bgpd left a dead pidfile (pid=19417)
2021-01-21 10:28:12,597 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 2416, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 289, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-01-21 10:28:12,730 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 2416, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 289, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-01-21 10:28:12,867 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 2416, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 289, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-01-21 10:28:13,004 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 2416, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 289, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 575, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-01-21 10:30:51,295 ERROR: assert failed at "bgp_large_community.test_bgp_large_community_topo_2/test_large_community_lists_with_no_send_community": Testcase test_large_community_lists_with_no_send_community : Failed 
   Error: True
assert True is not True
2021-01-21 10:46:49,217 ERROR: assert failed at "test_bgp_multi_vrf_topo2/test_delete_and_re_add_vrf_p1": Testcase test_delete_and_re_add_vrf_p1 :Failed 
   Error Missing route in RIB of router r2, routes: ['1.1.1.1/32', '1.1.1.2/32']
  
assert "Missing route in RIB of router r2, routes: ['1.1.1.1/32', '1.1.1.2/32']\n" is True
2021-01-21 10:48:13,350 ERROR: assert failed at "test_bgp_multi_vrf_topo2/test_vrf_name_significance_p1": Testcase test_vrf_name_significance_p1 :Failed 
   Error Missing route in RIB of router red2, routes: ['1.1.1.1/32', '1.1.1.2/32']
  
assert "Missing route in RIB of router red2, routes: ['1.1.1.1/32', '1.1.1.2/32']\n" is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16609/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topo tests part 4 on Ubuntu 16.04 i386
  • Debian 9 deb pkg check
  • Topo tests part 0 on Ubuntu 18.04 arm8
  • Topo tests part 3 on Ubuntu 16.04 i386
  • Static analyzer (clang)
  • Topo tests part 4 on Ubuntu 18.04 amd64
  • Topo tests part 2 on Ubuntu 18.04 arm8
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Topo tests part 0 on Ubuntu 18.04 amd64
  • Ubuntu 18.04 deb pkg check
  • Topo tests part 1 on Ubuntu 18.04 amd64
  • Ubuntu 20.04 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 i386
  • Topo tests part 4 on Ubuntu 18.04 arm8
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Addresssanitizer topotests part 2
  • Fedora 29 rpm pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topo tests part 1 on Ubuntu 18.04 arm8
  • Topo tests part 3 on Ubuntu 18.04 amd64
  • Topo tests part 1 on Ubuntu 16.04 amd64
  • IPv6 protocols on Ubuntu 18.04
  • Topo tests part 1 on Ubuntu 16.04 i386
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 4 on Ubuntu 16.04 amd64
  • Topo tests part 3 on Ubuntu 16.04 amd64
  • Debian 8 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 amd64

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16609/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210120-01-gbba8e92ac-0 (missing) -> 7.6-dev-20210120-01-gbba8e92ac-0~deb10u1

@ton31337
Copy link
Member

@wesleycoakley please rebase to the latest master, lots have been fixed regarding CI.

Wesley Coakley added 2 commits January 22, 2021 07:32
docker: prefer alpine:latest for building
56518fa 
Building with alpine:edge caused some weirdness with our build
scripts, switching to the stable branch seems to have aleviated this.

We can also ditch the "edge" repositories as the main and community
repositories provide all packages we need

Signed-off-by: Wesley Coakley <wcoakley@nvidia.com>
docker: centos 7, 8 yang bump and repo fixes
5fc9775 
Bump libyang version in centos containers to 1.0.184 and (1) change
"PowerTools" repository to "powertools" to accomodate CentOS Stream
changes

(1) https://bugs.centos.org/view.php?id=17920

Signed-off-by: Wesley Coakley <wcoakley@nvidia.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 22, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/7890 5fc9775
Date 01/22/2021
Start 08:10:35
Finish 08:49:49
Run-Time 39:14
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-01-22-08:10:35.txt
Log autoscript-2021-01-22-08:11:34.log.bz2
Memory 492 500 426

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16636/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16636/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210122-02-g5fc977513-0 (missing) -> 7.6-dev-20210122-02-g5fc977513-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210122-02-g5fc977513-0 (missing) -> 7.6-dev-20210122-02-g5fc977513-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210122-02-g5fc977513-0 (missing) -> 7.6-dev-20210122-02-g5fc977513-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210122-02-g5fc977513-0 (missing) -> 7.6-dev-20210122-02-g5fc977513-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210122-02-g5fc977513-0 (missing) -> 7.6-dev-20210122-02-g5fc977513-0~deb10u1

@ton31337 ton31337 merged commit e1b49f5 into FRRouting:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wesl-ee @LabN-CI @NetDEF-CI @ton31337 @polychaeta