[RFC] zebra: add option to specify interfaces to work with #7659

idryzhov · 2020-12-02T17:42:50Z

This PR introduces a new option -I/--interfaces for zebra, which allows
user to tell zebra to work only with specific interfaces.

The option itself is a list of patterns to match interface names. It allows using
an asterisk (*) to match any symbols and a hyphen (-) to block interfaces
that match the pattern. Patterns are checked in a specified order. There is an
implicit "block any" (-*) rule at the end.

Examples:

To allow only names starting with "eth": -I eth*
To allow all names except starting with "ens": -I -ens*,*

This currently works only with netlink-based kernel communication as I don't
have any OS other than Linux.

If the idea is accepted by the community, I will add the docs.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/d3c2167b19e2b727bb4bfcc7afcbcb4b/raw/a8709bd228476c5c34f3aa7703dd5ee474f02c58/cr_7659_1606930975.diff | git apply

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index c5221a429..6178c567b 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -784,8 +784,7 @@ static int netlink_interface(struct nlmsghdr *h, ns_id_t ns_id, int startup)
 
 	if (!zebra_if_allowed(name)) {
 		if (IS_ZEBRA_DEBUG_KERNEL)
-			zlog_debug("%s: ignoring interface %s",
-				   __func__, name);
+			zlog_debug("%s: ignoring interface %s", __func__, name);
 		return 0;
 	}
 
@@ -1452,8 +1451,9 @@ int netlink_link_change(struct nlmsghdr *h, ns_id_t ns_id, int startup)
 
 				if (!zebra_if_allowed(name)) {
 					if (IS_ZEBRA_DEBUG_KERNEL)
-						zlog_debug("%s: ignoring interface %s",
-							   __func__, name);
+						zlog_debug(
+							"%s: ignoring interface %s",
+							__func__, name);
 					return 0;
 				}
 
diff --git a/zebra/interface.c b/zebra/interface.c
index dda48c7ba..ff8aa1ae4 100644
--- a/zebra/interface.c
+++ b/zebra/interface.c
@@ -299,31 +299,30 @@ void if_unlink_per_ns(struct interface *ifp)
 
 bool zebra_if_allowed(const char *name)
 {
-        char *tokens, *token;
-        bool allowed;
+	char *tokens, *token;
+	bool allowed;
 
-        if (!interface_pattern)
-                return true;
+	if (!interface_pattern)
+		return true;
 
-        tokens = strdup(interface_pattern);
-        if (!tokens)
-                return true; /* it is safer to be permissive */
+	tokens = strdup(interface_pattern);
+	if (!tokens)
+		return true; /* it is safer to be permissive */
 
-        for (token = strtok(tokens, ",");
-             token != NULL;
-             token = strtok(NULL, ",")) {
-                allowed = true;
+	for (token = strtok(tokens, ","); token != NULL;
+	     token = strtok(NULL, ",")) {
+		allowed = true;
 
-                if (token[0] == '-') {
-                        allowed = false;
-                        token++;
-                }
+		if (token[0] == '-') {
+			allowed = false;
+			token++;
+		}
 
-                if (fnmatch(token, name, 0) == 0)
-                        return allowed;
-        }
+		if (fnmatch(token, name, 0) == 0)
+			return allowed;
+	}
 
-        return false;
+	return false;
 }
 
 /* Look up an interface by identifier within a NS */

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

donaldsharp · 2020-12-02T17:43:49Z

can you describe your use case?

idryzhov · 2020-12-02T17:51:54Z

I have a system with a large number of interfaces and I want to run FRR only on a few of them.
Certainly, I can just not configure them, but they will still be present in commands like show int brief
and will be suggested by the autocompletion.
It's more convenient to block them and do not see them in vtysh at all.

donaldsharp · 2020-12-02T17:53:37Z

put those interfaces into their own namespace and run FRR in that namespace?

idryzhov · 2020-12-02T17:58:30Z

Unfortunately, it's not an option in my case. We can discuss in DM if you're interested.

From a general point of view, your solution will work, but it seems easier to just pass one additional option to zebra.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/558c8490006567dc9af59aee83071b4c/raw/a8709bd228476c5c34f3aa7703dd5ee474f02c58/cr_7659_1606932908.diff | git apply

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index c5221a429..6178c567b 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -784,8 +784,7 @@ static int netlink_interface(struct nlmsghdr *h, ns_id_t ns_id, int startup)
 
 	if (!zebra_if_allowed(name)) {
 		if (IS_ZEBRA_DEBUG_KERNEL)
-			zlog_debug("%s: ignoring interface %s",
-				   __func__, name);
+			zlog_debug("%s: ignoring interface %s", __func__, name);
 		return 0;
 	}
 
@@ -1452,8 +1451,9 @@ int netlink_link_change(struct nlmsghdr *h, ns_id_t ns_id, int startup)
 
 				if (!zebra_if_allowed(name)) {
 					if (IS_ZEBRA_DEBUG_KERNEL)
-						zlog_debug("%s: ignoring interface %s",
-							   __func__, name);
+						zlog_debug(
+							"%s: ignoring interface %s",
+							__func__, name);
 					return 0;
 				}
 
diff --git a/zebra/interface.c b/zebra/interface.c
index dda48c7ba..ff8aa1ae4 100644
--- a/zebra/interface.c
+++ b/zebra/interface.c
@@ -299,31 +299,30 @@ void if_unlink_per_ns(struct interface *ifp)
 
 bool zebra_if_allowed(const char *name)
 {
-        char *tokens, *token;
-        bool allowed;
+	char *tokens, *token;
+	bool allowed;
 
-        if (!interface_pattern)
-                return true;
+	if (!interface_pattern)
+		return true;
 
-        tokens = strdup(interface_pattern);
-        if (!tokens)
-                return true; /* it is safer to be permissive */
+	tokens = strdup(interface_pattern);
+	if (!tokens)
+		return true; /* it is safer to be permissive */
 
-        for (token = strtok(tokens, ",");
-             token != NULL;
-             token = strtok(NULL, ",")) {
-                allowed = true;
+	for (token = strtok(tokens, ","); token != NULL;
+	     token = strtok(NULL, ",")) {
+		allowed = true;
 
-                if (token[0] == '-') {
-                        allowed = false;
-                        token++;
-                }
+		if (token[0] == '-') {
+			allowed = false;
+			token++;
+		}
 
-                if (fnmatch(token, name, 0) == 0)
-                        return allowed;
-        }
+		if (fnmatch(token, name, 0) == 0)
+			return allowed;
+	}
 
-        return false;
+	return false;
 }
 
 /* Look up an interface by identifier within a NS */

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/5f36a993a071619653009e1599e93a27/raw/817c9da67a312655f7c95ce3e7bc8a823ad40b7a/cr_7659_1606933154.diff | git apply

diff --git a/zebra/if_netlink.c b/zebra/if_netlink.c
index 8e3e451ce..253be57ba 100644
--- a/zebra/if_netlink.c
+++ b/zebra/if_netlink.c
@@ -1452,8 +1452,8 @@ int netlink_link_change(struct nlmsghdr *h, ns_id_t ns_id, int startup)
 				if (!zebra_if_allowed(name)) {
 					if (IS_ZEBRA_DEBUG_KERNEL)
 						zlog_debug(
-+							"%s: ignoring interface %s",
-+							__func__, name);
+							+"%s: ignoring interface %s",
+							+__func__, name);
 					return 0;
 				}
 
diff --git a/zebra/interface.c b/zebra/interface.c
index 2b3527336..ff8aa1ae4 100644
--- a/zebra/interface.c
+++ b/zebra/interface.c
@@ -309,8 +309,7 @@ bool zebra_if_allowed(const char *name)
 	if (!tokens)
 		return true; /* it is safer to be permissive */
 
-	for (token = strtok(tokens, ",");
-	     token != NULL;
+	for (token = strtok(tokens, ","); token != NULL;
 	     token = strtok(NULL, ",")) {
 		allowed = true;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

NetDEF-CI · 2020-12-02T18:53:56Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

zebra/interface.o: In function `zebra_if_allowed':
/usr/home/ci/cibuild.15797/frr-source/zebra/interface.c:305: undefined reference to `interface_pattern'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7306: zebra/zebra] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.15797/frr-source'
gmake: *** [Makefile:4885: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/local/bin/ld: zebra/interface.o: in function `zebra_if_allowed':
/usr/home/ci/cibuild.15797/frr-source/zebra/interface.c:305: undefined reference to `interface_pattern'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7306: zebra/zebra] Error 1
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:127: WARNING: duplicate clicmd description of redistribute kernel, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:139: WARNING: duplicate clicmd description of redistribute static, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:151: WARNING: duplicate clicmd description of redistribute connected, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:165: WARNING: duplicate clicmd description of redistribute ospf, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/isisd.rst:45: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.15797/frr-source'
copying selected object files to avoid basename conflicts...
ld: error: undefined symbol: interface_pattern
>>> referenced by interface.c:305 (zebra/interface.c:305)
>>>               zebra/interface.o:(zebra_if_allowed)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [Makefile:7305: zebra/zebra] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.15797/frr-source'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/config.status/config.status
OpenBSD 6 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27577: warning: @image file `frr-figures/fig-vnc-commercial-route-reflector.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:27700: warning: @image file `frr-figures/fig-vnc-redundant-route-reflectors.txt' (for text) unreadable: No such file or directory.
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.15797/frr-source'
gmake: *** [Makefile:4885: all] Error 2

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/config.status/config.status

Successful on other platforms/tests

Ubuntu 16.04 arm8 build
Fedora 29 amd64 build
Debian 10 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
CentOS 8 amd64 build
Ubuntu 16.04 arm7 build
Ubuntu 16.04 i386 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 18.04 arm7 build
Ubuntu 20.04 amd64 build
CentOS 7 amd64 build
Ubuntu 18.04 arm8 build
Debian 9 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

zebra/interface.o: In function `zebra_if_allowed':
/usr/home/ci/cibuild.15797/frr-source/zebra/interface.c:305: undefined reference to `interface_pattern'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7306: zebra/zebra] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.15797/frr-source'
gmake: *** [Makefile:4885: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/config.status/config.status
FreeBSD 12 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/FBSD12AMD64/config.log/config.log.gz

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/ErrorLog/log_make.txt)

/usr/local/bin/ld: zebra/interface.o: in function `zebra_if_allowed':
/usr/home/ci/cibuild.15797/frr-source/zebra/interface.c:305: undefined reference to `interface_pattern'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:7306: zebra/zebra] Error 1
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:127: WARNING: duplicate clicmd description of redistribute kernel, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:139: WARNING: duplicate clicmd description of redistribute static, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:151: WARNING: duplicate clicmd description of redistribute connected, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/eigrpd.rst:165: WARNING: duplicate clicmd description of redistribute ospf, other instance in bgp
/usr/home/ci/cibuild.15797/frr-source/doc/user/isisd.rst:45: WARNING: duplicate clicmd description of net XX.XXXX. ... .XXX.XX, other instance in fabricd

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/config.status/config.status
FreeBSD 11 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI009BUILD/config.log/config.log.gz

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.15797/frr-source'
copying selected object files to avoid basename conflicts...
ld: error: undefined symbol: interface_pattern
>>> referenced by interface.c:305 (zebra/interface.c:305)
>>>               zebra/interface.o:(zebra_if_allowed)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [Makefile:7305: zebra/zebra] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.15797/frr-source'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/config.status/config.status
OpenBSD 6 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI011BUILD/config.log/config.log.gz

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/config.log/config.log.gz

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/ErrorLog/log_make.txt)

doc/user/_build/texinfo/frr.texi:27577: warning: @image file `frr-figures/fig-vnc-commercial-route-reflector.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:27700: warning: @image file `frr-figures/fig-vnc-redundant-route-reflectors.txt' (for text) unreadable: No such file or directory.
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.15797/frr-source'
gmake: *** [Makefile:4885: all] Error 2

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/CI012BUILD/config.status/config.status

Report for interface.c | 76 issues
===============================================
< ERROR: code indent should use tabs where possible
< #302: FILE: /tmp/f1-26254/interface.c:302:
< WARNING: please, no spaces at the start of a line
< #302: FILE: /tmp/f1-26254/interface.c:302:
< ERROR: code indent should use tabs where possible
< #303: FILE: /tmp/f1-26254/interface.c:303:
< WARNING: please, no spaces at the start of a line
< #303: FILE: /tmp/f1-26254/interface.c:303:
< ERROR: code indent should use tabs where possible
< #305: FILE: /tmp/f1-26254/interface.c:305:
< WARNING: please, no spaces at the start of a line
< #305: FILE: /tmp/f1-26254/interface.c:305:
< ERROR: code indent should use tabs where possible
< #306: FILE: /tmp/f1-26254/interface.c:306:
< WARNING: please, no spaces at the start of a line
< #306: FILE: /tmp/f1-26254/interface.c:306:
< ERROR: code indent should use tabs where possible
< #308: FILE: /tmp/f1-26254/interface.c:308:
< WARNING: please, no spaces at the start of a line
< #308: FILE: /tmp/f1-26254/interface.c:308:
< ERROR: code indent should use tabs where possible
< #309: FILE: /tmp/f1-26254/interface.c:309:
< WARNING: please, no spaces at the start of a line
< #309: FILE: /tmp/f1-26254/interface.c:309:
< ERROR: code indent should use tabs where possible
< #310: FILE: /tmp/f1-26254/interface.c:310:
< WARNING: please, no spaces at the start of a line
< #310: FILE: /tmp/f1-26254/interface.c:310:
< ERROR: code indent should use tabs where possible
< #312: FILE: /tmp/f1-26254/interface.c:312:
< WARNING: please, no spaces at the start of a line
< #312: FILE: /tmp/f1-26254/interface.c:312:
< ERROR: code indent should use tabs where possible
< #313: FILE: /tmp/f1-26254/interface.c:313:
< WARNING: please, no spaces at the start of a line
< #313: FILE: /tmp/f1-26254/interface.c:313:
< ERROR: code indent should use tabs where possible
< #314: FILE: /tmp/f1-26254/interface.c:314:
< WARNING: please, no spaces at the start of a line
< #314: FILE: /tmp/f1-26254/interface.c:314:
< ERROR: code indent should use tabs where possible
< #315: FILE: /tmp/f1-26254/interface.c:315:
< WARNING: please, no spaces at the start of a line
< #315: FILE: /tmp/f1-26254/interface.c:315:
< ERROR: code indent should use tabs where possible
< #317: FILE: /tmp/f1-26254/interface.c:317:
< WARNING: please, no spaces at the start of a line
< #317: FILE: /tmp/f1-26254/interface.c:317:
< ERROR: code indent should use tabs where possible
< #318: FILE: /tmp/f1-26254/interface.c:318:
< WARNING: please, no spaces at the start of a line
< #318: FILE: /tmp/f1-26254/interface.c:318:
< ERROR: code indent should use tabs where possible
< #319: FILE: /tmp/f1-26254/interface.c:319:
< WARNING: please, no spaces at the start of a line
< #319: FILE: /tmp/f1-26254/interface.c:319:
< ERROR: code indent should use tabs where possible
< #320: FILE: /tmp/f1-26254/interface.c:320:
< WARNING: please, no spaces at the start of a line
< #320: FILE: /tmp/f1-26254/interface.c:320:
< ERROR: code indent should use tabs where possible
< #322: FILE: /tmp/f1-26254/interface.c:322:
< WARNING: please, no spaces at the start of a line
< #322: FILE: /tmp/f1-26254/interface.c:322:
< ERROR: code indent should use tabs where possible
< #323: FILE: /tmp/f1-26254/interface.c:323:
< WARNING: please, no spaces at the start of a line
< #323: FILE: /tmp/f1-26254/interface.c:323:
< ERROR: code indent should use tabs where possible
< #324: FILE: /tmp/f1-26254/interface.c:324:
< WARNING: please, no spaces at the start of a line
< #324: FILE: /tmp/f1-26254/interface.c:324:
< ERROR: code indent should use tabs where possible
< #326: FILE: /tmp/f1-26254/interface.c:326:
< WARNING: please, no spaces at the start of a line
< #326: FILE: /tmp/f1-26254/interface.c:326:
Report for main.c | 2 issues
===============================================
< ERROR: do not initialise globals to NULL
< #83: FILE: /tmp/f1-26254/main.c:83:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15797/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-gfe0f64c3a-0 (missing) -> 7.6-dev-20201202-00-gfe0f64c3a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-gfe0f64c3a-0 (missing) -> 7.6-dev-20201202-00-gfe0f64c3a-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-gfe0f64c3a-0 (missing) -> 7.6-dev-20201202-00-gfe0f64c3a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-gfe0f64c3a-0 (missing) -> 7.6-dev-20201202-00-gfe0f64c3a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-gfe0f64c3a-0 (missing) -> 7.6-dev-20201202-00-gfe0f64c3a-0~deb10u1

NetDEF-CI · 2020-12-02T19:05:31Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/config.status/config.status
CentOS 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/config.log/config.log.gz

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/config.log/config.log.gz

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 1455 | +       "%s: ignoring interface %s",
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 1456 | +       __func__, name);
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
make[1]: *** [Makefile:8195: zebra/if_netlink.o] Error 1

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Successful on other platforms/tests

OpenBSD 6 amd64 build
FreeBSD 11 amd64 build
FreeBSD 12 amd64 build
NetBSD 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/config.log/config.log.gz
Ubuntu 16.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U16ARM8BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/config.status/config.status
Fedora 29 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/F29BUILD/config.log/config.log.gz

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

CentOS 8 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CENTOS8BUILD/config.log/config.log.gz

Ubuntu 16.04 arm7 build: Failed (click for details)

Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/config.log/config.log.gz

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/config.log/config.log.gz

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/config.status/config.status
Ubuntu 16.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1604I386/config.log/config.log.gz

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/config.status/config.status
Ubuntu 16.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI014BUILD/config.log/config.log.gz

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/config.status/config.status
Ubuntu 18.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804AMD64/config.log/config.log.gz

Ubuntu 18.04 arm8 build: Failed (click for details)

Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/config.log/config.log.gz
Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U18ARM7BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/config.status/config.status
CentOS 7 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI005BUILD/config.log/config.log.gz

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/config.log/config.log.gz

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI008BLD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/config.status/config.status
Debian 9 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/CI021BUILD/config.log/config.log.gz

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 1455 | +       "%s: ignoring interface %s",
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 1456 | +       __func__, name);
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
make[1]: *** [Makefile:8195: zebra/if_netlink.o] Error 1

Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U2004AMD64BUILD/config.log/config.log.gz

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:34:0,
zebra/if_netlink.c: In function netlink_link_change:
zebra/if_netlink.c:1455:1: error: wrong type argument to unary plus
 +       "%s: ignoring interface %s",
 ^
./lib/zlog.h:64:42: note: in definition of macro zlog_debug
 #define zlog_debug(...)  zlog(LOG_DEBUG, __VA_ARGS__)
zebra/if_netlink.c:1456:1: error: wrong type argument to unary plus
 +       __func__, name);

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15800/artifact/U1804PPC64LEBUILD/config.log/config.log.gz

Report for if_netlink.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1455: FILE: /tmp/f1-4215/if_netlink.c:1455:
Report for main.c | 2 issues
===============================================
< ERROR: do not initialise globals to NULL
< #80: FILE: /tmp/f1-4215/main.c:80:

LabN-CI · 2020-12-02T20:41:42Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/7659 `47fa782`
Date	12/02/2020
Start	15:06:19
Finish	15:41:37
Run-Time	35:18
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-12-02-15:06:19.txt
Log	autoscript-2020-12-02-15:07:23.log.bz2
Memory	502 504 427

For details, please contact louberger

NetDEF-CI · 2020-12-02T21:42:10Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15799/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for interface.c | 76 issues
===============================================
< ERROR: code indent should use tabs where possible
< #302: FILE: /tmp/f1-27371/interface.c:302:
< WARNING: please, no spaces at the start of a line
< #302: FILE: /tmp/f1-27371/interface.c:302:
< ERROR: code indent should use tabs where possible
< #303: FILE: /tmp/f1-27371/interface.c:303:
< WARNING: please, no spaces at the start of a line
< #303: FILE: /tmp/f1-27371/interface.c:303:
< ERROR: code indent should use tabs where possible
< #305: FILE: /tmp/f1-27371/interface.c:305:
< WARNING: please, no spaces at the start of a line
< #305: FILE: /tmp/f1-27371/interface.c:305:
< ERROR: code indent should use tabs where possible
< #306: FILE: /tmp/f1-27371/interface.c:306:
< WARNING: please, no spaces at the start of a line
< #306: FILE: /tmp/f1-27371/interface.c:306:
< ERROR: code indent should use tabs where possible
< #308: FILE: /tmp/f1-27371/interface.c:308:
< WARNING: please, no spaces at the start of a line
< #308: FILE: /tmp/f1-27371/interface.c:308:
< ERROR: code indent should use tabs where possible
< #309: FILE: /tmp/f1-27371/interface.c:309:
< WARNING: please, no spaces at the start of a line
< #309: FILE: /tmp/f1-27371/interface.c:309:
< ERROR: code indent should use tabs where possible
< #310: FILE: /tmp/f1-27371/interface.c:310:
< WARNING: please, no spaces at the start of a line
< #310: FILE: /tmp/f1-27371/interface.c:310:
< ERROR: code indent should use tabs where possible
< #312: FILE: /tmp/f1-27371/interface.c:312:
< WARNING: please, no spaces at the start of a line
< #312: FILE: /tmp/f1-27371/interface.c:312:
< ERROR: code indent should use tabs where possible
< #313: FILE: /tmp/f1-27371/interface.c:313:
< WARNING: please, no spaces at the start of a line
< #313: FILE: /tmp/f1-27371/interface.c:313:
< ERROR: code indent should use tabs where possible
< #314: FILE: /tmp/f1-27371/interface.c:314:
< WARNING: please, no spaces at the start of a line
< #314: FILE: /tmp/f1-27371/interface.c:314:
< ERROR: code indent should use tabs where possible
< #315: FILE: /tmp/f1-27371/interface.c:315:
< WARNING: please, no spaces at the start of a line
< #315: FILE: /tmp/f1-27371/interface.c:315:
< ERROR: code indent should use tabs where possible
< #317: FILE: /tmp/f1-27371/interface.c:317:
< WARNING: please, no spaces at the start of a line
< #317: FILE: /tmp/f1-27371/interface.c:317:
< ERROR: code indent should use tabs where possible
< #318: FILE: /tmp/f1-27371/interface.c:318:
< WARNING: please, no spaces at the start of a line
< #318: FILE: /tmp/f1-27371/interface.c:318:
< ERROR: code indent should use tabs where possible
< #319: FILE: /tmp/f1-27371/interface.c:319:
< WARNING: please, no spaces at the start of a line
< #319: FILE: /tmp/f1-27371/interface.c:319:
< ERROR: code indent should use tabs where possible
< #320: FILE: /tmp/f1-27371/interface.c:320:
< WARNING: please, no spaces at the start of a line
< #320: FILE: /tmp/f1-27371/interface.c:320:
< ERROR: code indent should use tabs where possible
< #322: FILE: /tmp/f1-27371/interface.c:322:
< WARNING: please, no spaces at the start of a line
< #322: FILE: /tmp/f1-27371/interface.c:322:
< ERROR: code indent should use tabs where possible
< #323: FILE: /tmp/f1-27371/interface.c:323:
< WARNING: please, no spaces at the start of a line
< #323: FILE: /tmp/f1-27371/interface.c:323:
< ERROR: code indent should use tabs where possible
< #324: FILE: /tmp/f1-27371/interface.c:324:
< WARNING: please, no spaces at the start of a line
< #324: FILE: /tmp/f1-27371/interface.c:324:
< ERROR: code indent should use tabs where possible
< #326: FILE: /tmp/f1-27371/interface.c:326:
< WARNING: please, no spaces at the start of a line
< #326: FILE: /tmp/f1-27371/interface.c:326:
Report for main.c | 2 issues
===============================================
< ERROR: do not initialise globals to NULL
< #80: FILE: /tmp/f1-27371/main.c:80:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15799/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g670c54fd0-0 (missing) -> 7.6-dev-20201202-00-g670c54fd0-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g670c54fd0-0 (missing) -> 7.6-dev-20201202-00-g670c54fd0-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g670c54fd0-0 (missing) -> 7.6-dev-20201202-00-g670c54fd0-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g670c54fd0-0 (missing) -> 7.6-dev-20201202-00-g670c54fd0-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g670c54fd0-0 (missing) -> 7.6-dev-20201202-00-g670c54fd0-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7659, comparing to Git base SHA fa9f050
Base image data for Git fa9f050 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15799/artifact/shared/static_analysis/index.html

NetDEF-CI · 2020-12-02T21:52:35Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15801/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for main.c | 2 issues
===============================================
< ERROR: do not initialise globals to NULL
< #80: FILE: /tmp/f1-8237/main.c:80:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15801/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g47fa78293-0 (missing) -> 7.6-dev-20201202-00-g47fa78293-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g47fa78293-0 (missing) -> 7.6-dev-20201202-00-g47fa78293-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g47fa78293-0 (missing) -> 7.6-dev-20201202-00-g47fa78293-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g47fa78293-0 (missing) -> 7.6-dev-20201202-00-g47fa78293-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201202-00-g47fa78293-0 (missing) -> 7.6-dev-20201202-00-g47fa78293-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7659, comparing to Git base SHA fa9f050
Base image data for Git fa9f050 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15801/artifact/shared/static_analysis/index.html

donaldsharp · 2020-12-03T13:12:56Z

I've spoken offline w/ @idryzhov about this and I believe that this should be discussed at the next technical meeting for group input.

Ideas/thoughts I have had that could help ( or approach the problem differently ) and I wanted to write them down before I forget them:

(a) This is linux only. Should we care about this being generic for all platforms? ( brought up by @sworleys )
(b) How to handle debugging this when someone turns this on and comes to us for help( as that the rib and fib are going to be out of sync with each other )
(c) Possible to signal that an interface could be ignored via an alias/description in the kernel( or to establish a relationship between two interfaces? )
(d) Is this something that could be handled in the kernel? I'll speak w/ internal kernel developers to get their take before the meeting.

donaldsharp · 2020-12-03T13:30:26Z

We could use device groups IFLA_GROUP as the key to this as well.

sworleys · 2021-01-05T16:48:19Z

@idryzhov any more opinions on this one? I think we discussed in the meeting seeing if we could move the code up so it works on all platforms. Are you okay with that or were you against it? I like this functionality so I wanna see it get merged in.

idryzhov · 2021-01-05T20:26:21Z

@sworleys yes, we agreed to make it OS independent by moving the check to a higher level. I just didn't have time yet. I'll update this or next week.

github-actions · 2022-10-13T13:24:02Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

donaldsharp · 2023-04-13T11:48:40Z

Closing this PR. Can be re-opened when submitter has time to work on it again

polychaeta added the zebra label Dec 2, 2020

polychaeta reviewed Dec 2, 2020

View reviewed changes

idryzhov force-pushed the interface-pattern branch from fe0f64c to 670c54f Compare December 2, 2020 18:15

polychaeta reviewed Dec 2, 2020

View reviewed changes

idryzhov force-pushed the interface-pattern branch from 670c54f to 3e6c8b1 Compare December 2, 2020 18:19

polychaeta reviewed Dec 2, 2020

View reviewed changes

zebra: add option to specify interfaces to work with

47fa782

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

idryzhov force-pushed the interface-pattern branch from 3e6c8b1 to 47fa782 Compare December 2, 2020 18:20

qlyoung requested review from mjstapp and sworleys January 5, 2021 16:45

github-actions bot added the conflicts label Oct 13, 2022

donaldsharp closed this Apr 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] zebra: add option to specify interfaces to work with #7659

[RFC] zebra: add option to specify interfaces to work with #7659

idryzhov commented Dec 2, 2020 •

edited

Loading

polychaeta left a comment

donaldsharp commented Dec 2, 2020

idryzhov commented Dec 2, 2020

donaldsharp commented Dec 2, 2020

idryzhov commented Dec 2, 2020

polychaeta left a comment

polychaeta left a comment

NetDEF-CI commented Dec 2, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Warnings Generated during build:

NetDEF-CI commented Dec 2, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 2, 2020

NetDEF-CI commented Dec 2, 2020 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

NetDEF-CI commented Dec 2, 2020

donaldsharp commented Dec 3, 2020

donaldsharp commented Dec 3, 2020

sworleys commented Jan 5, 2021

idryzhov commented Jan 5, 2021

github-actions bot commented Oct 13, 2022

donaldsharp commented Apr 13, 2023

[RFC] zebra: add option to specify interfaces to work with #7659

[RFC] zebra: add option to specify interfaces to work with #7659

Conversation

idryzhov commented Dec 2, 2020 • edited Loading

polychaeta left a comment

Choose a reason for hiding this comment

donaldsharp commented Dec 2, 2020

idryzhov commented Dec 2, 2020

donaldsharp commented Dec 2, 2020

idryzhov commented Dec 2, 2020

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Dec 2, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Warnings Generated during build:

NetDEF-CI commented Dec 2, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 2, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 2, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

NetDEF-CI commented Dec 2, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

donaldsharp commented Dec 3, 2020

donaldsharp commented Dec 3, 2020

sworleys commented Jan 5, 2021

idryzhov commented Jan 5, 2021

github-actions bot commented Oct 13, 2022

donaldsharp commented Apr 13, 2023

idryzhov commented Dec 2, 2020 •

edited

Loading

NetDEF-CI commented Dec 2, 2020 •

edited

Loading

NetDEF-CI commented Dec 2, 2020 •

edited

Loading

NetDEF-CI commented Dec 2, 2020 •

edited

Loading