evpn-mh: changes for programming synced neighs as static in the dataplane #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2020 16:38
kernel header files for neigh sync support Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Changes to setup peer-synced as static in the dataplane. This prevents them from being flushed out when the local switch cannot establish their reachability. Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
polychaeta
reviewed
Sep 17, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/1fda56116baf52a2a590e5c985e60cc5/raw/7f5a384cabbb39d3ce9df2eded98edcc13a40024/cr_7116_1600302726.diff | git apply
diff --git a/include/linux/neighbour.h b/include/linux/neighbour.h
index c06fe708f..ea22bd9c0 100644
--- a/include/linux/neighbour.h
+++ b/include/linux/neighbour.h
@@ -15,25 +15,23 @@ struct ndmsg {
__u8 ndm_type;
};
-enum {
- NDA_UNSPEC,
- NDA_DST,
- NDA_LLADDR,
- NDA_CACHEINFO,
- NDA_PROBES,
- NDA_VLAN,
- NDA_PORT,
- NDA_VNI,
- NDA_IFINDEX,
- NDA_MASTER,
- NDA_LINK_NETNSID,
- NDA_SRC_VNI,
- NDA_PROTOCOL, /* Originator of entry */
- NDA_NH_ID,
- NDA_NOTIFY,
- NDA_EXT_FLAGS,
- __NDA_MAX
-};
+enum { NDA_UNSPEC,
+ NDA_DST,
+ NDA_LLADDR,
+ NDA_CACHEINFO,
+ NDA_PROBES,
+ NDA_VLAN,
+ NDA_PORT,
+ NDA_VNI,
+ NDA_IFINDEX,
+ NDA_MASTER,
+ NDA_LINK_NETNSID,
+ NDA_SRC_VNI,
+ NDA_PROTOCOL, /* Originator of entry */
+ NDA_NH_ID,
+ NDA_NOTIFY,
+ NDA_EXT_FLAGS,
+ __NDA_MAX };
#define NDA_MAX (__NDA_MAX - 1)
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14220/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
srimohans
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosts learnt from an Ethernet Segment peer are setup as static/peer-synced in the dataplane to prevent them from being aged out.
There are two commits in this PR -