Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evpn-mh: changes for programming synced neighs as static in the dataplane #7116

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

AnuradhaKaruppiah
Copy link
Contributor

Hosts learnt from an Ethernet Segment peer are setup as static/peer-synced in the dataplane to prevent them from being aged out.

There are two commits in this PR -

  • The first one is linux UAPI
  • Second is the dataplane abstraction and setting

Anuradha Karuppiah added 2 commits September 16, 2020 16:38
kernel header files for neigh sync support

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Changes to setup peer-synced as static in the dataplane. This prevents
them from being flushed out when the local switch cannot establish
their reachability.

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/1fda56116baf52a2a590e5c985e60cc5/raw/7f5a384cabbb39d3ce9df2eded98edcc13a40024/cr_7116_1600302726.diff | git apply

diff --git a/include/linux/neighbour.h b/include/linux/neighbour.h
index c06fe708f..ea22bd9c0 100644
--- a/include/linux/neighbour.h
+++ b/include/linux/neighbour.h
@@ -15,25 +15,23 @@ struct ndmsg {
 	__u8		ndm_type;
 };
 
-enum {
-	NDA_UNSPEC,
-	NDA_DST,
-	NDA_LLADDR,
-	NDA_CACHEINFO,
-	NDA_PROBES,
-	NDA_VLAN,
-	NDA_PORT,
-	NDA_VNI,
-	NDA_IFINDEX,
-	NDA_MASTER,
-	NDA_LINK_NETNSID,
-	NDA_SRC_VNI,
-	NDA_PROTOCOL,  /* Originator of entry */
-	NDA_NH_ID,
-	NDA_NOTIFY,
-	NDA_EXT_FLAGS,
-	__NDA_MAX
-};
+enum { NDA_UNSPEC,
+       NDA_DST,
+       NDA_LLADDR,
+       NDA_CACHEINFO,
+       NDA_PROBES,
+       NDA_VLAN,
+       NDA_PORT,
+       NDA_VNI,
+       NDA_IFINDEX,
+       NDA_MASTER,
+       NDA_LINK_NETNSID,
+       NDA_SRC_VNI,
+       NDA_PROTOCOL, /* Originator of entry */
+       NDA_NH_ID,
+       NDA_NOTIFY,
+       NDA_EXT_FLAGS,
+       __NDA_MAX };
 
 #define NDA_MAX (__NDA_MAX - 1)
 

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 17, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result 0
Date 0
Start 0
Finish vncregress-2020-09-16-21:01:35.txt
Run-Time autoscript-2020-09-16-21:02:36.log.bz2
Total 484 493 417
Pass SUCCESS git merge/7066 9fa352c
Fail 09/11/2020
Valgrind-Errors 21:01:35
Valgrind-Loss 21:27:40
Details 26:05
Log 1815
Memory 1815
SUCCESS git merge/7116 ccd187c 0
09/16/2020 0
21:01:35 0
21:27:35 vncregress-2020-09-11-21:01:35.txt
26:00 autoscript-2020-09-11-21:02:35.log.bz2
1815 498 495 427
1815

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14220/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14220/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20200917-00-gccd187cda-0 (missing) -> 7.6-dev-20200917-00-gccd187cda-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20200917-00-gccd187cda-0 (missing) -> 7.6-dev-20200917-00-gccd187cda-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20200917-00-gccd187cda-0 (missing) -> 7.6-dev-20200917-00-gccd187cda-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20200917-00-gccd187cda-0 (missing) -> 7.6-dev-20200917-00-gccd187cda-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20200917-00-gccd187cda-0 (missing) -> 7.6-dev-20200917-00-gccd187cda-0~deb10u1

@srimohans srimohans merged commit efdd997 into FRRouting:master Sep 22, 2020
@AnuradhaKaruppiah AnuradhaKaruppiah deleted the mh-neigh-fixes branch August 16, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants