Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zebra: RIB operational nortbound callbacks implementation #6171

Closed
wants to merge 65 commits into from
Closed

zebra: RIB operational nortbound callbacks implementation #6171

wants to merge 65 commits into from

Conversation

chiragshah6
Copy link
Member

The set of changes contain zebra's RIB operational model's northbound callbacks implementation.

Add zebra container to operational model.

chiragshah6 and others added 30 commits December 9, 2019 14:20
@chiragshah6
yang: add vrf model
0693b0d 
module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name      string
        +--ro id?       uint32
        +--ro active?   boolean <false>
        +--rw netns {netns}?
           +--rw name?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
*: add frr-vrf yang module in makefile
e095f16 
lib: Adding frr-vrf yang module to common place
so it can be accessed from all frr modules.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@riw777
Merge pull request FRRouting#5501 from chiragshah6/yang_nb1
7d75ef8 
yang: add vrf model
@chiragshah6
yang: add vrf model
cf93250 
module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name      string
        +--ro id?       uint32
        +--ro active?   boolean <false>
        +--rw netns {netns}?
           +--rw name?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
*: add frr-vrf yang module in makefile
245daf0 
lib: Adding frr-vrf yang module to common place
so it can be accessed from all frr modules.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Merge branch 'nb_conversions' of https://github.com/FRRouting/frr int…
2d2d0ee 
…o nb_conversions
@chiragshah6
yang: add vrf ref to interface model
87ee53f 
module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@rwestphal
Merge pull request FRRouting#5751 from chiragshah6/yang_nb1
5dd164b 
yang: add vrf ref to interface model
@vishaldhingra
staticd: yang defination
95f1804 
Yang files for staticd to use northbound APIs

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
@vishaldhingra
lib: yang defination for basic frr-routing
f5319ff 
Yang files for basic frr-routing used by other
daemons like staticd and pim

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
@vishaldhingra
lib: FRR next-hop yang data model.
a530bfe 
A common nexthop and group nexthop yang data model
for all protocols in FRR.

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: Vishaldhingra <vdhingra@vmware.com>
Signed-off-by: Santosh P K <sapk@vmware.com>
@qlyoung
Merge pull request FRRouting#5578 from Spantik/working_nb
db727fe 
lib: FRR next-hop yang data model.
@qlyoung
Merge pull request FRRouting#5460 from vishaldhingra/static_nb
2a9ca11 
staticd: yang definition
@qlyoung
Merge pull request FRRouting#5530 from vishaldhingra/common_nb
aa9935c 
lib: yang defination for basic routing frr-routing
@chiragshah6
yang: add vrf model
6514ce8 
module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name      string
        +--ro id?       uint32
        +--ro active?   boolean <false>
        +--rw netns {netns}?
           +--rw name?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
*: add frr-vrf yang module in makefile
5b15a51 
lib: Adding frr-vrf yang module to common place
so it can be accessed from all frr modules.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: add vrf ref to interface model
ee8ac97 
module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@vishaldhingra
lib: FRR next-hop yang data model.
97928ec 
A common nexthop and group nexthop yang data model
for all protocols in FRR.

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: Vishaldhingra <vdhingra@vmware.com>
Signed-off-by: Santosh P K <sapk@vmware.com>
@vishaldhingra
staticd: yang defination
8f8cac6 
Yang files for staticd to use northbound APIs

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
@vishaldhingra
lib: yang defination for basic frr-routing
2aa6fcc 
Yang files for basic frr-routing used by other
daemons like staticd and pim

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
Merge branch 'nb_conversions' of https://github.com/FRRouting/frr int…
3e31357 
…o nb_conversions
@chiragshah6
yang: add vrf model
c590694 
module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name      string
        +--ro id?       uint32
        +--ro active?   boolean <false>
        +--rw netns {netns}?
           +--rw name?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
*: add frr-vrf yang module in makefile
2884b53 
lib: Adding frr-vrf yang module to common place
so it can be accessed from all frr modules.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: add vrf ref to interface model
745d694 
module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@vishaldhingra
lib: FRR next-hop yang data model.
1dc094d 
A common nexthop and group nexthop yang data model
for all protocols in FRR.

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: Vishaldhingra <vdhingra@vmware.com>
Signed-off-by: Santosh P K <sapk@vmware.com>
@vishaldhingra
staticd: yang defination
3cd3efe 
Yang files for staticd to use northbound APIs

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
@vishaldhingra
lib: yang defination for basic frr-routing
30144e1 
Yang files for basic frr-routing used by other
daemons like staticd and pim

Co-authored-by: Santosh P K <sapk@vmware.com>
Co-authored-by: vishaldhingra <vdhingra@vmware.com>
Signed-off-by: vishaldhingra <vdhingra@vmware.com>
Merge branch 'nb_conversions' of https://github.com/FRRouting/frr int…
84b5d31 
…o nb_conversions
@chiragshah6
yang: add vrf model
9503d08 
module: frr-vrf
  +--rw lib
     +--rw vrf* [name]
        +--rw name      string
        +--ro id?       uint32
        +--ro active?   boolean <false>
        +--rw netns {netns}?
           +--rw name?   string

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
*: add frr-vrf yang module in makefile
f899a08 
lib: Adding frr-vrf yang module to common place
so it can be accessed from all frr modules.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
chiragshah6 and others added 23 commits March 24, 2020 17:09
@chiragshah6
*: frr nexthop yang in makefile
940b572 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: add zebra model in makefile
66554a5 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: nb callbacks support
ea0be0e 
Definition of the northbound callbacks
and associated YANG data paths for zebra.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
lib:api to convert mac to yang object
d4a8616 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: clear dup detect cleanup for nb conversion
56a70b5 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: nb rpc cb for clear evpn dup addr cmd
c693e31 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: convert clear evpn dup addr command to nb
290716e 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: zebra rib model remove grouping for ip route
e7e1245 
Grouping is referencing leaves outside the grouping
from where it is used. Removing it and defining leaves
at the used place.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: zebra rib model add route entry
e294d09 
FRR rib model need to accomodate route entries for
a given destination prefix.

Add a list of route entry under the list of prefix.

+--rw ribs
   +--rw rib* [afi-safi-name table-id]
      +--rw table-id         uint32
      +--rw afi-safi-name    identityref
      +--ro route* [prefix]
         +--ro prefix         ietf-inet-types:ip-prefix
         +--ro route-entry* [protocol]
            +--ro protocol           frr-route-types:frr-route-types-v4
            +--ro instance?          uint16
            +--ro distance?          uint8
            +--ro metric?            uint32
            +--ro tag?               uint32
            +--ro selected?          empty
            +--ro installed?         empty
            +--ro failed?            empty
            +--ro queued?            empty
            +--ro internal-flags?    int32
            +--ro internal-status?   int32
            +--ro uptime?            ietf-yang-types:date-and-time
            +--ro nexthop-group* [name]
               +--ro name            string
               +--ro frr-nexthops
                  +--ro nexthop* [nh-type gateway interface]
                     +--ro nh-type             frr-nexthop:nexthop-type
                     +--ro vrf?                frr-vrf:vrf-ref
                     +--ro gateway             frr-nexthop:optional-ip-address
                     +--ro interface           frr-interface:interface-ref
                     +--ro bh-type?            frr-nexthop:blackhole-type
                     +--ro onlink?             boolean <false>
                     +--ro mpls-label-stack
                     |  +--ro entry* [id]
                     |     +--ro id               uint8
                     |     +--ro label?           ietf-routing-types:mpls-label
                     |     +--ro ttl?             uint8
                     |     +--ro traffic-class?   uint8
                     +--ro duplicate?          empty
                     +--ro recursive?          empty
                     +--ro active?             empty
                     +--ro fib?                empty

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: stub changes to assimilate re into rib nb
bd69aa2 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@Spantik
Merge pull request FRRouting#5533 from chiragshah6/yang_nb2
bfed557 
yang: zebra rib operational model
@chiragshah6
lib: add yang wrapper for type empty
ec770b9 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
lib: yang wrapper nexthop type to str
c795242 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@Spantik
Merge pull request FRRouting#6119 from chiragshah6/yang_nb3
60da766 
lib: yang northbound wrappers - type empty nexthop type2str
@patrasar
yang: igmp yang definition
30470e4 
Defined frr-igmp.yang file for IGMP protocol.

Co-authored-by: Sarita Patra <saritap@vmware.com>
Co-authored-by: Santosh P K <sapk@vmware.com>

Signed-off-by: Sarita Patra <saritap@vmware.com>
@qlyoung
Merge pull request FRRouting#5534 from patrasar/igmp_yang
85b497a 
yang: igmp yang definition
@chiragshah6
zebra: northbound changes for the rib model
0c16bbe 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: add zebra container to rib model
c817dcb 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: route node first next node
b6052a6 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
lib: increase xpath maxlen
3c5f0cd 
Certain xpath are well 256 characters, increasing
to 512.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
yang: add weight in nexthop operational model
352715c 
add weight field to operational model.
add leafref to nexthopgroup.
format according to yanglint.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: add weight to nb conversion
e36062e 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6
zebra: zebra rib nexthop northbound
fa09d29 
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
@chiragshah6 chiragshah6 closed this Apr 7, 2020
@chiragshah6 chiragshah6 deleted the yang_nb3 branch April 7, 2020 00:28
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11668/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11668/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200407-00-gfa09d29e0-0 (missing) -> 7.4-dev-20200407-00-gfa09d29e0-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200407-00-gfa09d29e0-0 (missing) -> 7.4-dev-20200407-00-gfa09d29e0-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200407-00-gfa09d29e0-0 (missing) -> 7.4-dev-20200407-00-gfa09d29e0-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200407-00-gfa09d29e0-0 (missing) -> 7.4-dev-20200407-00-gfa09d29e0-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200407-00-gfa09d29e0-0 (missing) -> 7.4-dev-20200407-00-gfa09d29e0-0~deb10u1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libfrr staticd yang zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@chiragshah6 @NetDEF-CI @polychaeta @riw777 @rwestphal @vishaldhingra @qlyoung @Spantik @patrasar