-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yang: zebra interface state operational model #5754
Conversation
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10596/artifact/CI009BUILD/config.status/config.status Successful on other platforms
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
@chiragshah6 we're going to rebase nb_conversions today; after that, please rebase this branch against it so we can pass CI |
34a8229
to
02c7209
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10612/ This is a comment from an automated CI system. clang_check |
02c7209
to
1986fb5
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10638/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10641/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
config false; | ||
description | ||
"The interface's MAC address."; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing state attributes from interface
- status
- Flag
- Metric
- mtu6
- configured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added the most in the latest patch. status can be driven via shutdown
rw field.
@@ -1845,6 +1905,38 @@ module frr-zebra { | |||
"Link bandwidth informational parameter, in megabits."; | |||
} | |||
// TODO -- link-params for (experimental/partial TE use in IGP extensions) | |||
container state { | |||
config false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a container counters under state? This could capture
- Interface up/down coutners
- Traffic counters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, counters are specific to zebra
module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd think we'd want up/down and packet counts, at least (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but as Chirag said it should probably go into the base interface model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiragshah6 you want to put them in base interface model as counters? I guess that is fine if that is what you meant.
"This type is used by data models that need to reference | ||
interfaces."; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used for referencing interface types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we copy the type alone? As that is small piece or we think IETF-interface will be useful later ?
d7070ad
to
95e679f
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10666/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
@riw777 @Spantik @qlyoung @rwestphal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly some nits... the change to two separate trees is a good one...
@@ -1845,6 +1905,38 @@ module frr-zebra { | |||
"Link bandwidth informational parameter, in megabits."; | |||
} | |||
// TODO -- link-params for (experimental/partial TE use in IGP extensions) | |||
container state { | |||
config false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd think we'd want up/down and packet counts, at least (?)
enum testing { | ||
value 3; | ||
description | ||
"In some test mode. No operational packets can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just "test mode" here, rather than "some test mode" :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is direct from the IETF model, if so I don't think we ought to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is itef-interfaces.yang draft, we do not want to modify any fields.
enum unknown { | ||
value 4; | ||
description | ||
"Status cannot be determined for some reason."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "Status cannot be determined."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to reference the ietf model.
enum testing { | ||
value 3; | ||
description | ||
"In some test mode. No operational packets can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe remove "some" here
yang/frr-interface.yang
Outdated
description | ||
""; | ||
} | ||
enum "promis" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
promisc
@@ -1845,6 +1905,38 @@ module frr-zebra { | |||
"Link bandwidth informational parameter, in megabits."; | |||
} | |||
// TODO -- link-params for (experimental/partial TE use in IGP extensions) | |||
container state { | |||
config false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but as Chirag said it should probably go into the base interface model
enum testing { | ||
value 3; | ||
description | ||
"In some test mode. No operational packets can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is direct from the IETF model, if so I don't think we ought to change it.
95e679f
to
25619e6
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10699/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
25619e6
to
a776051
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10703/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
a776051
to
e03cd72
Compare
Refine model post all the comments:
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10769/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
e03cd72
to
dd267c1
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10777/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundUbuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundDebian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundTopology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-10777/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-10777/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 IPv4 protocols on Ubuntu 14.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundDebian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/TOPOU1804/MemoryLeaks/ Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
clang_check |
1 similar comment
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10777/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundUbuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundDebian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundTopology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-10777/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-10777/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 IPv4 protocols on Ubuntu 14.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundDebian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundSuccessful on other platforms
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10777/artifact/TOPOU1804/MemoryLeaks/ Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
clang_check |
dd267c1
to
4d8911b
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 14.04: Failed (click for details)Ubuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundTopotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-10835/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 Debian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundDebian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundTopology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-10835/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 IPv4 protocols on Ubuntu 14.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundFedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundUbuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Topology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10835/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 Successful on other platforms
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10835/artifact/TOPOI386/MemoryLeaks/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -1845,6 +1905,38 @@ module frr-zebra { | |||
"Link bandwidth informational parameter, in megabits."; | |||
} | |||
// TODO -- link-params for (experimental/partial TE use in IGP extensions) | |||
container state { | |||
config false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiragshah6 you want to put them in base interface model as counters? I guess that is fine if that is what you meant.
I'm thinking here if it makes sense to have operational data in a libfrr module. If we do that, which daemon will be in charge of providing that data (thinking in terms of our future centralized management architecture)? |
4d8911b
to
d095cac
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteIPv4 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11428/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundDebian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundUbuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11428/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 IPv6 protocols on Ubuntu 14.04: Failed (click for details)Debian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundTopotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11428/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundIPv4 protocols on Ubuntu 14.04: Failed (click for details)Topology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11428/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundDebian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundUbuntu 16.04 deb pkg check: Failed (click for details)Ubuntu 16.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/U1604DEBTEST/ErrorLog/log_package_start.txt Ubuntu 16.04 deb pkg check: No useful log foundCentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11428/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 IPv6 protocols on Ubuntu 14.04: Failed (click for details)Debian 10 deb pkg check: Failed (click for details)Debian 10 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/DEB10PKGCHK/ErrorLog/log_package_start.txt Debian 10 deb pkg check: No useful log foundTopotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11428/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 Fedora 29 rpm pkg check: Failed (click for details)Fedora 29 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/F29RPMCHECK/ErrorLog/log_package_start.txt Fedora 29 rpm pkg check: No useful log foundAddresssanitizer topotests part 2: Incomplete(check logs for details)Debian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11428/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundSuccessful on other platforms/tests
|
d095cac
to
1f367a7
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedUbuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/U1604I386/config.status/config.status Debian 9 amd64 build: Failed (click for details)Make failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI021BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build:
NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI014BUILD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build:
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI001BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build:
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI008BLD/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build:
OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI011BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build:
NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI007BUILD/config.status/config.status Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsUbuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/U1604I386/config.status/config.status Debian 9 amd64 build: Failed (click for details)Make failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI021BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build:
NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI014BUILD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build:
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI001BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build:
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI008BLD/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build:
OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI011BUILD/config.status/config.status NetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build:
NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11467/artifact/CI007BUILD/config.status/config.status
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
1f367a7
to
04b1375
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedNetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build:
NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI007BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build:
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI008BLD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build:
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI001BUILD/config.status/config.status Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsNetBSD 6 amd64 build: Failed (click for details)Make failed for NetBSD 6 amd64 build:
NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI007BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build:
Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI008BLD/config.status/config.status Ubuntu 14.04 amd64 build: Failed (click for details)Make failed for Ubuntu 14.04 amd64 build:
Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11471/artifact/CI001BUILD/config.status/config.status
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11472/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11472/artifact/TOPOU1804/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11472/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11472/artifact/TOPOU1804/ErrorLog/log_topotests.txt
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11472/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
55ef3a7
to
8e5eb07
Compare
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11571/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundDebian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundTopology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11571/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 IPv4 protocols on Ubuntu 14.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/ASAN3/AddressSanitizerError/AddressSanitzer.txt Addresssanitizer topotests part 3: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11571/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64 Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsIPv6 protocols on Ubuntu 14.04: Failed (click for details)Topotest tests on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11571/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 CentOS 7 rpm pkg check: Failed (click for details)CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/CENTOS7RPM/ErrorLog/log_package_start.txt CentOS 7 rpm pkg check: No useful log foundDebian 8 deb pkg check: Failed (click for details)Debian 8 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/D8DEBTEST/ErrorLog/log_package_start.txt Debian 8 deb pkg check: No useful log foundTopology tests on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11571/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 IPv4 protocols on Ubuntu 14.04: Failed (click for details)Debian 9 deb pkg check: Failed (click for details)Debian 9 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/D9DEBCHECK/ErrorLog/log_package_start.txt Debian 9 deb pkg check: No useful log foundAddresssanitizer topotests part 3: Failed (click for details)Addresssanitizer topotests part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/ASAN3/AddressSanitizerError/AddressSanitzer.txt Addresssanitizer topotests part 3: No useful log foundIPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)Ubuntu 14.04 deb pkg check: Failed (click for details)Ubuntu 14.04 deb pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11571/artifact/U1404DEBTEST/ErrorLog/log_package_start.txt Ubuntu 14.04 deb pkg check: No useful log foundTopology tests on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11571/test Topology Tests failed for Topology tests on Ubuntu 18.04 amd64
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
8e5eb07
to
3ab2ae8
Compare
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11595/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
|
Add ietf interface yant model. Also include it in the makefile. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
module: frr-interface +--rw lib +--rw interface* [name vrf] +--rw name string +--rw vrf frr-vrf:vrf-ref +--rw description? string +--ro state +--ro if-index? int32 +--ro mtu? uint16 +--ro mtu6? uint32 +--ro speed? uint32 +--ro metric? uint32 +--ro flags? if-flags-type +--ro type? identityref +--ro phy-address? ietf-yang-types:mac-address Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Modify interface config model and add zebra specific interface state operational data. augment /frr-interface:lib/frr-interface:interface: +--rw zebra +--rw ip-addrs* [address-family ip-prefix] | +--rw address-family identityref | +--rw ip-prefix ietf-inet-types:ip-prefix | +--rw label? string | +--rw ip4-peer? ietf-inet-types:ipv4-prefix +--rw multicast? boolean +--rw link-detect? boolean +--rw shutdown? boolean +--rw bandwidth? uint32 +--ro state +--ro up-count? uint16 +--ro down-count? uint16 +--ro zif-type? identityref +--ro ptm-status? string <disabled> +--ro vlan-id? uint16 +--ro vni-id? vni-id-type +--ro remote-vtep? ietf-inet-types:ipv4-address +--ro mcast-group? ietf-routing-types:ipv4-multicast-group-address Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
This is all stub callbacks autogenrated for zebra interface state data. Signed-off-by: chirag Shah <chirag@cumulusnetworks.com>
Remove gcc 4.x workaround for variable size array as gcc check moved to header file. In lib/northbound.h : struct frr_yang_module_info made size 1000 for gcc 4.x, where maximum 1000 nodes can fit. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
3ab2ae8
to
a8c42c4
Compare
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11620/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
Signed-off-by: Chirag Shah chirag@cumulusnetworks.com