Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nhg ip #5669

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Nhg ip #5669

merged 3 commits into from
Jan 31, 2020

Conversation

donaldsharp
Copy link
Member

No description provided.

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/daf918bcaf3d1bbca364bf85a849ddb2/raw/47b974f2be61f7bcec9008dda0b54ff34f21f45e/cr_5669_1578950346.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index de98ad629..41fa8c1cc 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1386,25 +1386,22 @@ static int show_nexthop_group_helper(struct vty *vty, uint32_t id,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group_vrf,
-       show_nexthop_group_vrf_cmd,
-       "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group_vrf, show_nexthop_group_vrf_cmd,
+      "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n" VRF_FULL_CMD_HELP_STR)
 {
 	return show_nexthop_group_helper(vty, id, vrf_all, vrf_name);
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n")
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n")
 {
 	return show_nexthop_group_helper(vty, id, NULL, VRF_DEFAULT_NAME);
 }

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 13, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5669 5c62841
Date 01/13/2020
Start 16:20:30
Finish 16:46:35
Run-Time 26:05
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-13-16:20:30.txt
Log autoscript-2020-01-13-16:21:28.log.bz2
Memory 421 433 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10384/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10384/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
IPv4 ldp protocol on Ubuntu 16.04: Failed (click for details)
Successful on other platforms
  • Topotest tests on Ubuntu 16.04 i386
  • Debian 10 deb pkg check
  • Ubuntu 14.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 16.04 amd64
  • Fedora 29 rpm pkg check
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • Topology tests on Ubuntu 18.04 amd64
  • IPv6 protocols on Ubuntu 14.04

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 4112bfe
  • Base image data for Git 4112bfe does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10384/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/87c0c5acaa8ac0e3bca67b071565765c/raw/47b974f2be61f7bcec9008dda0b54ff34f21f45e/cr_5669_1579094938.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index de98ad629..41fa8c1cc 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1386,25 +1386,22 @@ static int show_nexthop_group_helper(struct vty *vty, uint32_t id,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group_vrf,
-       show_nexthop_group_vrf_cmd,
-       "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group_vrf, show_nexthop_group_vrf_cmd,
+      "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n" VRF_FULL_CMD_HELP_STR)
 {
 	return show_nexthop_group_helper(vty, id, vrf_all, vrf_name);
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n")
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n")
 {
 	return show_nexthop_group_helper(vty, id, NULL, VRF_DEFAULT_NAME);
 }

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 15, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5669 bd591b2
Date 01/15/2020
Start 09:02:13
Finish 09:28:15
Run-Time 26:02
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-15-09:02:13.txt
Log autoscript-2020-01-15-09:03:14.log.bz2
Memory 415 432 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10425/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA f014634
  • Base image data for Git f014634 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10425/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/699d9a650be1f6c09175118c32e97588/raw/47b974f2be61f7bcec9008dda0b54ff34f21f45e/cr_5669_1579227144.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index de98ad629..41fa8c1cc 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1386,25 +1386,22 @@ static int show_nexthop_group_helper(struct vty *vty, uint32_t id,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group_vrf,
-       show_nexthop_group_vrf_cmd,
-       "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group_vrf, show_nexthop_group_vrf_cmd,
+      "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n" VRF_FULL_CMD_HELP_STR)
 {
 	return show_nexthop_group_helper(vty, id, vrf_all, vrf_name);
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n")
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n")
 {
 	return show_nexthop_group_helper(vty, id, NULL, VRF_DEFAULT_NAME);
 }

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 17, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5604 0beeb67
Date 01/01/2020
Start 21:15:21
Finish 21:41:22
Run-Time 26:01
Total 1815
Pass 1814
Fail 1
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-01-21:15:21.txt
Log autoscript-2020-01-01-21:16:15.log.bz2
Memory 433 433 360
SUCCESS git merge/5669 028f052 SUCCESS git merge/5022 2f5a824
01/16/2020 09/19/2019
21:15:29 21:15:21
21:41:26 21:37:01
25:57 21:40
1815 1815
1815 1815
0 0
0 0
0 0
vncregress-2020-01-16-21:15:29.txt vncregress-2019-09-19-21:15:21.txt
autoscript-2020-01-16-21:16:26.log.bz2 autoscript-2019-09-19-21:16:12.log.bz2
416 434 360 410 435 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-10472/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2020-01-16 18:36:50,050 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
*** defaultIntf: warning: r1 has no interfaces
2020-01-16 19:17:07,477 ERROR: '_bgp_has_routes' failed after 38.33 seconds
2020-01-16 19:23:43,862 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-16 19:23:43,983 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-16 19:23:44,107 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-16 19:23:44,229 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-16 19:25:46,178 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-10472/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2020-01-16 18:36:51,888 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
2020-01-16 19:18:04,430 ERROR: '_bgp_has_routes' failed after 39.34 seconds
2020-01-16 19:24:39,880 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-16 19:24:40,020 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-16 19:24:40,159 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-16 19:24:40,318 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-16 19:26:56,126 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10472/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2020-01-17 02:36:56,138 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
*** defaultIntf: warning: r1 has no interfaces
2020-01-17 03:16:55,038 ERROR: '_bgp_has_routes' failed after 38.09 seconds
2020-01-17 03:24:40,722 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-17 03:24:40,848 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-17 03:24:40,989 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-17 03:24:41,114 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-17 03:26:40,172 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • Debian 9 deb pkg check
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Fedora 29 rpm pkg check
  • Ubuntu 12.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOI386/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 8ad8599
  • Base image data for Git 8ad8599 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10472/artifact/shared/static_analysis/index.html

@donaldsharp
Copy link
Member Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10486/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2020-01-18 17:49:57,625 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
*** defaultIntf: warning: r1 has no interfaces
2020-01-18 18:30:19,615 ERROR: '_bgp_has_routes' failed after 38.97 seconds
2020-01-18 18:38:23,004 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-18 18:38:23,134 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-18 18:38:23,266 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-18 18:38:23,392 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-18 18:40:30,086 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1804/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-10486/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2020-01-18 09:50:46,934 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
*** defaultIntf: warning: r1 has no interfaces
2020-01-18 10:32:31,055 ERROR: '_bgp_has_routes' failed after 39.67 seconds
2020-01-18 10:39:15,307 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-18 10:39:15,463 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-18 10:39:15,610 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-18 10:39:15,750 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-18 10:41:31,249 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOU1604/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-10486/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2020-01-18 09:49:56,849 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups": Nexthop Group ID=83 not marked Valid
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
2020-01-18 10:31:32,624 ERROR: '_bgp_has_routes' failed after 39.53 seconds
2020-01-18 10:38:22,646 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-01-18 10:38:22,793 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-01-18 10:38:22,939 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-01-18 10:38:23,093 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-01-18 10:40:29,989 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 1514, in create_bgp_community_lists
    build=build)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 236, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/lib/common_config.py", line 389, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms
  • CentOS 7 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Debian 10 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Debian 9 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Static analyzer (clang)

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOU1804/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/TOPOI386/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 8ad8599
  • Base image data for Git 8ad8599 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10486/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/9e23a2903ea4edfa63633edb5da550a5/raw/ac828f29ff2f191be5dbde455472d5d4ca681e74/cr_5669_1580235866.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 9858a39fa..16abbacc7 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1345,14 +1345,12 @@ DEFPY (show_interface_nexthop_group,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n" VRF_FULL_CMD_HELP_STR)
 {
 
 	struct zebra_vrf *zvrf = NULL;
@@ -1361,7 +1359,8 @@ DEFPY (show_nexthop_group,
 		return show_nexthop_group_id_cmd_helper(vty, id);
 
 	if (vrf_is_backend_netns() && (vrf_name || vrf_all)) {
-		vty_out(vty, "VRF subcommand does not make any sense in l3mdev based vrf's");
+		vty_out(vty,
+			"VRF subcommand does not make any sense in l3mdev based vrf's");
 		return CMD_WARNING;
 	}
 

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 28, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5669 49a2f02
Date 01/28/2020
Start 13:25:28
Finish 13:51:30
Run-Time 26:02
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-28-13:25:28.txt
Log autoscript-2020-01-28-13:26:27.log.bz2
Memory 431 436 363

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10553/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for zebra_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1364: FILE: /tmp/f1-24403/zebra_vty.c:1364:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10553/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200128-04-g49a2f0223-0 (missing) -> 7.4-dev-20200128-04-g49a2f0223-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200128-04-g49a2f0223-0 (missing) -> 7.4-dev-20200128-04-g49a2f0223-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200128-04-g49a2f0223-0 (missing) -> 7.4-dev-20200128-04-g49a2f0223-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200128-04-g49a2f0223-0 (missing) -> 7.4-dev-20200128-04-g49a2f0223-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200128-04-g49a2f0223-0 (missing) -> 7.4-dev-20200128-04-g49a2f0223-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 64d50ba
  • Base image data for Git 64d50ba does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10553/artifact/shared/static_analysis/index.html

@donaldsharp
Copy link
Member Author

@riw777 @mjstapp anything else needed here? I'd like to get this in so I can get this into 7.3 as well.

else if (v6)
afi = AFI_IP6;
if (vrf_is_backend_netns() && (vrf_name || vrf_all)) {
vty_out(vty, "VRF subcommand does not make any sense in l3mdev based vrf's");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a terminating newline? and aren't errors usually preceded with "%% - or is that not a convention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't a newline ... reasonable?

the bigger question is the one about the treatment of singleton nhes - it does seem (to me) ok to want to see them by vrf. is there a specific problem introduced by offering that filter?

@@ -591,10 +589,11 @@ zebra_nhg_find_nexthop(uint32_t id, struct nexthop *nh, afi_t afi, int type)
{
struct nhg_hash_entry *nhe = NULL;
struct nexthop_group nhg = {};
vrf_id_t vrf_id = !vrf_is_backend_netns() ? VRF_DEFAULT : nh->vrf_id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble following this: don't we have to include the nexthop's vrf in this lookup? I agree that it's awkward that sometimes there's a value in an nhe that's copied out of a single nexthop, and sometimes not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nexthop groups are namespace based not vrf based. So if you are not using namespaced backends for a vrf you need to make this distinction. Else you end up with a some scenarios where we are reporting a nexthop group in VRF X and that means nothing if you are using l3mdev's. I would rather just say they are in the default vrf.

@donaldsharp
Copy link
Member Author

offline conversation w/ Mark summary:

  1. put in a `show nexthop-group rib singletion [v4|v6] instead of removing v4 v6 to allow us to look at the underlying data structures instead of removing the v4|v6 as I did.
  2. There are 2 places where we were storing the nexthop groups vrf and we were grabbing this data from the first nexthop in the group. This is fundamentally wrong and means nothing.

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/c5227a50146358446abae690152a0c71/raw/ffbada57a090afc9d033dab963e618c3a7796a93/cr_5669_1580403541.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 78001da17..101f0e8bc 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1349,17 +1349,13 @@ DEFPY (show_interface_nexthop_group,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id|[singleton <ip$v4|ipv6$v6>] [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       "Show Singleton Nexthop-Groups\n"
-       IP_STR
-       IP6_STR
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id|[singleton <ip$v4|ipv6$v6>] [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n"
+      "Show Singleton Nexthop-Groups\n" IP_STR IP6_STR VRF_FULL_CMD_HELP_STR)
 {
 
 	struct zebra_vrf *zvrf = NULL;
@@ -1374,7 +1370,8 @@ DEFPY (show_nexthop_group,
 		afi = AFI_IP6;
 
 	if (vrf_is_backend_netns() && (vrf_name || vrf_all)) {
-		vty_out(vty, "VRF subcommand does not make any sense in l3mdev based vrf's");
+		vty_out(vty,
+			"VRF subcommand does not make any sense in l3mdev based vrf's");
 		return CMD_WARNING;
 	}
 

If you are a new contributor to FRR, please see our contributing guidelines.

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10568/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: No useful log found
Successful on other platforms
  • NetBSD 8 amd64 build
  • Ubuntu 16.04 i386 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 18.04 amd64 build
  • NetBSD 6 amd64 build
  • CentOS 7 amd64 build
  • Debian 9 amd64 build
  • Debian 8 amd64 build
  • Ubuntu 12.04 amd64 build
  • Ubuntu 14.04 amd64 build
  • Ubuntu 18.04 ppc64le build
  • OpenBSD 6 amd64 build
  • Fedora 29 amd64 build
  • Debian 10 amd64 build
  • FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: No useful log found
Report for zebra_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1377: FILE: /tmp/f1-19503/zebra_vty.c:1377:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10568/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 30, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5669 610021d
Date 01/30/2020
Start 12:00:29
Finish 12:26:21
Run-Time 25:52
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-30-12:00:29.txt
Log autoscript-2020-01-30-12:01:28.log.bz2
Memory 437 408 363

For details, please contact louberger

@donaldsharp
Copy link
Member Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10570/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for zebra_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1377: FILE: /tmp/f1-17560/zebra_vty.c:1377:

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 64d50ba
  • Base image data for Git 64d50ba does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10570/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10568/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for zebra_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1377: FILE: /tmp/f1-19503/zebra_vty.c:1377:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10568/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200130-02-g610021d58-0 (missing) -> 7.4-dev-20200130-02-g610021d58-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 5669, comparing to Git base SHA 64d50ba
  • Base image data for Git 64d50ba does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10568/artifact/shared/static_analysis/index.html

The zebra implementation of nexthop groups has
two types of nexthops groups currently.  Singleton
objects which have afi's and combined nexthop groups
that do not.  Specifically call this out in the code
to make this distinction.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Nexthop groups as a whole do not make sense to have a vrf'ness
As that you can have a arbitrary number of nexthops that point
to separate vrf's.

Modify the code to make this distinction, by clearly delineating
the line between the nhg and the nexthop a bit better.
Nexthop groups having a vrf_id only make sense if you are using
network namespaces to represent them.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/840d3830238356a6711635ae6de41502/raw/ffbada57a090afc9d033dab963e618c3a7796a93/cr_5669_1580478366.diff | git apply

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 78001da17..101f0e8bc 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1349,17 +1349,13 @@ DEFPY (show_interface_nexthop_group,
 	return CMD_SUCCESS;
 }
 
-DEFPY (show_nexthop_group,
-       show_nexthop_group_cmd,
-       "show nexthop-group rib <(0-4294967295)$id|[singleton <ip$v4|ipv6$v6>] [vrf <NAME$vrf_name|all$vrf_all>]>",
-       SHOW_STR
-       "Show Nexthop Groups\n"
-       "RIB information\n"
-       "Nexthop Group ID\n"
-       "Show Singleton Nexthop-Groups\n"
-       IP_STR
-       IP6_STR
-       VRF_FULL_CMD_HELP_STR)
+DEFPY(show_nexthop_group, show_nexthop_group_cmd,
+      "show nexthop-group rib <(0-4294967295)$id|[singleton <ip$v4|ipv6$v6>] [vrf <NAME$vrf_name|all$vrf_all>]>",
+      SHOW_STR
+      "Show Nexthop Groups\n"
+      "RIB information\n"
+      "Nexthop Group ID\n"
+      "Show Singleton Nexthop-Groups\n" IP_STR IP6_STR VRF_FULL_CMD_HELP_STR)
 {
 
 	struct zebra_vrf *zvrf = NULL;
@@ -1374,7 +1370,8 @@ DEFPY (show_nexthop_group,
 		afi = AFI_IP6;
 
 	if (vrf_is_backend_netns() && (vrf_name || vrf_all)) {
-		vty_out(vty, "VRF subcommand does not make any sense in l3mdev based vrf's");
+		vty_out(vty,
+			"VRF subcommand does not make any sense in l3mdev based vrf's");
 		return CMD_WARNING;
 	}
 

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 31, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5669 083954e
Date 01/31/2020
Start 09:34:04
Finish 10:00:08
Run-Time 26:04
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-31-09:34:04.txt
Log autoscript-2020-01-31-09:35:04.log.bz2
Memory 415 440 363

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10580/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for zebra_vty.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1377: FILE: /tmp/f1-10858/zebra_vty.c:1377:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10580/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200131-03-g083954e9d-0 (missing) -> 7.4-dev-20200131-03-g083954e9d-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200131-03-g083954e9d-0 (missing) -> 7.4-dev-20200131-03-g083954e9d-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200131-03-g083954e9d-0 (missing) -> 7.4-dev-20200131-03-g083954e9d-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200131-03-g083954e9d-0 (missing) -> 7.4-dev-20200131-03-g083954e9d-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200131-03-g083954e9d-0 (missing) -> 7.4-dev-20200131-03-g083954e9d-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

@mjstapp mjstapp merged commit 84e1268 into FRRouting:master Jan 31, 2020
@donaldsharp donaldsharp deleted the nhg_ip branch June 23, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants