Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add instructions for static linking #5668

Merged
merged 1 commit into from
Jan 20, 2020
Merged

doc: add instructions for static linking #5668

merged 1 commit into from
Jan 20, 2020

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Jan 13, 2020

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 13, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5668 eee3d41
Date 01/13/2020
Start 11:50:22
Finish 12:16:15
Run-Time 25:53
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-13-11:50:22.txt
Log autoscript-2020-01-13-11:51:18.log.bz2
Memory 433 428 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
Successful on other platforms
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 10 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 18.04 amd64
  • Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

1 similar comment
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
Successful on other platforms
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 10 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 18.04 amd64
  • Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10381/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200113-00-geee3d415e-0 (missing) -> 7.3-dev-20200113-00-geee3d415e-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

@eqvinox eqvinox self-requested a review January 14, 2020 16:19
qlyoung
qlyoung commented Jan 14, 2020
View reviewed changes
doc/developer/static-linking.rst Outdated
set(CMAKE_EXE_LINK_DYNAMIC_C_FLAGS) # remove -Wl,-Bdynamic
set(CMAKE_EXE_LINK_DYNAMIC_CXX_FLAGS)
+ set(CMAKE_POSITION_INDEPENDENT_CODE TRUE)
add_library(yang STATIC ${libsrc})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any cmake people know if this can be set from the command line, a la -D?

@qlyoung
doc: add instructions for static linking
cce3ef3 
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@qlyoung qlyoung force-pushed the doc-static-linking branch from eee3d41 to cce3ef3 Compare January 16, 2020 17:47
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jan 16, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5668 cce3ef3
Date 01/16/2020
Start 13:42:00
Finish 14:08:04
Run-Time 26:04
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-01-16-13:42:00.txt
Log autoscript-2020-01-16-13:42:57.log.bz2
Memory 436 429 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10454/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CentOS 7 rpm pkg check: Failed (click for details) CentOS 7 rpm pkg check: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10454/artifact/CENTOS7RPM/ErrorLog/log_restart.txt CentOS 7 rpm pkg check: No useful log found
Successful on other platforms
  • Topology tests on Ubuntu 18.04 amd64
  • IPv6 protocols on Ubuntu 14.04
  • Debian 10 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Debian 9 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • Static analyzer (clang)
<TITLE>clang_check</TITLE>

clang_check

@eqvinox eqvinox merged commit a5586bb into FRRouting:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqvinox eqvinox eqvinox left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qlyoung @LabN-CI @NetDEF-CI @eqvinox @polychaeta