Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] ldpd: add missing sanity check in the parsing of label messages #5338

Merged

Conversation

rwestphal
Copy link
Member

Validate that the FEC prefix length is within the allowed limit
(depending on the FEC address family) in order to prevent possible
buffer overflows in the ldpe child process.

Signed-off-by: Renato Westphal renato@opensourcerouting.org

Validate that the FEC prefix length is within the allowed limit
(depending on the FEC address family) in order to prevent possible
buffer overflows.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@polychaeta polychaeta added the ldp label Nov 14, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 14, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result FAILURE git master f935dca frr.github Build
Date 10/23/2019
Start 20:20:14
Finish 20:21:02
Run-Time 00:48
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details vncregress-2019-10-23-20:20:14.txt
Log make-2019-10-23-20:20:14.out.bz2
Memory
SUCCESS git merge/5338 80ecb9c SUCCESS git merge/4975 4e5441e
11/13/2019 09/12/2019
20:20:11 20:20:16
20:45:55 20:42:04
25:44 21:48
1815 1815
1815 1815
0 0
0 0
0 0
vncregress-2019-11-13-20:20:11.txt vncregress-2019-09-12-20:20:16.txt
autoscript-2019-11-13-20:20:58.log.bz2 autoscript-2019-09-12-20:21:04.log.bz2
442 437 366 425 421 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9699/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 5338, comparing to Git base SHA 516f219

No Changes in Static Analysis warnings compared to base

67 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9699/artifact/shared/static_analysis/index.html

@srimohans srimohans merged commit 48ff241 into FRRouting:stable/7.0 Nov 15, 2019
@eqvinox eqvinox deleted the ldpd-buffer-overflow-7.0 branch April 18, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants