Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpki Encapsulation #5015

Merged
merged 22 commits into from
Jul 14, 2020
Merged

Conversation

pguibert6WIND
Copy link
Member

This set of commits fixes some rpki issues.
on top of that, it encapsulated all global variables of rpki into a sub structure.
this work is preparatory work for:

  • yang nb api ( assuming rpki will be instantiated per vrf)
  • vrf support ( assuming rtrlib will be vrf aware at one point)

@polychaeta polychaeta added the bgp label Sep 19, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 19, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 b4e68b5
Date 09/19/2019
Start 04:50:25
Finish 05:12:11
Run-Time 21:46
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-19-04:50:25.txt
Log autoscript-2019-09-19-04:51:15.log.bz2
Memory 430 425 360

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 20, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 75040f3
Date 09/20/2019
Start 10:22:11
Finish 10:43:59
Run-Time 21:48
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-20-10:22:11.txt
Log autoscript-2019-09-20-10:23:02.log.bz2
Memory 442 435 359

For details, please contact louberger

@pguibert6WIND
Copy link
Member Author

ci:rerun

@FRRouting FRRouting deleted a comment from NetDEF-CI Sep 20, 2019
@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 20, 2019

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 14.04 amd64 build: Failed (click for details) Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI001BUILD/config.status/config.status

Package building failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI001BUILD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function 'install_cli_commands':
bgpd/bgp_rpki.c:1789:1: error: expected expression before '<<' token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before '>>' token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI014BUILD/config.status/config.status

Package building failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI014BUILD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: expected expression before << token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before >> token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804AMD64/config.status/config.status

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1604I386/config.status/config.status

Package building failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1604I386/ErrorLog/log_package_build.txt)

                            ^
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: expected expression before << token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before >> token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Debian 8 amd64 build: Failed (click for details) Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI008BLD/config.status/config.status

Package building failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI008BLD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function 'install_cli_commands':
bgpd/bgp_rpki.c:1789:1: error: expected expression before '<<' token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before '>>' token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI021BUILD/config.status/config.status

Package building failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI021BUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Successful on other platforms
  • Ubuntu 12.04 amd64 build
  • Fedora 29 amd64 build
  • FreeBSD 12 amd64 build
  • FreeBSD 11 amd64 build
  • NetBSD 6 amd64 build
  • CentOS 7 amd64 build
  • OpenBSD 6 amd64 build
  • NetBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
Debian 10 amd64 build: Failed (click for details) Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 14.04 amd64 build: Failed (click for details) Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI001BUILD/config.status/config.status

Package building failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI001BUILD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function 'install_cli_commands':
bgpd/bgp_rpki.c:1789:1: error: expected expression before '<<' token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before '>>' token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI014BUILD/config.status/config.status

Package building failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI014BUILD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: expected expression before << token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before >> token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804AMD64/config.status/config.status

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1604I386/config.status/config.status

Package building failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1604I386/ErrorLog/log_package_build.txt)

                            ^
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: expected expression before << token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before >> token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Debian 8 amd64 build: Failed (click for details) Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI008BLD/config.status/config.status

Package building failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI008BLD/ErrorLog/log_package_build.txt)

              ^
bgpd/bgp_rpki.c: In function 'install_cli_commands':
bgpd/bgp_rpki.c:1789:1: error: expected expression before '<<' token
 <<<<<<< HEAD
 ^
bgpd/bgp_rpki.c:1793:1: error: expected expression before '>>' token
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI021BUILD/config.status/config.status

Package building failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8981/artifact/CI021BUILD/ErrorLog/log_package_build.txt)

              ^~~~~~~
bgpd/bgp_rpki.c: In function install_cli_commands:
bgpd/bgp_rpki.c:1789:1: error: version control conflict marker in file
 <<<<<<< HEAD
 ^~~~~~~
bgpd/bgp_rpki.c:1793:1: error: version control conflict marker in file
 >>>>>>> 0b3c199292ed... bgpd: ability to remove rpki contexts from vty
 ^~~~~~~
bgpd/bgp_rpki.c:1793:9: error: invalid suffix "b3c199292ed..." on integer constant
Report for bgp_rpki.c | 64 issues
===============================================
< WARNING: line over 80 characters
< #137: FILE: /tmp/f1-30400/bgp_rpki.c:137:
< WARNING: line over 80 characters
< #138: FILE: /tmp/f1-30400/bgp_rpki.c:138:
< WARNING: line over 80 characters
< #286: FILE: /tmp/f1-30400/bgp_rpki.c:286:
< WARNING: line over 80 characters
< #351: FILE: /tmp/f1-30400/bgp_rpki.c:351:
< WARNING: line over 80 characters
< #388: FILE: /tmp/f1-30400/bgp_rpki.c:388:
< WARNING: line over 80 characters
< #401: FILE: /tmp/f1-30400/bgp_rpki.c:401:
< WARNING: line over 80 characters
< #518: FILE: /tmp/f1-30400/bgp_rpki.c:518:
< WARNING: line over 80 characters
< #522: FILE: /tmp/f1-30400/bgp_rpki.c:522:
< WARNING: void function return statements are not generally useful
< #617: FILE: /tmp/f1-30400/bgp_rpki.c:617:
< WARNING: line over 80 characters
< #662: FILE: /tmp/f1-30400/bgp_rpki.c:662:
< WARNING: line over 80 characters
< #864: FILE: /tmp/f1-30400/bgp_rpki.c:864:
< WARNING: line over 80 characters
< #875: FILE: /tmp/f1-30400/bgp_rpki.c:875:
< WARNING: line over 80 characters
< #883: FILE: /tmp/f1-30400/bgp_rpki.c:883:
< WARNING: line over 80 characters
< #921: FILE: /tmp/f1-30400/bgp_rpki.c:921:
< WARNING: line over 80 characters
< #1020: FILE: /tmp/f1-30400/bgp_rpki.c:1020:
< WARNING: line over 80 characters
< #1022: FILE: /tmp/f1-30400/bgp_rpki.c:1022:
< WARNING: line over 80 characters
< #1024: FILE: /tmp/f1-30400/bgp_rpki.c:1024:
< WARNING: Missing a blank line after declarations
< #1306: FILE: /tmp/f1-30400/bgp_rpki.c:1306:
< WARNING: line over 80 characters
< #1310: FILE: /tmp/f1-30400/bgp_rpki.c:1310:
< WARNING: suspect code indent for conditional statements (24, 28)
< #1327: FILE: /tmp/f1-30400/bgp_rpki.c:1327:
< WARNING: line over 80 characters
< #1345: FILE: /tmp/f1-30400/bgp_rpki.c:1345:
< WARNING: Missing a blank line after declarations
< #1370: FILE: /tmp/f1-30400/bgp_rpki.c:1370:
< WARNING: line over 80 characters
< #1382: FILE: /tmp/f1-30400/bgp_rpki.c:1382:
< WARNING: line over 80 characters
< #1465: FILE: /tmp/f1-30400/bgp_rpki.c:1465:
< WARNING: line over 80 characters
< #1550: FILE: /tmp/f1-30400/bgp_rpki.c:1550:
< ERROR: spaces required around that '<' (ctx:OxW)
< #1789: FILE: /tmp/f1-30400/bgp_rpki.c:1789:
< ERROR: spaces required around that '==' (ctx:ExO)
< #1790: FILE: /tmp/f1-30400/bgp_rpki.c:1790:
< ERROR: spaces required around that '==' (ctx:OxO)
< #1790: FILE: /tmp/f1-30400/bgp_rpki.c:1790:
< ERROR: spaces required around that '==' (ctx:OxO)
< #1790: FILE: /tmp/f1-30400/bgp_rpki.c:1790:
< ERROR: spaces required around that '=' (ctx:OxE)
< #1790: FILE: /tmp/f1-30400/bgp_rpki.c:1790:
< ERROR: spaces required around that '>' (ctx:OxW)
< #1793: FILE: /tmp/f1-30400/bgp_rpki.c:1793:
< ERROR: spaces required around that ':' (ctx:VxW)
< #1793: FILE: /tmp/f1-30400/bgp_rpki.c:1793:

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 20, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8987/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 50 issues
===============================================
< WARNING: line over 80 characters
< #137: FILE: /tmp/f1-29967/bgp_rpki.c:137:
< WARNING: line over 80 characters
< #138: FILE: /tmp/f1-29967/bgp_rpki.c:138:
< WARNING: line over 80 characters
< #286: FILE: /tmp/f1-29967/bgp_rpki.c:286:
< WARNING: line over 80 characters
< #351: FILE: /tmp/f1-29967/bgp_rpki.c:351:
< WARNING: line over 80 characters
< #388: FILE: /tmp/f1-29967/bgp_rpki.c:388:
< WARNING: line over 80 characters
< #401: FILE: /tmp/f1-29967/bgp_rpki.c:401:
< WARNING: line over 80 characters
< #517: FILE: /tmp/f1-29967/bgp_rpki.c:517:
< WARNING: line over 80 characters
< #521: FILE: /tmp/f1-29967/bgp_rpki.c:521:
< WARNING: void function return statements are not generally useful
< #616: FILE: /tmp/f1-29967/bgp_rpki.c:616:
< WARNING: line over 80 characters
< #661: FILE: /tmp/f1-29967/bgp_rpki.c:661:
< WARNING: line over 80 characters
< #863: FILE: /tmp/f1-29967/bgp_rpki.c:863:
< WARNING: line over 80 characters
< #874: FILE: /tmp/f1-29967/bgp_rpki.c:874:
< WARNING: line over 80 characters
< #882: FILE: /tmp/f1-29967/bgp_rpki.c:882:
< WARNING: line over 80 characters
< #920: FILE: /tmp/f1-29967/bgp_rpki.c:920:
< WARNING: line over 80 characters
< #1019: FILE: /tmp/f1-29967/bgp_rpki.c:1019:
< WARNING: line over 80 characters
< #1021: FILE: /tmp/f1-29967/bgp_rpki.c:1021:
< WARNING: line over 80 characters
< #1023: FILE: /tmp/f1-29967/bgp_rpki.c:1023:
< WARNING: Missing a blank line after declarations
< #1305: FILE: /tmp/f1-29967/bgp_rpki.c:1305:
< WARNING: line over 80 characters
< #1309: FILE: /tmp/f1-29967/bgp_rpki.c:1309:
< WARNING: suspect code indent for conditional statements (24, 28)
< #1326: FILE: /tmp/f1-29967/bgp_rpki.c:1326:
< WARNING: line over 80 characters
< #1344: FILE: /tmp/f1-29967/bgp_rpki.c:1344:
< WARNING: Missing a blank line after declarations
< #1369: FILE: /tmp/f1-29967/bgp_rpki.c:1369:
< WARNING: line over 80 characters
< #1381: FILE: /tmp/f1-29967/bgp_rpki.c:1381:
< WARNING: line over 80 characters
< #1464: FILE: /tmp/f1-29967/bgp_rpki.c:1464:
< WARNING: line over 80 characters
< #1549: FILE: /tmp/f1-29967/bgp_rpki.c:1549:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 0eb194f

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8987/artifact/shared/static_analysis/index.html

@pguibert6WIND pguibert6WIND force-pushed the rpki_vrf_encapsulation branch 2 times, most recently from 53a24f3 to 9d4286e Compare September 23, 2019 07:12
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 23, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 9d4286e
Date 09/23/2019
Start 03:15:26
Finish 03:37:10
Run-Time 21:44
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-23-03:15:26.txt
Log autoscript-2019-09-23-03:16:16.log.bz2
Memory 435 413 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 23, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8990/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 26 issues
===============================================
< WARNING: void function return statements are not generally useful
< #622: FILE: /tmp/f1-13056/bgp_rpki.c:622:
< WARNING: quoted string split across lines
< #659: FILE: /tmp/f1-13056/bgp_rpki.c:659:
< WARNING: line over 80 characters
< #870: FILE: /tmp/f1-13056/bgp_rpki.c:870:
< WARNING: line over 80 characters
< #890: FILE: /tmp/f1-13056/bgp_rpki.c:890:
< WARNING: line over 80 characters
< #1028: FILE: /tmp/f1-13056/bgp_rpki.c:1028:
< WARNING: line over 80 characters
< #1030: FILE: /tmp/f1-13056/bgp_rpki.c:1030:
< WARNING: line over 80 characters
< #1032: FILE: /tmp/f1-13056/bgp_rpki.c:1032:
< WARNING: quoted string split across lines
< #1122: FILE: /tmp/f1-13056/bgp_rpki.c:1122:
< WARNING: break quoted strings at a space character
< #1122: FILE: /tmp/f1-13056/bgp_rpki.c:1122:
< WARNING: Missing a blank line after declarations
< #1314: FILE: /tmp/f1-13056/bgp_rpki.c:1314:
< WARNING: quoted string split across lines
< #1322: FILE: /tmp/f1-13056/bgp_rpki.c:1322:
< WARNING: suspect code indent for conditional statements (24, 28)
< #1336: FILE: /tmp/f1-13056/bgp_rpki.c:1336:
< WARNING: Missing a blank line after declarations
< #1380: FILE: /tmp/f1-13056/bgp_rpki.c:1380:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 7d7828c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8990/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 23, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8991/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 10 issues
===============================================
< WARNING: quoted string split across lines
< #659: FILE: /tmp/f1-22277/bgp_rpki.c:659:
< WARNING: Missing a blank line after declarations
< #665: FILE: /tmp/f1-22277/bgp_rpki.c:665:
< WARNING: quoted string split across lines
< #1126: FILE: /tmp/f1-22277/bgp_rpki.c:1126:
< WARNING: quoted string split across lines
< #1327: FILE: /tmp/f1-22277/bgp_rpki.c:1327:
< WARNING: suspect code indent for conditional statements (24, 28)
< #1341: FILE: /tmp/f1-22277/bgp_rpki.c:1341:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 7d7828c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8991/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 23, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 f308689
Date 09/23/2019
Start 05:00:27
Finish 05:22:11
Run-Time 21:44
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-23-05:00:27.txt
Log autoscript-2019-09-23-05:01:20.log.bz2
Memory 425 436 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 23, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8993/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 8 issues
===============================================
< WARNING: quoted string split across lines
< #659: FILE: /tmp/f1-22144/bgp_rpki.c:659:
< WARNING: quoted string split across lines
< #1127: FILE: /tmp/f1-22144/bgp_rpki.c:1127:
< WARNING: quoted string split across lines
< #1328: FILE: /tmp/f1-22144/bgp_rpki.c:1328:
< WARNING: line over 80 characters
< #1343: FILE: /tmp/f1-22144/bgp_rpki.c:1343:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 7d7828c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8993/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 23, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 15283b7
Date 09/23/2019
Start 09:20:27
Finish 09:42:04
Run-Time 21:37
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-23-09:20:27.txt
Log autoscript-2019-09-23-09:21:17.log.bz2
Memory 420 408 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 23, 2019

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8995/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-BGP4-21.4 failing:
Test Summary
Start event is ignored in the OpenSent state.
Test Reference
RFC4271, Sect. 8.2.2, p 63,
BGP Finite State machine
Test Classification
MUST
Test ANVL-BGP4-21.4: !FAILED!
External peer failed to open TCP connection
with DUT through

IPv6 protocols on Ubuntu 14.04: Failed (click for details)
Successful on other platforms
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 9 deb pkg check
  • Fedora 29 rpm pkg check
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Topology tests on Ubuntu 18.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
IPv4 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-BGP4-21.4 failing:
Test Summary
Start event is ignored in the OpenSent state.
Test Reference
RFC4271, Sect. 8.2.2, p 63,
BGP Finite State machine
Test Classification
MUST
Test ANVL-BGP4-21.4: !FAILED!
External peer failed to open TCP connection
with DUT through

IPv6 protocols on Ubuntu 14.04: Failed (click for details)
Report for bgp_rpki.c | 6 issues
===============================================
< WARNING: quoted string split across lines
< #659: FILE: /tmp/f1-10735/bgp_rpki.c:659:
< WARNING: quoted string split across lines
< #1127: FILE: /tmp/f1-10735/bgp_rpki.c:1127:
< WARNING: quoted string split across lines
< #1328: FILE: /tmp/f1-10735/bgp_rpki.c:1328:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 7d7828c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8995/artifact/shared/static_analysis/index.html

@pguibert6WIND
Copy link
Member Author

ci:rerun

@pguibert6WIND
Copy link
Member Author

That pull request does not have rpki vrf-aware feature yet.
However, this work can be reviewed for being merged, as first step.

Then a 2nd series of commits will come with rtrlib adaptation.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 24, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9021/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 6 issues
===============================================
< WARNING: quoted string split across lines
< #659: FILE: /tmp/f1-26165/bgp_rpki.c:659:
< WARNING: quoted string split across lines
< #1127: FILE: /tmp/f1-26165/bgp_rpki.c:1127:
< WARNING: quoted string split across lines
< #1328: FILE: /tmp/f1-26165/bgp_rpki.c:1328:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA 7d7828c

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9021/artifact/shared/static_analysis/index.html

@riw777 riw777 self-requested a review October 15, 2019 15:32
Copy link
Contributor

@mroethke mroethke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine in general to me, but I commented on a few thinkgs.

Furthermore can someone explain the qobj stuff and why it is necessary here? I looked the the header and the early commits of those files, but they did not enlighten me.

And finally I'm not sure it makes sense to merge this without vrf support in rtrlib. Because as far as I understand it would not work. Or am I mistaken here?

ssh_privkey);
if (!strmatch(pub, ssh_pubkey)) {
vty_out(vty,
"ssh public key overriden: %s.pub\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like the key is overridden on disk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you be more specific. do you expect an other message?

@pguibert6WIND
Copy link
Member Author

Hi Marcel,
I plan to bring full vrf support once rtrlib/rtrlib#252 is ok for you.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 21, 2019

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/5015 63b2c60
Date 10/21/2019
Start 12:45:26
Finish 13:07:05
Run-Time 21:39
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-21-12:45:26.txt
Log autoscript-2019-10-21-12:46:14.log.bz2
Memory 432 424 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Oct 21, 2019

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9335/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 6 issues
===============================================
< WARNING: quoted string split across lines
< #656: FILE: /tmp/f1-18550/bgp_rpki.c:656:
< WARNING: quoted string split across lines
< #1124: FILE: /tmp/f1-18550/bgp_rpki.c:1124:
< WARNING: quoted string split across lines
< #1325: FILE: /tmp/f1-18550/bgp_rpki.c:1325:

CLANG Static Analyzer Summary

  • Github Pull Request 5015, comparing to Git base SHA acf061a

Fixed warnings:

  • Dead store: Dead assignment in bgp_evpn.c, function install_evpn_route_entry, line 2612

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 1

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9335/artifact/shared/static_analysis/index.html

if ssh cache servers are configured, then show rpki-table is looking at
the tcp server context. Fix this by checking the server cache type, and
also display the ssh context if this is configured.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
show running-config did not display rpki retry-interval. fixes this.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
a missing command expire-interval was not present in show
running-config.
append it.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
the show running-config rpki was displaying systematically the default
values, when at least one cache server was configured. now, if the rpki
configuration has been changed, either because of a new cache server, or
because of a change in the default settings, then the associated
configuration is dumped in the 'show running-config' command.
adding to this, to permit user to dump the settings values, the command
'show rpki configuration' dumps the values whatever default or not.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
when a plugin is attached, some debugs may be attached to that plugin.
For that, add one hook that is interacting with vty: a boolean indicates
what the usage is for: either for impacting the 'show running-config',
or for impacting the 'show debugging' command.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki debugging is linked with standard bgp debugging facilities.
- debug rpki is dumped in running-config if the command is executed from
configure terminal.
- show debugging indicated whether rpki debug is enabled or not.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this work is a preparatory work so that rpki can have per-vrf contexts.
the work consists in allocating a rpki_vrf structure with all inside:
rtr_config, cache, etc..
This work is also necessary in the long term support with yang
northboundapi. Indeed, there may be highly possible that yang context
for rpki be defined per core instance.
That work also instantiates a list of rpki_vrf, though only one instance
is created.
That work also introduces a vrfname field attribute that is set to null
for now , and stands for default vrf where rpki is configured on.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this command may conflict with the same command available under vrf
subnode.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki_node is a node under configure terminal. as such, align with other
nodes that are similar. Note that this change is important, since the
location where show running-config from vtysh displays rpki
configuration is changed in the middle of the configuration instead of
at the top, before authentication.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki context can be removed by doing 'no rpki' command from configure
node. this work allows to allocate the associated rpki_vrf context when
entering in rpki node, instead of at the initialisation step.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this hook can be used by plugins like rpki.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this commit change introduces a callback function pointer that rtrlib
calls. this permits to create the socket and initialising the socket
with the right information, in the right vrf. Adding to this, rpki uses
a hook to be triggered when a vrf is enabled/disabled. in this way,
start mechanisms will be triggered only when vrf is available, and stop
mechanism will be  done upon vrf disable event.
Adding to this, the cache structure contains a back pointer to the rpki
vrf structure. this is done to retrieve the vrf where the cache points
to.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
it is possible to dump rpki commands per vrf context.
also, rpki start/stop commands are also appended with vrfname parameter.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki vrf subnode is instantiated under the vrf subnode.
It it to be noted that this commit contains a change in vtysh.
Actually, the output of bgp daemon from show running-config is extracted
in vtysh, and reengineered ( hence the vtysh_config.c change done). This
permits having a subnode under vrf sub node.
Also, add vrf node support to bgpd, as rpki command can not be found
under vrf node.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki config can be displayed in the 'show running-config'.
there is a fix to be done yet, this is related to the order of rpki per
vrf configuration. actually, the output is not saveable in the
running-config since the rpki commands are swapped. this prevents from
running rpki config at startup.
That commit also changes the identation, since rpki configure node was
with one extra space. reducing this, and add the changes for vrf
configuration too.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this command permits to stop and flush the rpki contexts for a specific
vrf.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
the validation of rpki routes will impact the matching bgp instance.
Until now, the rpki was triggering validation of all bgp entries.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this extra trace will help to understand which rpki context is
triggered.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rpki per vrf documentation is being added.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
bool format suits better for rtr_is_running and rtr_is_stopped values.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@pguibert6WIND pguibert6WIND force-pushed the rpki_vrf_encapsulation branch from 2868387 to 76ddd87 Compare July 2, 2020 06:18
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 2, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5015 76ddd87
Date 07/02/2020
Start 02:50:37
Finish 03:16:24
Run-Time 25:47
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-07-02-02:50:37.txt
Log autoscript-2020-07-02-02:51:36.log.bz2
Memory 469 499 425

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12938/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_rpki.c | 33 issues
===============================================
< WARNING: externs should be avoided in .c files
< #100: FILE: /tmp/f1-8739/bgp_rpki.c:100:
< WARNING: Missing a blank line after declarations
< #120: FILE: /tmp/f1-8739/bgp_rpki.c:120:
< WARNING: line over 80 characters
< #351: FILE: /tmp/f1-8739/bgp_rpki.c:351:
< WARNING: line over 80 characters
< #366: FILE: /tmp/f1-8739/bgp_rpki.c:366:
< WARNING: line over 80 characters
< #374: FILE: /tmp/f1-8739/bgp_rpki.c:374:
< WARNING: Comparisons should place the constant on the right side of the test
< #374: FILE: /tmp/f1-8739/bgp_rpki.c:374:
< WARNING: line over 80 characters
< #377: FILE: /tmp/f1-8739/bgp_rpki.c:377:
< WARNING: quoted string split across lines
< #838: FILE: /tmp/f1-8739/bgp_rpki.c:838:
< WARNING: line over 80 characters
< #913: FILE: /tmp/f1-8739/bgp_rpki.c:913:
< ERROR: bzero() is deprecated; use memset()#1129: FILE: /tmp/f1-8739/bgp_rpki.c:1129:
< +	bzero(&hints, sizeof(hints));
< 
< WARNING: line over 80 characters
< #1174: FILE: /tmp/f1-8739/bgp_rpki.c:1174:
< WARNING: line over 80 characters
< #1397: FILE: /tmp/f1-8739/bgp_rpki.c:1397:
< WARNING: line over 80 characters
< #1398: FILE: /tmp/f1-8739/bgp_rpki.c:1398:
< WARNING: line over 80 characters
< #1399: FILE: /tmp/f1-8739/bgp_rpki.c:1399:
< WARNING: quoted string split across lines
< #1513: FILE: /tmp/f1-8739/bgp_rpki.c:1513:
< WARNING: quoted string split across lines
< #1758: FILE: /tmp/f1-8739/bgp_rpki.c:1758:
Report for vtysh_config.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #325: FILE: /tmp/f1-8739/vtysh_config.c:325:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12938/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-23-g76ddd87e8-0 (missing) -> 7.5-dev-20200702-23-g76ddd87e8-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-23-g76ddd87e8-0 (missing) -> 7.5-dev-20200702-23-g76ddd87e8-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-23-g76ddd87e8-0 (missing) -> 7.5-dev-20200702-23-g76ddd87e8-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-23-g76ddd87e8-0 (missing) -> 7.5-dev-20200702-23-g76ddd87e8-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-23-g76ddd87e8-0 (missing) -> 7.5-dev-20200702-23-g76ddd87e8-0~deb10u1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants