Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Enhance execution logs in topojson #4852

Merged
merged 1 commit into from
Aug 29, 2019
Merged

tests: Enhance execution logs in topojson #4852

merged 1 commit into from
Aug 29, 2019

Conversation

ashish12pant
Copy link
Contributor

Signed-off-by: Ashish Pant ashish12pant@gmail.com

  1. Add check if show running output is corrupted as frr-reload does
    not return cause of failure, just the error codes.
  2. Change logger level to debug for some extra information.
  3. Modify logger messages for more clear information.
  4. Add config logs in the console output.
  5. Add show command output in the console output.
  6. Move show running output within flag show_router_config.
  7. Add retry decorator for retyring show commands.

@polychaeta polychaeta added the tests Topotests, make check, etc label Aug 20, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 20, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4852 248889b
Date 08/20/2019
Start 06:05:16
Finish 06:27:09
Run-Time 21:53
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-08-20-06:05:16.txt
Log autoscript-2019-08-20-06:06:09.log.bz2
Memory 426 430 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8647/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-8647/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

r2: ospfd crashed. Core file found - Backtrace follows:
[New LWP 19146]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ospfd'.
Program terminated with signal SIGABRT, Aborted.
#0  0xb7fa7d05 in ?? ()
#0  0xb7fa7d05 in ?? ()
#1  0xb7f3cc09 in thread_call () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0
#2  0xb7f0b6a1 in frr_run () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0
#3  0x0042e406 in main ()
2019-08-20 13:04:54,840 ERROR: assert failed at "test_ospf_sr_topo1/test_memory_leak": 
r2: ospfd crashed. Core file found - Backtrace follows:
[New LWP 19146]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/ospfd'.
Program terminated with signal SIGABRT, Aborted.
#0  0xb7fa7d05 in ?? ()
#0  0xb7fa7d05 in ?? ()
#1  0xb7f3cc09 in thread_call () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0
#2  0xb7f0b6a1 in frr_run () from /usr/lib/i386-linux-gnu/frr/libfrr.so.0
#3  0x0042e406 in main ()

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8647/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • IPv4 protocols on Ubuntu 14.04
  • Debian 9 deb pkg check
  • Static analyzer (clang)
  • Topology tests on Ubuntu 18.04 amd64
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Ubuntu 16.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Fedora 29 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8647/artifact/TOPOI386/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 4852, comparing to Git base SHA 8d3c0d3

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8647/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 20, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4852 272a67f
Date 08/20/2019
Start 13:19:24
Finish 13:41:19
Run-Time 21:55
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-08-20-13:19:24.txt
Log autoscript-2019-08-20-13:20:17.log.bz2
Memory 431 426 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8658/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 4852, comparing to Git base SHA d1c6230
  • Base image data for Git d1c6230 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8658/artifact/shared/static_analysis/index.html

@ashish12pant
tests: Enhance execution logs in topojson
bca7983 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

1. Add check if show running output is corrupted as frr-reload does
   not return cause of failure, just the error codes.
2. Change logger level to debug for some extra information.
3. Modify logger messages for more clear information.
4. Print configuration commands to console instead of show running
5. Print show command output to console.
6. Move show running output within flag show_router_config.
7. Add retry decorator for retyring show commands.
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 22, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4852 bca7983
Date 08/22/2019
Start 12:10:17
Finish 12:32:08
Run-Time 21:51
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-08-22-12:10:17.txt
Log autoscript-2019-08-22-12:11:08.log.bz2
Memory 414 412 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8679/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 4852, comparing to Git base SHA ad4c7e8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8679/artifact/shared/static_analysis/index.html

mwinter-osr
mwinter-osr approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@mwinter-osr mwinter-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, please split up in multiple smaller commits. Reading the description of the commit, there are at least 7 items addressed in it. (Numbered 1-7). These should be all separate commits.

@mwinter-osr mwinter-osr merged commit 4298dfd into FRRouting:master Aug 29, 2019
@ashish12pant ashish12pant deleted the fix_log branch February 24, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwinter-osr mwinter-osr mwinter-osr approved these changes

Assignees
No one assigned
Labels
tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashish12pant @LabN-CI @NetDEF-CI @mwinter-osr @polychaeta