Advertise FIB installed routes to bgp peers #4770

kssoman · 2019-08-02T07:03:19Z

Test results

kssoman · 2019-08-02T07:12:00Z

Adding the design document
fib.docx

LabN-CI · 2019-08-02T07:29:15Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/4770 `ce8356e`
Date	08/02/2019
Start	03:07:08
Finish	03:29:13
Run-Time	22:05
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-02-03:07:08.txt
Log	autoscript-2019-08-02-03:08:09.log.bz2
Memory	435 408 359

For details, please contact louberger

NetDEF-CI · 2019-08-02T07:31:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Successful on other platforms

Fedora 29 amd64 build
FreeBSD 11 amd64 build
Debian 10 amd64 build
FreeBSD 12 amd64 build
NetBSD 7 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
Ubuntu 16.04 i386 build
NetBSD 6 amd64 build
CentOS 7 amd64 build
Debian 8 amd64 build
Ubuntu 18.04 ppc64le build
Debian 9 amd64 build
OmniOS amd64 build
Ubuntu 14.04 amd64 build
Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Report for bgp_route.c | 2 issues
===============================================
< ERROR: else should follow close brace '}'
< #2248: FILE: /tmp/f1-26749/bgp_route.c:2248:
Report for bgp_zebra.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #2351: FILE: /tmp/f1-26749/bgp_zebra.c:2351:
< WARNING: line over 80 characters
< #2383: FILE: /tmp/f1-26749/bgp_zebra.c:2383:
Report for zebra_rib.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1811: FILE: /tmp/f1-26749/zebra_rib.c:1811:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8503/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

LabN-CI · 2019-08-02T09:10:25Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/4770 `16ce5bc`
Date	08/02/2019
Start	04:48:27
Finish	05:10:24
Run-Time	21:57
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-02-04:48:27.txt
Log	autoscript-2019-08-02-04:49:30.log.bz2
Memory	434 426 360

For details, please contact louberger

NetDEF-CI · 2019-08-02T10:02:04Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8507/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8507/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

Github Pull Request 4770, comparing to Git base SHA b7655d8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8507/artifact/shared/static_analysis/index.html

zebra/zebra_rib.c

eigrpd/eigrp_zebra.c

donaldsharp

First round of review has been done here. I have not had a chance to actually test this code yet to look at behaviors. Will do so after these code comments have been addressed

zebra/zapi_msg.c

bgpd/bgp_zebra.c

bgpd/bgp_route.c

bgpd/bgp_updgrp.c

donaldsharp · 2019-08-06T14:36:48Z

Additionally we need to update the documentation to reflect these changes

LabN-CI · 2019-08-08T12:28:20Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/4770 `57315b1`
Date	08/08/2019
Start	08:06:24
Finish	08:28:19
Run-Time	21:55
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-08-08:06:24.txt
Log	autoscript-2019-08-08-08:07:19.log.bz2
Memory	414 433 359

For details, please contact louberger

NetDEF-CI · 2019-08-08T13:51:53Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8561/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8561/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

Github Pull Request 4770, comparing to Git base SHA 3a73896

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8561/artifact/shared/static_analysis/index.html

donaldsharp · 2019-10-03T14:30:13Z

Documentation
Fix commits from root
With three routers A --- B --- C
A is sending a full table to B.
B has a route-map on the ip protocol bgp route-map FOO that is only allowing 24 routes to be installed:

Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            16                   16                   
static               2                    1                    
ospf                 1                    0                    
ebgp                 782051               24                   
ibgp                 0                    0                    
------
Totals               782071               42

On C we see that we have 24 routes:

Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            1                    1                    
ebgp                 24                   24                   
ibgp                 0                    0                    
eigrp                1                    0                    
------
Totals               27                   26

On C let's clear neighbors:

janelle# clear bgp ipv4 uni *
2019/10/03 14:26:45 BGP: %NOTIFICATION: sent to neighbor 192.168.201.140 6/4 (Cease/Administratively Reset) 0 bytes 
janelle# 2019/10/03 14:26:45 BGP: %ADJCHANGE: neighbor 192.168.201.140(robot) in vrf default Down Peer closed the session

janelle# 
janelle# 
janelle# 
janelle# 2019/10/03 14:26:47 BGP: %ADJCHANGE: neighbor 192.168.201.140(robot) in vrf default Up
show bgp ipv4 uni *
% Unknown command: show bgp ipv4 uni *
janelle# 2019/10/03 14:26:52 BGP: %NOTIFICATION: rcvd End-of-RIB for IPv4 Unicast from 192.168.201.140 in vrf default
2019/10/03 14:26:52 BGP: %NOTIFICATION: rcvd End-of-RIB for IPv6 Unicast from 192.168.201.140 in vrf default
janelle# show bgp ipv4 uni
No BGP prefixes displayed, 0 exist
janelle# show ip route summ
Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            1                    1                    
eigrp                1                    0                    
------
Totals               3                    2                    

janelle#

This seems broken

donaldsharp · 2019-10-03T14:32:02Z

Additionally I saw some very very weird behavior associated with applying a route-map to the ip protocol bgp .... command which I did not keep records for. I would suggest playing around in there some too.

riw777 · 2019-11-26T17:10:45Z

This has been sitting for a while; I suspect we should close this and wait for a new PR to fix this if someone wants to take it on.

kssoman · 2019-11-28T03:32:49Z

This has been sitting for a while; I suspect we should close this and wait for a new PR to fix this if someone wants to take it on.

I will continue to look at the PR

kssoman · 2019-12-20T16:38:31Z

Documentation
Fix commits from root
With three routers A --- B --- C
A is sending a full table to B.
B has a route-map on the ip protocol bgp route-map FOO that is only allowing 24 routes to be installed:

Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            16                   16                   
static               2                    1                    
ospf                 1                    0                    
ebgp                 782051               24                   
ibgp                 0                    0                    
------
Totals               782071               42

On C we see that we have 24 routes:

Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            1                    1                    
ebgp                 24                   24                   
ibgp                 0                    0                    
eigrp                1                    0                    
------
Totals               27                   26

On C let's clear neighbors:

janelle# clear bgp ipv4 uni *
2019/10/03 14:26:45 BGP: %NOTIFICATION: sent to neighbor 192.168.201.140 6/4 (Cease/Administratively Reset) 0 bytes 
janelle# 2019/10/03 14:26:45 BGP: %ADJCHANGE: neighbor 192.168.201.140(robot) in vrf default Down Peer closed the session

janelle# 
janelle# 
janelle# 
janelle# 2019/10/03 14:26:47 BGP: %ADJCHANGE: neighbor 192.168.201.140(robot) in vrf default Up
show bgp ipv4 uni *
% Unknown command: show bgp ipv4 uni *
janelle# 2019/10/03 14:26:52 BGP: %NOTIFICATION: rcvd End-of-RIB for IPv4 Unicast from 192.168.201.140 in vrf default
2019/10/03 14:26:52 BGP: %NOTIFICATION: rcvd End-of-RIB for IPv6 Unicast from 192.168.201.140 in vrf default
janelle# show bgp ipv4 uni
No BGP prefixes displayed, 0 exist
janelle# show ip route summ
Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            1                    1                    
eigrp                1                    0                    
------
Totals               3                    2                    

janelle#

This seems broken

Verified the issue is not observed when the patch is applied to latest build

Logs:

newlogs.txt

donaldsharp · 2019-12-20T16:41:45Z

ci:rerun

kssoman · 2019-12-20T16:46:20Z

ci:rerun

The CI tests are not getting triggered when new changes are submitted

LabN-CI · 2019-12-20T17:02:10Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/4770 `1472cec`
Date	12/20/2019
Start	11:36:18
Finish	12:02:06
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-20-11:36:18.txt
Log	autoscript-2019-12-20-11:37:09.log.bz2
Memory	434 434 352

For details, please contact louberger

kssoman · 2019-12-21T15:44:18Z

ci:rerun

Basic CI tests logs are observed but NetDEF-CI logs is not shown

donaldsharp · 2019-12-22T21:22:11Z

ci:rerun

NetDEF-CI · 2019-12-23T00:19:59Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10222/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_zebra.c | 4 issues
===============================================
< ERROR: switch and case should be at the same indent
< #2323: FILE: /tmp/f1-9542/bgp_zebra.c:2323:
< ERROR: code indent should use tabs where possible
< #2344: FILE: /tmp/f1-9542/bgp_zebra.c:2344:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10222/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-03-g1472ceceb-0 (missing) -> 7.3-dev-20191220-03-g1472ceceb-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-03-g1472ceceb-0 (missing) -> 7.3-dev-20191220-03-g1472ceceb-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-03-g1472ceceb-0 (missing) -> 7.3-dev-20191220-03-g1472ceceb-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-03-g1472ceceb-0 (missing) -> 7.3-dev-20191220-03-g1472ceceb-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191220-03-g1472ceceb-0 (missing) -> 7.3-dev-20191220-03-g1472ceceb-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly

<TITLE>clang_check</TITLE>

clang_check

kssoman · 2019-12-24T11:39:21Z

ci:rerun

Basic CI tests logs are observed but NetDEF-CI logs is not shown

CI results are fine ( #4770 (comment) )

donaldsharp · 2020-01-07T00:59:21Z

Why is the documentation not updated?
Please fix tab/space issue as reported by the CI system.
I reran the tests and am in broken state again with the same setup, I just issued a series of different clears on b then c.
b:

sharpd@robot ~/frr4> ip route show table 6969
40.16.0.0/12 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.0.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.16.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.32.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.48.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.140.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.176.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.192.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.208.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.226.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.228.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.230.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.231.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.234.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.240.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.241.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.242.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.243.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.244.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.245.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.247.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.248.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.252.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.253.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20

c:

janelle# show bgp ipv4 uni summ
BGP router identifier 192.168.201.138, local AS number 60000 vrf-id 0
BGP table version 27805534
RIB entries 0, using 0 bytes of memory
Peers 4, using 82 KiB of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
192.168.11.1    4          0       0       0        0    0    0    never       Active
192.168.12.2    4          0       0       0        0    0    0    never       Active
192.168.13.3    4          0       0       0        0    0    0    never       Active
192.168.201.139 4      64540 2419836 2431830        0    0    0 00:03:13            0

Total number of neighbors 4
janelle#

bgpd/bgp_fsm.c

kssoman · 2020-10-28T16:41:45Z

Why is the documentation not updated?
Please fix tab/space issue as reported by the CI system.
I reran the tests and am in broken state again with the same setup, I just issued a series of different clears on b then c.
b:

sharpd@robot ~/frr4> ip route show table 6969
40.16.0.0/12 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.0.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.16.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.32.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.48.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.140.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.176.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.192.0/20 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.26.208.0/22 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.226.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.228.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.230.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.231.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.234.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.240.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.241.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.242.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.243.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.244.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.245.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.247.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.248.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.252.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20 
40.27.253.0/24 nhid 712 via 192.168.201.136 dev enp3s0 proto bgp metric 20

c:

janelle# show bgp ipv4 uni summ
BGP router identifier 192.168.201.138, local AS number 60000 vrf-id 0
BGP table version 27805534
RIB entries 0, using 0 bytes of memory
Peers 4, using 82 KiB of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
192.168.11.1    4          0       0       0        0    0    0    never       Active
192.168.12.2    4          0       0       0        0    0    0    never       Active
192.168.13.3    4          0       0       0        0    0    0    never       Active
192.168.201.139 4      64540 2419836 2431830        0    0    0 00:03:13            0

Total number of neighbors 4
janelle#

@kssoman can you please let us know if you have addressed this failure already if so can you please paste some results for this?

The document is updated in the file doc/user/bgp.rst
Tested with large number of routes (800000) and found to be working fine, will add the results information

Logs added in the file : fib_test_logs

LabN-CI · 2020-10-29T04:53:00Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4770 `1d63e8f`
Date	10/29/2020
Start	00:26:40
Finish	00:52:55
Run-Time	26:15
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-10-29-00:26:40.txt
Log	autoscript-2020-10-29-00:27:39.log.bz2
Memory	496 489 428

For details, please contact louberger

NetDEF-CI · 2020-10-29T07:14:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15030/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15030/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201029-03-g1d63e8f1c-0 (missing) -> 7.6-dev-20201029-03-g1d63e8f1c-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201029-03-g1d63e8f1c-0 (missing) -> 7.6-dev-20201029-03-g1d63e8f1c-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201029-03-g1d63e8f1c-0 (missing) -> 7.6-dev-20201029-03-g1d63e8f1c-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201029-03-g1d63e8f1c-0 (missing) -> 7.6-dev-20201029-03-g1d63e8f1c-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201029-03-g1d63e8f1c-0 (missing) -> 7.6-dev-20201029-03-g1d63e8f1c-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 4770, comparing to Git base SHA 502dd27

No Changes in Static Analysis warnings compared to base

2 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15030/artifact/shared/static_analysis/index.html

kssoman · 2020-10-29T09:49:20Z

fib_test_logs.txt

kssoman · 2020-11-03T16:41:29Z

Can you please address all the pending comments?

All the review comments are addressed

Spantik · 2020-11-05T16:50:39Z

@kssoman looked at the PR and looks good now. Please fix the conflict and I will get this in.

Issue: The bgp routes learnt from peers which are not installed in kernel are advertised to peers. This can cause routers to send traffic to these destinations only to get dropped. The fix is to provide a configurable option "bgp suppress-fib-pending". When the option is enabled, bgp will advertise routes only if it these are successfully installed in kernel. Fix (Part1) : * Added message ZEBRA_ROUTE_NOTIFY_REQUEST used by client to request FIB install status for routes * Added AFI/SAFI to ZAPI messages * Modified the functions zapi_route_notify_decode(), zsend_route_notify_owner() and route_notify_internal() to include AFI, SAFI as parameters Signed-off-by: kssoman <somanks@gmail.com>

* Added CLI command "[no] bgp suppress-fib-pending" to enable and disable suppress-fib-pending * Send ZEBRA_ROUTE_NOTIFY_REQUEST to zebra when "bgp suppress-fib-pending" is enabled or disabled * Define BGP_DEFAULT_UPDATE_ADVERTISEMENT_TIME which is the delay added to update group timer. * Added error codes Signed-off-by: kssoman <somanks@gmail.com>

* Process FIB update in bgp_zebra_route_notify_owner() and call group_announce_route() if route is installed * When bgp update is received for a route which is not installed earlier (flag BGP_NODE_FIB_INSTALLED is not set) and suppress fib is enabled set the flag BGP_NODE_FIB_INSTALL_PENDING to indicate fib install is pending for the route. The route will be advertised when zebra send ZAPI_ROUTE_INSTALLED status. * The advertisement delay (BGP_DEFAULT_UPDATE_ADVERTISEMENT_TIME) is added to allow more routes to be sent in single update message. This is required since zebra sends route notify message for each route. The delay will be applied to update group timer which advertises routes to peers. Signed-off-by: kssoman <somanks@gmail.com>

Added test case for bgp suppress-fib-pending Updated document Signed-off-by: kssoman <somanks@gmail.com>

LabN-CI · 2020-11-06T05:11:47Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4770 `1cc5593`
Date	11/05/2020
Start	23:36:42
Finish	00:11:42
Run-Time	35:00
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-05-23:36:42.txt
Log	autoscript-2020-11-05-23:37:41.log.bz2
Memory	493 470 418

For details, please contact louberger

NetDEF-CI · 2020-11-06T06:21:07Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15240/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15240/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-11-06 05:15:21,824 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-06 05:15:22,105 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-06 05:18:33,732 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-8]": Testcase test_modify_ecmp_max_paths[redist_static-8] : Failed 
   Error: Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-06 05:19:12,592 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-16]": Testcase test_modify_ecmp_max_paths[redist_static-16] : Failed 
   Error: Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-06 05:45:15,506 ERROR: '_bgp_has_routes' failed after 40.20 seconds
2020-11-06 05:54:26,010 ERROR: r6: bgpd left a dead pidfile (pid=4779)
2020-11-06 05:59:30,833 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15240/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 protocols on Ubuntu 18.04
Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 16.04 i386
Debian 10 deb pkg check
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Fedora 29 rpm pkg check
Topo tests part 0 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 i386
IPv4 ldp protocol on Ubuntu 18.04
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 0
Debian 8 deb pkg check
Ubuntu 20.04 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
Topo tests part 1 on Ubuntu 18.04 amd64
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 amd64
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 2
Addresssanitizer topotests part 1

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15240/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-06T09:26:27Z

ci:rerun

NetDEF-CI · 2020-11-06T12:09:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15248/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topo tests part 2 on Ubuntu 18.04 amd64: No useful log found

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15248/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

2020-11-06 10:07:27,525 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-06 10:07:27,821 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-06 10:10:57,213 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-16]": Testcase test_modify_ecmp_max_paths[redist_static-16] : Failed 
   Error: Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-06 10:35:40,623 ERROR: r1: bgpd left a dead pidfile (pid=3517)
2020-11-06 10:36:58,192 ERROR: '_bgp_has_routes' failed after 39.04 seconds
2020-11-06 10:50:40,253 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15248/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15248/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-11-06 11:07:22,791 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-06 11:07:23,121 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-06 11:10:43,382 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-8]": Testcase test_modify_ecmp_max_paths[redist_static-8] : Failed 
   Error: Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-06 11:36:53,339 ERROR: '_bgp_has_routes' failed after 39.38 seconds
2020-11-06 11:50:46,131 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15248/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 16.04 i386
Debian 10 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
Debian 9 deb pkg check
Topo tests part 0 on Ubuntu 18.04 arm8
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Addresssanitizer topotests part 2
Addresssanitizer topotests part 1
CentOS 7 rpm pkg check
IPv4 ldp protocol on Ubuntu 18.04
Addresssanitizer topotests part 0
Debian 8 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15248/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-06T12:54:04Z

Changes updated to latest code

The changes were working fine on 10/29/2020 as shown in previous results
but now test_ebgp_ecmp_topo2 is showing error

When test_ebgp_ecmp_topo2 is run seperately, there is no error, looks like timing issue with the test case

The error in test_ebgp_ecmp_topo2 is seen in other PRs also therefore it looks like test case issue
This PR can probably be merged

Spantik · 2020-11-07T08:09:56Z

ci:rerun

NetDEF-CI · 2020-11-07T10:53:21Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15279/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15279/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

2020-11-07 08:50:41,140 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-07 08:50:41,496 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-07 08:54:20,722 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-16]": Testcase test_modify_ecmp_max_paths[redist_static-16] : Failed 
   Error: Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:10::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-07 09:21:24,223 ERROR: '_bgp_has_routes' failed after 41.31 seconds
2020-11-07 09:31:04,007 ERROR: r7: bgpd left a dead pidfile (pid=11639)
2020-11-07 09:36:20,956 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15279/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 2
Addresssanitizer topotests part 0
IPv4 ldp protocol on Ubuntu 18.04
CentOS 7 rpm pkg check
Debian 8 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
Debian 9 deb pkg check
Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 amd64
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 amd64
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 16.04 i386
Topo tests part 2 on Ubuntu 18.04 amd64
Debian 10 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topo tests part 2 on Ubuntu 16.04 amd64
Topo tests part 0 on Ubuntu 18.04 arm8
Static analyzer (clang)
Fedora 29 rpm pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15279/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-08T04:59:15Z

ci:rerun

NetDEF-CI · 2020-11-08T07:56:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15291/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

IPv6 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15291/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-11-08 06:41:17,020 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-08 06:41:17,369 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-08 06:44:47,775 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-8]": Testcase test_modify_ecmp_max_paths[redist_static-8] : Failed 
   Error: Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-08 07:11:48,250 ERROR: '_bgp_has_routes' failed after 41.52 seconds
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-11-08 07:25:48,424 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15291/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
Addresssanitizer topotests part 1
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 16.04 amd64
Topo tests part 1 on Ubuntu 18.04 arm8
Static analyzer (clang)
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 amd64
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 0 on Ubuntu 18.04 arm8
Ubuntu 16.04 deb pkg check
Ubuntu 18.04 deb pkg check
Topo tests part 1 on Ubuntu 18.04 amd64
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 2
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
Topo tests part 0 on Ubuntu 16.04 i386
IPv4 ldp protocol on Ubuntu 18.04
Debian 10 deb pkg check
CentOS 7 rpm pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15291/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-08T09:25:02Z

The error in test_ebgp_ecmp_topo2 is not related to the changes in this PR and likely timing issue in the test case

kssoman · 2020-11-10T03:10:05Z

ci:rerun

NetDEF-CI · 2020-11-10T05:59:55Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15326/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Successful on other platforms/tests

Topo tests part 0 on Ubuntu 18.04 arm8
Static analyzer (clang)
Ubuntu 20.04 deb pkg check
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 2 on Ubuntu 16.04 i386
Topo tests part 0 on Ubuntu 18.04 amd64
Ubuntu 18.04 deb pkg check
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 2
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 18.04 amd64
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Topo tests part 2 on Ubuntu 18.04 amd64
Debian 10 deb pkg check
Debian 9 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
IPv4 ldp protocol on Ubuntu 18.04
Topo tests part 1 on Ubuntu 16.04 amd64
Fedora 29 rpm pkg check
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topo tests part 1 on Ubuntu 16.04 i386
Debian 8 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 18.04

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15326/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

donaldsharp · 2020-11-10T16:18:52Z

ci:rerun

NetDEF-CI · 2020-11-10T19:08:31Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15342/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15342/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

2020-11-10 17:09:20,343 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
line 8: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 10: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2020-11-10 17:09:20,633 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 201, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-11-10 17:12:38,554 ERROR: assert failed at "test_ebgp_ecmp_topo2/test_modify_ecmp_max_paths[redist_static-8]": Testcase test_modify_ecmp_max_paths[redist_static-8] : Failed 
   Error: Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3
  
assert "Nexthop set(['fd00:0:0:8::1']) is Missing for route 1::/64 in RIB of router r3\n" is True
2020-11-10 17:39:03,350 ERROR: '_bgp_has_routes' failed after 39.10 seconds
2020-11-10 17:40:22,309 ERROR: r4: zebra left a dead pidfile (pid=13584)
2020-11-10 17:51:07,338 ERROR: r2: bgpd left a dead pidfile (pid=26820)
2020-11-10 17:51:55,154 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 1482, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 288, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 572, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf  hello-interval 65536

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15342/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Debian 8 deb pkg check
Debian 9 deb pkg check
Topo tests part 0 on Ubuntu 16.04 amd64
IPv4 ldp protocol on Ubuntu 18.04
Topo tests part 1 on Ubuntu 18.04 arm8
Topo tests part 1 on Ubuntu 16.04 amd64
Topo tests part 2 on Ubuntu 18.04 arm8
Topo tests part 0 on Ubuntu 18.04 amd64
IPv6 protocols on Ubuntu 18.04
Addresssanitizer topotests part 1
Topo tests part 0 on Ubuntu 16.04 i386
Topo tests part 1 on Ubuntu 16.04 i386
Topo tests part 2 on Ubuntu 18.04 amd64
Debian 10 deb pkg check
Topo tests part 2 on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 18.04
Topo tests part 0 on Ubuntu 18.04 arm8
Static analyzer (clang)
Fedora 29 rpm pkg check
Ubuntu 20.04 deb pkg check
Topo tests part 2 on Ubuntu 16.04 i386
Ubuntu 18.04 deb pkg check
Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15342/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-11T03:35:25Z

ci:rerun

NetDEF-CI · 2020-11-11T06:23:44Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15361/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15361/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201106-04-g1cc559389-0 (missing) -> 7.6-dev-20201106-04-g1cc559389-0~deb10u1

kssoman · 2020-11-11T10:03:21Z

The test run looks ok now, PR can probably be committed

polychaeta added the bgp label Aug 2, 2019

kssoman force-pushed the fib branch from ce8356e to 16ce5bc Compare August 2, 2019 08:28

donaldsharp reviewed Aug 6, 2019

View reviewed changes

zebra/zebra_rib.c Outdated Show resolved Hide resolved

donaldsharp reviewed Aug 6, 2019

View reviewed changes

zebra/zebra_rib.c Outdated Show resolved Hide resolved

donaldsharp reviewed Aug 6, 2019

View reviewed changes

eigrpd/eigrp_zebra.c Outdated Show resolved Hide resolved

donaldsharp requested changes Aug 6, 2019

View reviewed changes

kssoman force-pushed the fib branch from 16ce5bc to 57315b1 Compare August 8, 2019 12:04

kssoman force-pushed the fib branch from 57315b1 to 1472cec Compare December 20, 2019 16:31

donaldsharp reviewed Jan 7, 2020

View reviewed changes

bgpd/bgp_fsm.c Outdated Show resolved Hide resolved

kssoman force-pushed the fib branch from c7686b8 to 1d63e8f Compare October 29, 2020 04:20

kssoman added 4 commits November 6, 2020 08:39

tests: Advertise FIB installed routes to bgp peers

1cc5593

Added test case for bgp suppress-fib-pending Updated document Signed-off-by: kssoman <somanks@gmail.com>

kssoman force-pushed the fib branch from 1d63e8f to 1cc5593 Compare November 6, 2020 03:33

Spantik merged commit 9b936c5 into FRRouting:master Nov 12, 2020

Advertise FIB installed routes to bgp peers #4770

Advertise FIB installed routes to bgp peers #4770

Conversation

kssoman commented Aug 2, 2019 • edited Loading

kssoman commented Aug 2, 2019 • edited Loading

LabN-CI commented Aug 2, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 2, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Warnings Generated during build:

LabN-CI commented Aug 2, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 2, 2019 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

donaldsharp left a comment

Choose a reason for hiding this comment

donaldsharp commented Aug 6, 2019

LabN-CI commented Aug 8, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 8, 2019 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

donaldsharp commented Oct 3, 2019

donaldsharp commented Oct 3, 2019

riw777 commented Nov 26, 2019

kssoman commented Nov 28, 2019

kssoman commented Dec 20, 2019

Logs:

donaldsharp commented Dec 20, 2019

kssoman commented Dec 20, 2019

LabN-CI commented Dec 20, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

kssoman commented Dec 21, 2019

donaldsharp commented Dec 22, 2019

NetDEF-CI commented Dec 23, 2019 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Warnings Generated during build:

clang_check

kssoman commented Dec 24, 2019

donaldsharp commented Jan 7, 2020

kssoman commented Oct 28, 2020 • edited Loading

LabN-CI commented Oct 29, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Oct 29, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

2 Static Analyzer issues remaining.

kssoman commented Oct 29, 2020

kssoman commented Nov 3, 2020

Spantik commented Nov 5, 2020

LabN-CI commented Nov 6, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 6, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

kssoman commented Nov 6, 2020

NetDEF-CI commented Nov 6, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

kssoman commented Nov 6, 2020 • edited Loading

Spantik commented Nov 7, 2020

kssoman commented Aug 2, 2019 •

edited

Loading

kssoman commented Aug 2, 2019 •

edited

Loading

LabN-CI commented Aug 2, 2019 •

edited

Loading

NetDEF-CI commented Aug 2, 2019 •

edited

Loading

LabN-CI commented Aug 2, 2019 •

edited

Loading

NetDEF-CI commented Aug 2, 2019 •

edited

Loading

LabN-CI commented Aug 8, 2019 •

edited

Loading

NetDEF-CI commented Aug 8, 2019 •

edited

Loading

LabN-CI commented Dec 20, 2019 •

edited

Loading

NetDEF-CI commented Dec 23, 2019 •

edited

Loading

kssoman commented Oct 28, 2020 •

edited

Loading

kssoman commented Nov 6, 2020 •

edited

Loading