Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtysh: only show error codes once #4732

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Jul 25, 2019

When using show error commands, show errors shared between multiple
daemons only once.

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 25, 2019

🚧 Basic BGPD CI results: Partial FAILURE, 1 tests failed

Results table
_ _
Result SUCCESS git merge/4732 7be9968
Date 07/25/2019
Start 11:15:30
Finish 11:37:04
Run-Time 21:34
Total 1815
Pass 1814
Fail 1
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-07-25-11:15:30.txt
Log autoscript-2019-07-25-11:16:20.log.bz2
Memory 433 429 353

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8445/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for vtysh.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #2407: FILE: /tmp/f1-2455/vtysh.c:2407:
< WARNING: Missing a blank line after declarations
< #2413: FILE: /tmp/f1-2455/vtysh.c:2413:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8445/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4732, comparing to Git base SHA e72ce28

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8445/artifact/shared/static_analysis/index.html

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulus the two nits

qlyoung added 2 commits July 29, 2019 17:18
When using `show error` commands, show errors shared between multiple
daemons only once.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@qlyoung
Copy link
Member Author

qlyoung commented Jul 29, 2019

@donaldsharp fixed, please un-NACK when you can

@donaldsharp donaldsharp dismissed their stale review July 29, 2019 17:23

Fixed problems

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 29, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4732 2d6e4d2
Date 07/29/2019
Start 13:27:16
Finish 13:48:56
Run-Time 21:40
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-07-29-13:27:16.txt
Log autoscript-2019-07-29-13:28:05.log.bz2
Memory 414 434 361

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8466/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8466/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4732, comparing to Git base SHA a041a8f
  • Base image data for Git a041a8f does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8466/artifact/shared/static_analysis/index.html

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@riw777 riw777 merged commit 65c52bd into FRRouting:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants