vtysh: mark exit-vrf with end when using vtysh -m #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRF context blocks have a context-specific exit command in order to explicitly force an exit to the top level config node. This command exists because 'ip route' commands are accepted in both VRF_NODE and CONFIG_NODE, so static routes intended to be accepted in CONFIG_NODE that immediately follow a VRF_NODE block will be shoved into the VRF_NODE block unless the VRF context is explicitly exited. However, because this is a command that exits to CONFIG_NODE, vtysh -m should be printing an `end` at the end of the context, since frr-reload.py relies on this context ender to know when it's back in CONFIG_NODE. But since this is the only explicit context exit command that also exits to CONFIG_NODE we don't really have a good way of doing this already. Hence this god-awful patch. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
This comment has been minimized.
This comment has been minimized.
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8434/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VRF context blocks have a context-specific exit command in order to
explicitly force an exit to the top level config node. This command
exists because 'ip route' commands are accepted in both
VRF_NODEandCONFIG_NODE, so static routes intended to be accepted inCONFIG_NODEthat immediately follow a
VRF_NODEblock will be shoved into theVRF_NODEblock unless the VRF context is explicitly exited.However, because this is a command that exits to
CONFIG_NODE,vtysh -mshould be printing an
endat the end of the context, sincefrr-reload.pyrelies on this context ender to know when it's back inCONFIG_NODE. But since this is the only explicit context exit commandthat also exits to
CONFIG_NODEwe don't really have a good way of doingthis already. Hence this god-awful patch.
Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com