ospfd: no router ospf crash fix #4685
Conversation
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits is missing a
Signed-off-byline; we can't accept your contribution until all of your commits have one
If you are a new contributor to FRR, please see our contributing guidelines.
chiragshah6
force-pushed
the
ospf_vrf_dev
branch
from
d2c01cf to
6b88878
Compare
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8358/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8357/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
no router ospf triggers to cancel all threads including read/write (receive/send packets) threads, cleans up resources fd, message queue and data. Last job of write (packet) thread invoked where the ospf instance is referenced is not running nor the socket fd valid. Write thread callback should check if fd is valid and ospf instance is running before proceeding to send a message over socket. Ticket:CM-20095 Testing Done: Performed the multiple 'no router ospf' with the fix in topology where the crash was seen. Post fix the crash is not observed. Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
chiragshah6
force-pushed
the
ospf_vrf_dev
branch
from
6b88878 to
c32eba0
Compare
|
Thanks @odd22 (Olivier), I have pushed a change to move unguarded debug statement to a ospf debug filter. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedIPv6 protocols on Ubuntu 14.04: Failed (click for details)Successful on other platforms
Warnings Generated during build:Checkout code: Successful with additional warningsIPv6 protocols on Ubuntu 14.04: Failed (click for details)Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8360/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warningsWarnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
This comment has been minimized.
This comment has been minimized.
|
@louberger can you look at why this is failing the labn tests? :-) |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
|
this was the issue I mentioned in the meeting -- passing now...
On 7/16/2019 9:13 AM, Russ White wrote:
@louberger
can you look at why this is failing the labn tests? :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#4685?email_source=notifications\u0026email_token=ABSFNSF6YVWIEV3CBR5AA6LP7XCPZA5CNFSM4IDROR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AZTUQ#issuecomment-511810002",
"url": "#4685?email_source=notifications\u0026email_token=ABSFNSF6YVWIEV3CBR5AA6LP7XCPZA5CNFSM4IDROR42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AZTUQ#issuecomment-511810002",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
no router ospf triggers to cancel all threads including read/write (receive/send packets) threads,
cleans up resources fd, message queue and data.
Last job of write (packet) thread invoked where the ospf instance is referenced is not running nor the socket fd valid.
Thread callback should check if fd is valid and ospf instance is running before proceeding to send a message over socket.
It should address issues 4542 and 4248
Testing Done:
Performed the multiple 'no router ospf' with the fix in topology where the crash was seen.
Post fix the crash is not observed.
Signed-off-by: Chirag Shah chirag@cumulusnetworks.com