vtysh: Try to be perscriptive about pam failures

[donaldsharp]

When using pam for authentication, the code just silently
fails and gives no indication to the end user what has gone
wrong. Try to increase messaging about what has gone wrong
by outputting some more data.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4608 60bc8d6
Date	06/25/2019
Start	20:28:32
Finish	20:50:54
Run-Time	22:22
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-06-25-20:28:32.txt
Log	autoscript-2019-06-25-20:29:34.log.bz2
Memory	432 427 360

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8232/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for vtysh_user.c | 4 issues
===============================================
< WARNING: Prefer using '"%s...", __func__' to using 'vtysh_pam', this function's name, in a string
< #71: FILE: /tmp/f1-1585/vtysh_user.c:71:
< WARNING: line over 80 characters
< #77: FILE: /tmp/f1-1585/vtysh_user.c:77:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8232/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

---

CLANG Static Analyzer Summary

• Github Pull Request 4608, comparing to Git base SHA f3afd0a
• Base image data for Git f3afd0a does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8232/artifact/shared/static_analysis/index.html