docker: cleanup Debian docker build

[qlyoung]

• Update build instructions
• Remove manually installed daemons file

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4568 0a45032
Date	06/20/2019
Start	13:05:42
Finish	13:27:46
Run-Time	22:04
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-06-20-13:05:42.txt
Log	autoscript-2019-06-20-13:06:41.log.bz2
Memory	424 423 360

For details, please contact louberger

[qlyoung]

CI:rerun

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8152/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-8152/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
*** defaultIntf: warning: lm has no interfaces
2019-06-20 19:38:24,813 ERROR: 'compare_ospf_srdb' failed after 78.29 seconds
2019-06-20 19:38:24,818 ERROR: assert failed at "test_ospf_sr_topo1/test_ospf_sr": OSPF did not start Segment Routing on r2:
  --- Current output
  +++ Expected output
  @@ -22,36 +22,36 @@
         ],
         "extendedLink":[
           {
  -          "prefix":"10.0.3.2\/32",
  +          "prefix":"10.0.4.2\/32",
             "sid":50001,
             "inputLabel":50001,
  +          "outputLabel":"pop",
  +          "interface":"r2-eth2",
  +          "nexthop":"10.0.4.1"
  +        },
  +        {
  +          "prefix":"10.0.4.2\/32",
  +          "sid":50000,
  +          "inputLabel":50000,
  +          "outputLabel":"pop",
  +          "interface":"r2-eth2",
  +          "nexthop":"10.0.4.1"
  +        },
  +        {
  +          "prefix":"10.0.3.2\/32",
  +          "sid":50003,
  +          "inputLabel":50003,
             "outputLabel":"pop",
             "interface":"r2-eth1",
             "nexthop":"10.0.3.1"
           },
           {
             "prefix":"10.0.3.2\/32",
  -          "sid":50000,
  -          "inputLabel":50000,
  +          "sid":50002,
  +          "inputLabel":50002,
             "outputLabel":"pop",
             "interface":"r2-eth1",
             "nexthop":"10.0.3.1"
  -        },
  -        {
  -          "prefix":"10.0.4.2\/32",
  -          "sid":50003,
  -          "inputLabel":50003,
  -          "outputLabel":"pop",
  -          "interface":"r2-eth2",
  -          "nexthop":"10.0.4.1"
  -        },
  -        {
  -          "prefix":"10.0.4.2\/32",
  -          "sid":50002,
  -          "inputLabel":50002,
  -          "outputLabel":"pop",
  -          "interface":"r2-eth2",
  -          "nexthop":"10.0.4.1"
           },
           {
             "prefix":"10.0.1.2\/32",
assert False
2019-06-20 19:39:43,854 ERROR: 'compare_mpls_table' failed after 78.38 seconds
2019-06-20 19:39:43,857 ERROR: assert failed at "test_ospf_sr_topo1/test_ospf_kernel_route": OSPF did not properly instal MPLS table on r2:
  --- Current output
  +++ Expected output
  @@ -47,7 +47,7 @@
           "outLabel":3,
           "distance":150,
           "installed":true,
  -        "nexthop":"10.0.3.1"
  +        "nexthop":"10.0.4.1"
         }
       ]
     },
  @@ -60,7 +60,7 @@
           "outLabel":3,
           "distance":150,
           "installed":true,
  -        "nexthop":"10.0.3.1"
  +        "nexthop":"10.0.4.1"
         }
       ]
     },
  @@ -73,7 +73,7 @@
           "outLabel":3,
           "distance":150,
           "installed":true,
  -        "nexthop":"10.0.4.1"
  +        "nexthop":"10.0.3.1"
         }
       ]
     },
  @@ -86,7 +86,7 @@
           "outLabel":3,
           "distance":150,
           "installed":true,
  -        "nexthop":"10.0.4.1"
  +        "nexthop":"10.0.3.1"
         }
       ]
     },
assert False

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8152/artifact/TOPOU1804/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-ISIS-17.1 failing:
Test Summary
If there is no path from source to destination made up of routers,
which supports that particular type of service, then the packet will
forwarded using default metric
Test Reference
RFC 1195 S3.5 P23 Type of Service Routing
Test Classification
MUST
Test ANVL-ISIS-17.1: !FAILED!
Expected to receive IP packet but did not
Received unexpected ICMP Destination Unreachable packet

Successful on other platforms

• Static analyzer (clang)
• Ubuntu 16.04 deb pkg check
• IPv6 protocols on Ubuntu 14.04
• Fedora 29 rpm pkg check
• Ubuntu 12.04 deb pkg check
• Ubuntu 14.04 deb pkg check
• IPv4 ldp protocol on Ubuntu 16.04
• Debian 8 deb pkg check
• Addresssanitizer topotest
• Topology tests on Ubuntu 16.04 amd64
• Debian 9 deb pkg check
• Topotest tests on Ubuntu 16.04 i386
• CentOS 7 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8152/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

• Github Pull Request 4568, comparing to Git base SHA 67e4212

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8152/artifact/shared/static_analysis/index.html

[robgil]

LGTM