bgpd, ripd, ripngd: remove deprecated -r option

[edipascale]

Since the deprecation period has expired, remove the retain option
and the associated CPP_NOTICE.

Signed-off-by: Emanuele Di Pascale emanuele@voltanet.io

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4385 f28963f
Date	05/22/2019
Start	15:45:16
Finish	16:08:11
Run-Time	22:55
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-22-15:45:16.txt
Log	autoscript-2019-05-22-15:46:17.log.bz2
Memory	427 426 360

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7789/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

CentOS 6 amd64 build: Failed (click for details)

CentOS 6 amd64 build: No useful log found

Successful on other platforms

• Ubuntu 18.04 ppc64le build
• OmniOS amd64 build
• NetBSD 7 amd64 build
• Debian 9 amd64 build
• Ubuntu 14.04 amd64 build
• Ubuntu 12.04 amd64 build
• Ubuntu 16.04 i386 build
• FreeBSD 11 amd64 build
• Debian 8 amd64 build
• NetBSD 6 amd64 build
• CentOS 7 amd64 build
• OpenBSD 6 amd64 build
• Ubuntu 16.04 amd64 build
• Ubuntu 18.04 amd64 build
• FreeBSD 12 amd64 build

[qlyoung]

CI:rerun

[qlyoung]

I'M GONNA DO IT

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7789/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Ubuntu 14.04 deb pkg check: Failed (click for details)

Ubuntu 14.04 deb pkg check: No useful log found

Successful on other platforms

• Addresssanitizer topotest
• Debian 8 deb pkg check
• Topology tests on Ubuntu 16.04 amd64
• CentOS 7 rpm pkg check
• IPv4 ldp protocol on Ubuntu 16.04
• IPv4 protocols on Ubuntu 14.04
• Topotest tests on Ubuntu 16.04 i386
• Debian 9 deb pkg check
• Ubuntu 12.04 deb pkg check
• Static analyzer (clang)
• IPv6 protocols on Ubuntu 14.04
• Topology tests on Ubuntu 18.04 amd64
• CentOS 6 rpm pkg check
• Ubuntu 16.04 deb pkg check

---

CLANG Static Analyzer Summary

• Github Pull Request 4385, comparing to Git base SHA f136efa

No Changes in Static Analysis warnings compared to base

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7789/artifact/shared/static_analysis/index.html

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7791/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4385, comparing to Git base SHA f136efa

No Changes in Static Analysis warnings compared to base

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7791/artifact/shared/static_analysis/index.html

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7789/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4385, comparing to Git base SHA f136efa

No Changes in Static Analysis warnings compared to base

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7789/artifact/shared/static_analysis/index.html