Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in the typesafe API for better C++ compatibility #4374

Merged
merged 4 commits into from
May 21, 2019
Merged

Minor fixes in the typesafe API for better C++ compatibility #4374

merged 4 commits into from
May 21, 2019

Conversation

rwestphal
Copy link
Member

No description provided.

@rwestphal rwestphal requested a review from eqvinox May 20, 2019 21:55
@polychaeta polychaeta added libfrr tests Topotests, make check, etc labels May 20, 2019
@eqvinox
Copy link
Contributor

eqvinox commented May 20, 2019

Dangit, bad timing - this'll have merge conflicts with #4373 :)

@rwestphal rwestphal added the blocked We are waiting on a feature implementation from another subsystem that we do not control label May 20, 2019
eqvinox
eqvinox requested changes May 20, 2019
View reviewed changes
Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment inline

@rwestphal
Copy link
Member Author

Dangit, bad timing - this'll have merge conflicts with #4373 :)

yeah I noticed that :)

I just added a "blocked" label to ensure your PR will be merged first. My renaming commit should be trivial to update afterwards, so no worries on that.

@rwestphal rwestphal force-pushed the typesafe-minor-fixes branch from 711f2ad to b428f24 Compare May 20, 2019 22:05
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 20, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4374 b428f24
Date 05/20/2019
Start 22:38:11
Finish 23:01:56
Run-Time 23:45
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-20-22:38:11.txt
Log autoscript-2019-05-20-22:39:16.log.bz2
Memory 420 438 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7769/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for zebra_rib.c | 5 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f1-7791/zebra_rib.c:131:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f2-7791/zebra_rib.c:131:
14c14
< #148: FILE: /tmp/f1-7791/zebra_rib.c:148:

CLANG Static Analyzer Summary

  • Github Pull Request 4374, comparing to Git base SHA 98356f4

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7769/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7770/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for zebra_rib.c | 5 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f1-19270/zebra_rib.c:131:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f2-19270/zebra_rib.c:131:
14c14
< #148: FILE: /tmp/f1-19270/zebra_rib.c:148:

CLANG Static Analyzer Summary

  • Github Pull Request 4374, comparing to Git base SHA 98356f4

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7770/artifact/shared/static_analysis/index.html

rwestphal added 4 commits May 21, 2019 15:56
@rwestphal
lib: add missing extern "C" {} blocks to new headers
eea3c89 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
*: rename new ForEach macros from the typesafe API
81fddbe 
This is necessary to avoid a name collision with std::for_each
from C++.

Fixes the compilation of the gRPC northbound module.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
tests: update list of headers in the cxx compat test
17c4745 
Now, whenever a new header is added to libfrr, this test needs to
be updated manually (unless we automate this somehow in the future).

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal
clang-format: update the ForEachMacros setting
156d446 
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
@rwestphal rwestphal force-pushed the typesafe-minor-fixes branch from b428f24 to 156d446 Compare May 21, 2019 19:02
@rwestphal
Copy link
Member Author

Updated the PR to resolve the conflicts. Removing the "blocked" label...

@rwestphal rwestphal removed the blocked We are waiting on a feature implementation from another subsystem that we do not control label May 21, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 21, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4374 156d446
Date 05/21/2019
Start 19:20:18
Finish 19:42:58
Run-Time 22:40
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-21-19:20:18.txt
Log autoscript-2019-05-21-19:21:33.log.bz2
Memory 426 429 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7781/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for zebra_rib.c | 5 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f1-31042/zebra_rib.c:131:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#131: FILE: /tmp/f2-31042/zebra_rib.c:131:
14c14
< #148: FILE: /tmp/f1-31042/zebra_rib.c:148:

CLANG Static Analyzer Summary

  • Github Pull Request 4374, comparing to Git base SHA 173c764
  • Base image data for Git 173c764 does not exist - compare skipped

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7781/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit 5349270 into FRRouting:master May 21, 2019
@eqvinox eqvinox deleted the typesafe-minor-fixes branch April 18, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqvinox eqvinox eqvinox approved these changes

Assignees
No one assigned
Labels
libfrr tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rwestphal @eqvinox @LabN-CI @NetDEF-CI @donaldsharp @polychaeta