lib: Fix gcc 9.1 and --enable-werror issues found

[donaldsharp]

Compiling FRR w/ gcc 9.1 and --enable-werror generates some
issues that need to be cleaned up.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

[mjstapp]

So interesting what the different tools "see"...

[donaldsharp]

yeah I know, in the long run the code base is better for these types of fixes.

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4352 4255dbe
Date	05/16/2019
Start	09:25:23
Finish	09:49:26
Run-Time	24:03
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-16-09:25:23.txt
Log	autoscript-2019-05-16-09:26:09.log.bz2
Memory	433 434 361

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7722/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4352, comparing to Git base SHA cf277e9

Fixed warnings:

• Dead store: Dead assignment in lib/routemap.c, function route_map_add_match, line 1320
• Dead store: Dead assignment in lib/routemap.c, function route_map_add_set, line 1403
• Dead store: Dead assignment in lib/routemap.c, function route_map_add_set, line 1403
• Dead store: Dead assignment in lib/routemap.c, function route_map_add_match, line 1320

Static Analysis warning summary compared to base:

• Fixed warnings: 4
• New warnings: 0

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7722/artifact/shared/static_analysis/index.html