Pimd : S,G Mroute entries are not expiring even after KAT expiry, remain as stale entries. #4251
Conversation
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7473/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base12 Static Analyzer issues remaining.See details at |
|
This looks reasonable. Please add your analysis to the actual commit itself for future people to be able to reference. I'm running this change against our internal pim smoke tests and will know where we are in about 10 hours. |
become stale entries. Topology: -------- Source | FHR | RP ------ LHR --- Recv1 | Recv2 Root case : ----------- When RP acts as a LHR i.e RP has a local receiver and registed for the same group where LHR connected receiver also registered for the same multicast group.When RP receives a (s,g) join form LHR , it increments upstream ref count to two to track the Local membership as well.But at the time of KAT expiry in RP , upstream reference is not being removed Which is added to track local membership which is causing to make these entries as stale in RP and FHR. Fix : Made the change such that it removes the upstream reference if it is added to track the local memberships. Signed-off-by: Rajesh Girada <rgirada@vmware.com>
|
Thanks @donaldsharp . |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7595/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base12 Static Analyzer issues remaining.See details at |
Scenario :
Source
|
FHR
|
RP ------ LHR --- Recv1
|
Recv2
Root case : When RP acts as a LHR i.e RP has a local receiver and registed for the same group
Where LHR connected receiver also registered for the same multicast group.
When RP receives a (s,g) join form LHR , it increments upstream ref count to two to track the
Local membership as well.
But at the time of KAT expiry in RP , upstream reference is not being removed Which is added
to track local membership which is causing to make these entries as stale in RP and FHR.
Fix : Made the change such that it removes the upstream reference if it is added to track the
Local memberships.
Signed-off-by: Rajesh Girada rgirada@vmware.com