Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimd : S,G Mroute entries are not expiring even after KAT expiry, remain as stale entries. #4251

Merged
merged 1 commit into from
May 9, 2019

Conversation

rgirada
Copy link
Contributor

@rgirada rgirada commented May 3, 2019

Scenario :

Source
|
FHR
|
RP ------ LHR --- Recv1
|
Recv2

Root case : When RP acts as a LHR i.e RP has a local receiver and registed for the same group
Where LHR connected receiver also registered for the same multicast group.
When RP receives a (s,g) join form LHR , it increments upstream ref count to two to track the
Local membership as well.
But at the time of KAT expiry in RP , upstream reference is not being removed Which is added
to track local membership which is causing to make these entries as stale in RP and FHR.

Fix : Made the change such that it removes the upstream reference if it is added to track the
Local memberships.

Signed-off-by: Rajesh Girada rgirada@vmware.com

@polychaeta polychaeta added the pim label May 3, 2019
@qlyoung qlyoung added the bugfix label May 3, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 3, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4251 9e53350
Date 05/03/2019
Start 13:50:20
Finish 14:14:32
Run-Time 24:12
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-03-13:50:20.txt
Log autoscript-2019-05-03-13:51:05.log.bz2
Memory 447 432 374

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7473/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4251, comparing to Git base SHA 43932ad

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7473/artifact/shared/static_analysis/index.html

@donaldsharp
Copy link
Member

This looks reasonable. Please add your analysis to the actual commit itself for future people to be able to reference. I'm running this change against our internal pim smoke tests and will know where we are in about 10 hours.

       become stale entries.

Topology:
--------
Source
|
FHR
|
RP ------ LHR --- Recv1
|
Recv2

Root case :
-----------
When RP acts as a LHR i.e RP has a local receiver and registed for
the same group where LHR connected receiver also registered for the
same multicast group.When RP receives a (s,g) join form LHR , it
increments upstream ref count to two to track the Local membership
as well.But at the time of KAT expiry in RP , upstream reference
is not being removed Which is added to track local membership which
is causing to make these entries as stale in RP and FHR.

Fix : Made the change such that it removes the upstream reference
if it is added to track the local memberships.

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
@rgirada rgirada force-pushed the fix_pim_upstream branch from 9e53350 to e3e532d Compare May 9, 2019 10:00
@rgirada
Copy link
Contributor Author

rgirada commented May 9, 2019

Thanks @donaldsharp .
As suggested , I have updated the commit message with detailed analysis.

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 9, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4251 e3e532d
Date 05/09/2019
Start 06:05:20
Finish 06:29:28
Run-Time 24:08
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-09-06:05:20.txt
Log autoscript-2019-05-09-06:06:07.log.bz2
Memory 446 437 374

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7595/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4251, comparing to Git base SHA 12456ad

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7595/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit 7f53baa into FRRouting:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants